> On Sept. 12, 2014, 11:18 a.m., shwethags wrote: > > docs/src/site/twiki/WorkflowFunctionalSpec.twiki, line 611 > > <https://reviews.apache.org/r/24165/diff/1/?file=647181#file647181line611> > > > > rename to MapredActionConfigurator?
I wanted to keep this generic enough that if we later decide to use it for other action(s) in the future, we can easily do so. That's why the code is mostly in the parent classes too. > On Sept. 12, 2014, 11:18 a.m., shwethags wrote: > > docs/src/site/twiki/WorkflowFunctionalSpec.twiki, line 612 > > <https://reviews.apache.org/r/24165/diff/1/?file=647181#file647181line612> > > > > rename to configure? Will do. > On Sept. 12, 2014, 11:18 a.m., shwethags wrote: > > docs/src/site/twiki/WorkflowFunctionalSpec.twiki, line 634 > > <https://reviews.apache.org/r/24165/diff/1/?file=647181#file647181line634> > > > > Will the JobConf have all the workflow params? Else, it may not be > > useful. For example, setting input path and output path depends on workflow > > params You mean the stuff that gets set in job.properties? I'll look if there's a good way to include them. > On Sept. 12, 2014, 11:18 a.m., shwethags wrote: > > docs/src/site/twiki/WorkflowFunctionalSpec.twiki, line 647 > > <https://reviews.apache.org/r/24165/diff/1/?file=647181#file647181line647> > > > > the jar can be in workflow lib path or need to be specified in <file> > > option of action? Any of the many ways of including jar files with an action should work. It just needs to be on the classpath of the action. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24165/#review53165 ----------------------------------------------------------- On July 31, 2014, 10:33 p.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24165/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 10:33 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1954 > https://issues.apache.org/jira/browse/OOZIE-1954 > > > Repository: oozie-git > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-1954 > > > Diffs > ----- > > client/src/main/resources/oozie-workflow-0.5.xsd 6620a4e > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 94b55cf > core/src/test/java/org/apache/oozie/action/hadoop/MapperReducerForTest.java > 7fe1f42 > docs/src/site/twiki/WorkflowFunctionalSpec.twiki 3319bcc > examples/src/main/apps/map-reduce/job-with-config-class.properties > PRE-CREATION > examples/src/main/apps/map-reduce/job.properties 7b7a24c > examples/src/main/apps/map-reduce/workflow-with-config-class.xml > PRE-CREATION > > examples/src/main/java/org/apache/oozie/example/SampleOozieActionConfigurator.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > 2cb690f > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 322f498 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > f417a78 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieActionConfigurator.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieActionConfiguratorException.java > PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java > 67a2a43 > > sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/OozieActionConfiguratorForTest.java > PRE-CREATION > > sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > e78c98a > > sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java > bcc22f2 > > Diff: https://reviews.apache.org/r/24165/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
