[ https://issues.apache.org/jira/browse/OOZIE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144061#comment-14144061 ]
Hadoop QA commented on OOZIE-1980: ---------------------------------- Testing JIRA OOZIE-1980 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} - patch does not compile, cannot run testcases {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2003/ > Sql error should not fail coord job > ----------------------------------- > > Key: OOZIE-1980 > URL: https://issues.apache.org/jira/browse/OOZIE-1980 > Project: Oozie > Issue Type: Bug > Reporter: Purshotam Shah > Assignee: Purshotam Shah > Attachments: OOZIE-1980-V1.patch, OOZIE-1980-V2.patch, > OOZIE-1980-V3.patch, OOZIE-1980-V4.patch > > > We know that sql error is transient, it should not fail the job. > We should ignore the SQL error, so that next materialization cycle can pick > the job. > {code} > protected void materialize() throws CommandException { > Instrumentation.Cron cron = new Instrumentation.Cron(); > cron.start(); > try { > materializeActions(false); > updateJobMaterializeInfo(coordJob); > } > catch (CommandException ex) { > LOG.warn("Exception occurred:" + ex.getMessage() + " Making the > job failed ", ex); > coordJob.setStatus(Job.Status.FAILED); > coordJob.resetPending(); > // remove any materialized actions and slaEvents > insertList.clear(); > } > catch (Exception e) { > LOG.error("Exception occurred:" + e.getMessage() + " Making the > job failed ", e); > coordJob.setStatus(Job.Status.FAILED); > try { > > CoordJobQueryExecutor.getInstance().executeUpdate(CoordJobQuery.UPDATE_COORD_JOB_MATERIALIZE, > coordJob); > } > catch (JPAExecutorException jex) { > throw new CommandException(ErrorCode.E1011, jex); > } > throw new CommandException(ErrorCode.E1012, e.getMessage(), e); > } finally { > cron.stop(); > instrumentation.addCron(INSTRUMENTATION_GROUP, getName() + > ".materialize", cron); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)