[ 
https://issues.apache.org/jira/browse/OOZIE-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491957#comment-14491957
 ] 

Hadoop QA commented on OOZIE-2159:
----------------------------------

Testing JIRA OOZIE-2159

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 
132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.    {color:red}WARNING{color}: the current HEAD has 1 Javadoc warning(s)
{color:red}-1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1655
.    Tests failed: 6
.    Tests errors: 0

.    The patch failed the following testcases:

.      testCoordLogStreaming(org.apache.oozie.TestCoordinatorEngineStreamLog)
.      
testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerService)
.      testValidateWorkFlowCommand(org.apache.oozie.client.TestOozieCLI)
.      testAdminInstrumentation(org.apache.oozie.client.TestOozieCLI)
.      
testCoordRerunDateNeg(org.apache.oozie.command.coord.TestCoordRerunXCommand)
.      testValid(org.apache.oozie.cli.TestValidation)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}.   There is at least one warning, please check{color}

The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/2308/

> 'oozie validate' command should be moved server-side
> ----------------------------------------------------
>
>                 Key: OOZIE-2159
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2159
>             Project: Oozie
>          Issue Type: New Feature
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Azrael
>         Attachments: OOZIE-2159.1.patch
>
>
> The {{oozie validate}} command runs an XML validator against a workflow, 
> coordinator, or bundle XML file to check that it's valid with any of the XSD 
> schema files we have.
> Currently, this is implemented in the Oozie CLI 
> ({{OozieCLI.validateCommand(...)}}, which has some downsides:
> # It's only available to OozieCLI users; anyone using the REST API can't use 
> it
> # It's currently hardcoded to the specific XSD files we ship with Oozie
> ## Whenever we add a new schema, we have to also manually update this, which 
> is easy to forget
> ## Users can't validate custom schemas that the Oozie server would accept
> We should move this to the Oozie server, perhaps at a new "validate" 
> endpoint.  It should be able to accept a local file path (the current 
> behavior) and perhaps also an HDFS file while we're at it.  For the local XML 
> file, it can just be uploaded as part of the REST call.
> Also, the description for the command needs to be updated to mention that it 
> also handles coordinators and bundles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to