Re: Review Request 31103: OOZIE-2134 Remove references to Services.get().getConf() in code

Wed, 15 Apr 2015 18:42:55 -0700 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31103/
-----------------------------------------------------------

(Updated April 16, 2015, 1:42 a.m.)


Review request for oozie.


Changes
-------

Rebased.
Increase readability at setting configuration in test cases.


Bugs: OOZIE-2134
    https://issues.apache.org/jira/browse/OOZIE-2134


Repository: oozie-git


Description
-------

To set the configuration for the test cases, I added {{ 
XTestCase#getOozieConfiguration(Services services) }}.
Patch was written without --no-prefix option.


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/CoordinatorEngine.java cb67be0 
  core/src/main/java/org/apache/oozie/action/ActionExecutor.java ea652f3 
  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
cf22ed6 
  core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java 
069a734 
  core/src/main/java/org/apache/oozie/command/XCommand.java 655670d 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java
 d51f0d7 
  
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
 cc34627 
  
core/src/main/java/org/apache/oozie/command/coord/CoordStatusTransitXCommand.java
 ffc5c44 
  core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 
cae9591 
  core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 7f59186 
  core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java 
09b110e 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
 ffe91ec 
  core/src/main/java/org/apache/oozie/local/LocalOozie.java f99efea 
  core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1afd01b 
  core/src/main/java/org/apache/oozie/service/ActionService.java becc69b 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java cd2372e 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java fd7b55f 
  core/src/main/java/org/apache/oozie/service/CallbackService.java 405701d 
  core/src/main/java/org/apache/oozie/service/ConfigurationService.java d602e53 
  
core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 
1cbd474 
  core/src/main/java/org/apache/oozie/service/DBLiteWorkflowStoreService.java 
4f2c350 
  core/src/main/java/org/apache/oozie/service/ELService.java 2506e99 
  core/src/main/java/org/apache/oozie/service/EventHandlerService.java 22c6fb0 
  core/src/main/java/org/apache/oozie/service/GroupsService.java f911568 
  core/src/main/java/org/apache/oozie/service/HCatAccessorService.java 249b663 
  core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 
102699b 
  core/src/main/java/org/apache/oozie/service/InstrumentationService.java 
0572f7f 
  core/src/main/java/org/apache/oozie/service/JMSAccessorService.java e6dc440 
  core/src/main/java/org/apache/oozie/service/JMSTopicService.java 35c82c3 
  core/src/main/java/org/apache/oozie/service/JPAService.java 906cb0f 
  core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 
a89258a 
  core/src/main/java/org/apache/oozie/service/JvmPauseMonitorService.java 
f0c72f3 
  
core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java 
29f6294 
  
core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
 c8f2b20 
  core/src/main/java/org/apache/oozie/service/PauseTransitService.java 823cc5f 
  core/src/main/java/org/apache/oozie/service/ProxyUserService.java 65e377f 
  core/src/main/java/org/apache/oozie/service/PurgeService.java 6e4a8e8 
  core/src/main/java/org/apache/oozie/service/RecoveryService.java 4b4a3f2 
  core/src/main/java/org/apache/oozie/service/SchedulerService.java b63a004 
  core/src/main/java/org/apache/oozie/service/Services.java 5857055 
  core/src/main/java/org/apache/oozie/service/ShareLibService.java 51eb297 
  core/src/main/java/org/apache/oozie/service/StatusTransitService.java 85ab668 
  core/src/main/java/org/apache/oozie/service/URIHandlerService.java c4a3701 
  core/src/main/java/org/apache/oozie/service/UUIDService.java cd4ee2f 
  core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 6b6e97c 
  core/src/main/java/org/apache/oozie/service/WorkflowSchemaService.java 
ce96371 
  core/src/main/java/org/apache/oozie/service/XLogStreamingService.java c15c4c1 
  core/src/main/java/org/apache/oozie/service/ZKLocksService.java 7fc4d17 
  core/src/main/java/org/apache/oozie/servlet/AuthFilter.java b5b477d 
  core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java adaab76 
  core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 0d7123a 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 42313fd 
  core/src/main/java/org/apache/oozie/sla/service/SLAService.java ef1d335 
  core/src/main/java/org/apache/oozie/util/StatusUtils.java 24eba21 
  core/src/main/java/org/apache/oozie/util/ZKUtils.java 0ce32b1 
  core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java d11f7dc 
  core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java 285827d 
  core/src/main/resources/oozie-default.xml ffff7c3 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java 
6d8e48a 
  core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 
1ccd22d 
  core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 
386fef3 
  core/src/test/java/org/apache/oozie/action/hadoop/TestHCatPrepareActions.java 
d66d9c9 
  core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 31b5e91 
  
core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherHCatURIHandler.java
 66d4ecc 
  core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 
ceaef8b 
  
core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 
2775baa 
  
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
 9ab897a 
  core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java d141538 
  
core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 
bcd7d24 
  core/src/test/java/org/apache/oozie/command/coord/TestBulkCoordXCommand.java 
27e294d 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
 f78dafd 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 
f9a276f 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 
111eace 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java
 22abeb3 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 
5f72e57 
  core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 
f503b1f 
  core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java ce32e51 
  core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java 
4268b30 
  core/src/test/java/org/apache/oozie/compression/TestCodecFactory.java a14641b 
  core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java e1cf133 
  core/src/test/java/org/apache/oozie/dependency/TestHCatURIHandler.java 
a49eba5 
  core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 14f5294 
  core/src/test/java/org/apache/oozie/event/TestEventQueue.java 3bb6c56 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java
 9077970 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteJPAExecutor.java
 c7e0c38 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java
 c666b87 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java
 fb15d6a 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java
 bff5836 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java
 fd80e74 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsBasicInfoFromCoordParentIdJPAExecutor.java
 ba01f29 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsBasicInfoFromWorkflowParentIdJPAExecutor.java
 e275520 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java
 c4ca61b 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromCoordParentIdJPAExecutor.java
 4a58ab2 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromWorkflowParentIdJPAExecutor.java
 41c00a9 
  core/src/test/java/org/apache/oozie/jms/TestDefaultConnectionContext.java 
e941a8e 
  core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 728916e 
  core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151 
  core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 
c465c7f 
  core/src/test/java/org/apache/oozie/service/TestActionService.java 5b5ac93 
  core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 
ce461c1 
  core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 
ddb3d58 
  core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 
4c2010b 
  core/src/test/java/org/apache/oozie/service/TestGroupsService.java d1abc6e 
  
core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerEhCache.java
 24ff36b 
  
core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerService.java
 031e3e4 
  core/src/test/java/org/apache/oozie/service/TestHASLAService.java 795db37 
  core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
791f568 
  core/src/test/java/org/apache/oozie/service/TestHCatAccessorService.java 
b195fb7 
  core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 
bbe2594 
  core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
505049d 
  core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 383e53e 
  core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java 
011a574 
  core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 
560fedb 
  
core/src/test/java/org/apache/oozie/service/TestMetricsInstrumentationService.java
 59945a7 
  
core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java
 b844145 
  
core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java
 a5d2ed9 
  core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 
677a360 
  core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 47affc2 
  core/src/test/java/org/apache/oozie/service/TestPurgeService.java 74d34cc 
  core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 9f8e65f 
  core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 
d25a2a4 
  core/src/test/java/org/apache/oozie/service/TestZKLocksService.java 02cc137 
  core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java ce731a1 
  
core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 
ef3a505 
  core/src/test/java/org/apache/oozie/servlet/TestBulkMonitorWebServiceAPI.java 
b4054b0 
  core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 
7e1921e 
  core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 7a710c2 
  core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java ebb12f7 
  core/src/test/java/org/apache/oozie/sla/TestSLAService.java 20d4869 
  core/src/test/java/org/apache/oozie/test/XTestCase.java 27cbdc9 
  core/src/test/java/org/apache/oozie/test/ZKXTestCase.java dfbea88 
  core/src/test/java/org/apache/oozie/util/TestConfigUtils.java 6904881 
  core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java 46f273f 
  
sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
 d4095da 
  tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java a639f4a 
  tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java 2d9cf3a 
  tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java 829d979 
  
zookeeper-security-tests/src/test/java/org/apache/oozie/test/ZKXTestCaseWithSecurity.java
 f9f3e88 
  
zookeeper-security-tests/src/test/java/org/apache/oozie/util/TestZKUtilsWithSecurity.java
 ffced02 

Diff: https://reviews.apache.org/r/31103/diff/


Testing
-------

Unit Test.
Manual Test.


Thanks,

Azrael Park

Reply via email to