----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34854/#review87894 -----------------------------------------------------------
Some minor comments. In general, avoid extra code so that code is more readable and maintainable core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java <https://reviews.apache.org/r/34854/#comment140301> '== true' is not required core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java <https://reviews.apache.org/r/34854/#comment140302> prefix all related configs with 'oozie.external_monitoring.'. For example, change oozie.metrics.report.interval.sec - oozie.external_monitoring.reporterIntervalSecs oozie.metrics.host - oozie.external_monitoring.address (covers both host and port so that there are less configs that users need to set) oozie.metrics.server.name - oozie.external_monitoring.type oozie.metrics.prefix - oozie.external_monitoring.metricPrefix Use . for hierarchical configs, not as word separator core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java <https://reviews.apache.org/r/34854/#comment140306> default is STD, skip settting it core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java <https://reviews.apache.org/r/34854/#comment140303> change log level to debug core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java <https://reviews.apache.org/r/34854/#comment140304> Combine reading confs and reporter initialisation to one if block core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java <https://reviews.apache.org/r/34854/#comment140307> use LOG core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java <https://reviews.apache.org/r/34854/#comment140308> Move the common code of the if blocks to outside if block. You can create the graphite/ganlia registry inside if blocks and rest outside core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/34854/#comment140305> default to just 'oozie'? - Shwetha GS On June 12, 2015, 7:53 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34854/ > ----------------------------------------------------------- > > (Updated June 12, 2015, 7:53 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2251 > https://issues.apache.org/jira/browse/OOZIE-2251 > > > Repository: oozie-git > > > Description > ------- > > We have been logging so many important matrices in oozie-instrumentation.log > . These information is very useful for oozie functional monitoring. But it is > always difficult to get the meaning from flat file. If we expose this > information on some graphing tool, We can get the lot of meaning out of it > and can take some actions based on it. > > > Diffs > ----- > > core/pom.xml 7877773 > > core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java > 29f6294 > core/src/main/java/org/apache/oozie/util/Instrumentation.java 3dfb67a > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java > e56bfda > core/src/main/resources/oozie-default.xml 8960073 > docs/src/site/twiki/AG_Install.twiki 0ce2609 > > Diff: https://reviews.apache.org/r/34854/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
