----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23301/#review74731 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java (line 130) <https://reviews.apache.org/r/23301/#comment140619> Action id is missing in all loging core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java (line 108) <https://reviews.apache.org/r/23301/#comment121433> keeping the status alone without the id does not make any sense, It might be your restructuring bug? - Jaydeep Vishwakarma On Feb. 26, 2015, 4:50 a.m., Azrael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23301/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 4:50 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1918 > https://issues.apache.org/jira/browse/OOZIE-1918 > > > Repository: oozie-git > > > Description > ------- > > Subclasses of ActionXCommand have some duplicated code. Refactoring make it > more neat. > This patch contain: > * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending > ActionXCommand > * Moving some variables and methods to ActionXCommand and making it protected > * More meaningful log message : On exeucte(), actionId is duplicated so > removed > * Adding handleExecutionFail() to handle ActionExcutionException during > execute() > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/DagEngine.java ac2e7b1 > core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > e9488d4 > core/src/main/java/org/apache/oozie/command/wf/ActionCompletedXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 4006441 > core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 33498bf > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > d4048a1 > core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 69a363b > core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java > b1226cc > core/src/test/java/org/apache/oozie/ForTestingActionExecutor.java a70dc02 > core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 14f5294 > > Diff: https://reviews.apache.org/r/23301/diff/ > > > Testing > ------- > > No added new testcase. > Done manual test. > > > Thanks, > > Azrael Park > >
