----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35379/#review90671 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 95) <https://reviews.apache.org/r/35379/#comment143804> rename to oozie.globalconf core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 488) <https://reviews.apache.org/r/35379/#comment143806> add a comment that this merges the parent global conf and current global conf. Then sets the merged global conf in jobConf Minor comments, looks good otherwise. Simpler and nice approach. Thanks - Shwetha GS On June 16, 2015, 12:06 p.m., Jaydeep Vishwakarma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35379/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 12:06 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2030 > https://issues.apache.org/jira/browse/OOZIE-2030 > > > Repository: oozie-git > > > Description > ------- > > Forwarding global conf from workflow to action when action is subworkflow, > subworkflow storing it to property and forwarding as property. > LiteworkflowAppParser handling all condition and ensuring child level pass > of global conf. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > c857011 > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > 9ab897a > > Diff: https://reviews.apache.org/r/35379/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Jaydeep Vishwakarma > >
