> On Aug. 27, 2015, 10:03 p.m., Rohini Palaniswamy wrote: > > sharelib/spark/src/main/java/org.apache.oozie.action.hadoop/SparkMain.java, > > line 123 > > <https://reviews.apache.org/r/37452/diff/1/?file=1039664#file1039664line123> > > > > Can you add just add a comment here saying this is redundant for > > yarnClientMode as driver is the launcher jvm and it is already launched. > > Robert Kanter wrote: > Surprisingly, IIRC, this is actually required even though you'd think it > would be able to use the JVM's classpath (I think they must do something > funny with classloaders). I'll double check and add a comment if it's not.
Ya, it's necessary. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37452/#review95987 ----------------------------------------------------------- On Aug. 13, 2015, 11:42 p.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37452/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 11:42 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2277 > https://issues.apache.org/jira/browse/OOZIE-2277 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2277 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/SparkConfigurationService.java > 1b7cf4a > > core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java > b2c499d > sharelib/spark/pom.xml 6f7e74a > sharelib/spark/src/main/java/org.apache.oozie.action.hadoop/SparkMain.java > b18a0b9 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java > f271abc > > Diff: https://reviews.apache.org/r/37452/diff/ > > > Testing > ------- > > - Ran unit tests with Hadoop 1 and Hadoop 2 > - Ran in a Hadoop 2 cluster with local, yarn-client, and yarn-cluster modes > > > Thanks, > > Robert Kanter > >
