[ 
https://issues.apache.org/jira/browse/OOZIE-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052005#comment-15052005
 ] 

Robert Kanter edited comment on OOZIE-2185 at 12/11/15 1:56 AM:
----------------------------------------------------------------

I played around with this.  It looks good.  One thing though is that I think 
the oozie-client-env.sh should end up in the conf dir of a deployment, like 
oozie-env.sh does.
{noformat}
>> [29] 17:46 : oozie (master) :: ls -l conf
total 280
drwxr-xr-x  3 rkanter  staff     102 Dec 10 17:42 action-conf
-rw-r--r--  1 rkanter  staff     824 Dec 10 17:42 adminusers.txt
drwxr-xr-x  3 rkanter  staff     102 Dec 10 17:42 hadoop-conf
-rw-r--r--  1 rkanter  staff    1409 Dec 10 17:42 hadoop-config.xml
-rw-r--r--  1 rkanter  staff  112856 Dec 10 17:42 oozie-default.xml.reference
-rw-r--r--  1 rkanter  staff    2215 Dec 10 17:42 oozie-env.cmd
-rw-r--r--  1 rkanter  staff    2114 Dec 10 17:42 oozie-env.sh
-rw-r--r--  1 rkanter  staff    5937 Dec 10 17:42 oozie-log4j.properties
-rw-r--r--  1 rkanter  staff     198 Dec 10 17:43 oozie-site.xml
{noformat}
It does show up when I build Oozie, so maybe it's being excluded from the 
tarball or something?
{noformat}
>> [13] 17:52 : oozie-trunk (master) :: ls -l 
>> distro/target/oozie-4.3.0-SNAPSHOT-distro/oozie-4.3.0-SNAPSHOT/conf/
total 288
drwxr-xr-x  3 rkanter  staff     102 Dec 10 17:42 action-conf
-rw-r--r--  1 rkanter  staff     824 Dec 10 17:42 adminusers.txt
drwxr-xr-x  3 rkanter  staff     102 Dec 10 17:42 hadoop-conf
-rw-r--r--  1 rkanter  staff    1409 Dec 10 17:42 hadoop-config.xml
-rw-r--r--@ 1 rkanter  staff      43 Dec 10 17:49 oozie-client-env.sh
-rw-r--r--  1 rkanter  staff  112856 Dec 10 17:42 oozie-default.xml.reference
-rw-r--r--  1 rkanter  staff    2215 Dec 10 17:42 oozie-env.cmd
-rw-r--r--  1 rkanter  staff    2114 Dec 10 17:42 oozie-env.sh
-rw-r--r--  1 rkanter  staff    5937 Dec 10 17:42 oozie-log4j.properties
-rw-r--r--  1 rkanter  staff     198 Dec 10 17:43 oozie-site.xml
{noformat}


was (Author: rkanter):
I played around with this.  It looks good.  One thing though is that I think 
the reference oozie-client-env.sh should end up in the conf dir of a 
deployment, like oozie-env.sh does.
{noformat}
>> [29] 17:46 : oozie (master) :: ls -l conf
total 280
drwxr-xr-x  3 rkanter  staff     102 Dec 10 17:42 action-conf
-rw-r--r--  1 rkanter  staff     824 Dec 10 17:42 adminusers.txt
drwxr-xr-x  3 rkanter  staff     102 Dec 10 17:42 hadoop-conf
-rw-r--r--  1 rkanter  staff    1409 Dec 10 17:42 hadoop-config.xml
-rw-r--r--  1 rkanter  staff  112856 Dec 10 17:42 oozie-default.xml.reference
-rw-r--r--  1 rkanter  staff    2215 Dec 10 17:42 oozie-env.cmd
-rw-r--r--  1 rkanter  staff    2114 Dec 10 17:42 oozie-env.sh
-rw-r--r--  1 rkanter  staff    5937 Dec 10 17:42 oozie-log4j.properties
-rw-r--r--  1 rkanter  staff     198 Dec 10 17:43 oozie-site.xml
{noformat}
It does show up when I build Oozie, so maybe it's being excluded from the 
tarball or something?
{noformat}
>> [13] 17:52 : oozie-trunk (master) :: ls -l 
>> distro/target/oozie-4.3.0-SNAPSHOT-distro/oozie-4.3.0-SNAPSHOT/conf/
total 288
drwxr-xr-x  3 rkanter  staff     102 Dec 10 17:42 action-conf
-rw-r--r--  1 rkanter  staff     824 Dec 10 17:42 adminusers.txt
drwxr-xr-x  3 rkanter  staff     102 Dec 10 17:42 hadoop-conf
-rw-r--r--  1 rkanter  staff    1409 Dec 10 17:42 hadoop-config.xml
-rw-r--r--@ 1 rkanter  staff      43 Dec 10 17:49 oozie-client-env.sh
-rw-r--r--  1 rkanter  staff  112856 Dec 10 17:42 oozie-default.xml.reference
-rw-r--r--  1 rkanter  staff    2215 Dec 10 17:42 oozie-env.cmd
-rw-r--r--  1 rkanter  staff    2114 Dec 10 17:42 oozie-env.sh
-rw-r--r--  1 rkanter  staff    5937 Dec 10 17:42 oozie-log4j.properties
-rw-r--r--  1 rkanter  staff     198 Dec 10 17:43 oozie-site.xml
{noformat}

> Make oozie cli source /etc/oozie/conf/oozie-env.sh (or some other env script)
> -----------------------------------------------------------------------------
>
>                 Key: OOZIE-2185
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2185
>             Project: Oozie
>          Issue Type: New Feature
>          Components: client
>    Affects Versions: 4.3.0
>            Reporter: Robert Justice
>            Assignee: Mike Grimes
>            Priority: Minor
>              Labels: client, feature, newbie
>         Attachments: OOZIE-2185-1.patch, OOZIE-2185-2.patch, 
> OOZIE-2185-3.patch
>
>
> Currently, the oozie cli doesn't source any environment script.   Users may 
> wish to define environment variables such as OOZIE_URL outside of normal 
> shell environment and have the oozie cli source /etc/oozie/conf/oozie-env.sh. 
>  This is somewhat confusing when users see hadoop commands sourcing 
> hadoop-env.sh, mapred-env.sh, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to