[ 
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101769#comment-15101769
 ] 

Ferenc Denes commented on OOZIE-2429:
-------------------------------------

Thanks for the review.
1. In the if statement (as in the patch) we update the modified time, add other 
commands above generating events. I think we should do all those only in case 
of any _real_ modification. That's why I have kept all those in there. I think 
it is right this way, and also safer to handle all those together. Kept it in 
there, if you still think it is necessary to ammend I will do it.

2. I have modified it to debug, however it was info as the other similar log 
messages were info as well.

3. Fixed all those.

4. Removed that.

> TestEventGeneration test is flakey
> ----------------------------------
>
>                 Key: OOZIE-2429
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2429
>             Project: Oozie
>          Issue Type: Bug
>          Components: action, tests
>    Affects Versions: trunk
>            Reporter: Ferenc Denes
>            Assignee: Ferenc Denes
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: OOZIE-2429-1.patch, OOZIE-2429-2.patch
>
>
> TestEventGeneration's testForNoDuplicates fails tome to time depending on the 
> circumstances of the test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to