[ 
https://issues.apache.org/jira/browse/OOZIE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113885#comment-15113885
 ] 

Purshotam Shah commented on OOZIE-2444:
---------------------------------------

Looks good. Few minor comment.
{code}
+++ client/src/main/resources/oozie-bundle-0.1.xsd
@@ -44,6 +44,7 @@
         </xs:sequence>
         <xs:attribute name="name" type="bundle:IDENTIFIER" use="required"/>
         <xs:attribute name="critical" type="xs:string" use="optional"/>
+        <xs:attribute name="enabled" type="xs:string" use="optional"/>
     </xs:complexType>
{code}
Only for bundle-0.2.xsd. We only support adding variables to latest xsd. 

{code}
+        assertEquals(job.getId(), actions.get(0).getBundleId());
+        assertEquals(job.getId(), actions.get(0).getBundleId());
{code}
Duplicate assert, remove one.


> Need conditional logic in bundles
> ---------------------------------
>
>                 Key: OOZIE-2444
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2444
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Satish Subhashrao Saley
>            Assignee: Satish Subhashrao Saley
>            Priority: Minor
>         Attachments: OOZIE-2444-1.patch
>
>
> Sometimes, the users have a semi-complicated pipeline that needs to run in 
> slightly different ways depending on whether they are running against live 
> data, reprocessing recent data, or reprocessing historical data from another 
> cluster. Instead of having to create multiple different bundles to capture 
> these various cases, it would be good to have some sort of conditional logic 
> in the bundle XML file that users can use to enable or disable specific 
> coordinators within the bundle based on the properties passed in. That way, 
> we can control, either from the properties file or from oozie command line 
> options, the coordinators that get run and the mode that overall pipeline is 
> processing in.
> Ideally, this would be supported by extending the <coordinator> tag with a 
> new "enabled" attribute that takes a boolean expression and supports standard 
> expression syntax and functions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to