[ 
https://issues.apache.org/jira/browse/OOZIE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318881#comment-15318881
 ] 

Purshotam Shah commented on OOZIE-2532:
---------------------------------------

Apply apply is broken for few people. I use to  generate patch using {{git diff 
--no-prefix --full-index}}, it's failing if patch has new file. 

> patch apply does not handle binary files
> ----------------------------------------
>
>                 Key: OOZIE-2532
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2532
>             Project: Oozie
>          Issue Type: Task
>            Reporter: Peter Cseh
>            Assignee: Peter Cseh
>             Fix For: trunk
>
>         Attachments: OOZIE-2532-001.patch, OOZIE-2532-002.patch
>
>
> In OOZIE-2482 there is a patch which contains binary files as well.
> After running 
> {quote}patch -E -p0  <~/Downloads/OOZIE-2482-2.patch {quote}
> the folder sharelib/spark/src/test/resources contains only pi.py, and not the 
> zip files.
> {quote}git apply -p0  <~/Downloads/OOZIE-2482-2.patch {quote}
> processes the binary part of the patch as well.
> Git documentation claims that patches created with --binary can be applied 
> with git apply, I assume they know that it's not compatible with the patch 
> command.
> Should we change this in the Jenkins job or we should keep this behavior as a 
> gatekeeper to prevent binary files committed to master?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to