[
https://issues.apache.org/jira/browse/OOZIE-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339570#comment-15339570
]
Hadoop QA commented on OOZIE-2579:
----------------------------------
Testing JIRA OOZIE-2579
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1787
. Tests failed: 5
. Tests errors: 2
. The patch failed the following testcases:
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3005/
> Bulk kill tests in TestBulkWorkflowXCommand might fail because of a race
> condition
> ----------------------------------------------------------------------------------
>
> Key: OOZIE-2579
> URL: https://issues.apache.org/jira/browse/OOZIE-2579
> Project: Oozie
> Issue Type: Bug
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Minor
> Attachments: OOZIE-2579-001.patch, OOZIE-2579-002.patch
>
>
> There are tests in TestBulkWorkflowXCommand which perform bulk killing.
> This might fail sometimes, because the {{externalChildIDs}} is set to
> "00000001-dummy-oozie-wrkf-W " that causes an action to fail:
> {code}
> org.apache.oozie.action.ActionExecutorException: IllegalArgumentException:
> JobId string : 00000001-dummy-oozie-wrkf-W is not properly formed
> at
> org.apache.oozie.action.ActionExecutor.convertException(ActionExecutor.java:443)
> at
> org.apache.oozie.action.hadoop.JavaActionExecutor.kill(JavaActionExecutor.java:1614)
> at
> org.apache.oozie.command.wf.ActionKillXCommand.execute(ActionKillXCommand.java:146)
> at
> org.apache.oozie.command.wf.ActionKillXCommand.execute(ActionKillXCommand.java:1)
> at org.apache.oozie.command.XCommand.call(XCommand.java:287)
> at
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:331)
> at
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:260)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:178)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.IllegalArgumentException: JobId string :
> 00000001-dummy-oozie-wrkf-W is not properly formed
> at org.apache.hadoop.mapreduce.JobID.forName(JobID.java:154)
> at org.apache.hadoop.mapred.JobID.forName(JobID.java:78)
> at
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.getRunningJob(MapReduceActionExecutor.java:342)
> at
> org.apache.oozie.action.hadoop.JavaActionExecutor.kill(JavaActionExecutor.java:1604)
> ... 10 more
> {code}
> Since this code runs on a separate thread, it might randomly interfere with
> the main test logic, which expects the job status to be "KILLED", but
> sometimes the ActionKillXCommand has a chance to update it to "FAILED".
> Solution: set a proper (parseable) job id:
> {code}
> action.setExternalChildIDs("job_201601011800_0001");
> {code}
> See
> https://hadoop.apache.org/docs/r2.6.2/api/org/apache/hadoop/mapred/JobID.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
