> On July 7, 2016, 8:57 p.m., Satish Saley wrote: > > sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java, > > line 41 > > <https://reviews.apache.org/r/49074/diff/2/?file=1438356#file1438356line41> > > > > We don't need "Job complete" pattern. It will end up with fetching > > child job id twice and in UI will contain duplicate urls. Only "Submitted > > application" is sufficient.
I agree with you. To prevent the duplicates, I added a conditional check in the LauncherMain, which checks the ids first and if not present alreadt, then appends. I have removed the above patterns. I will marking other two also as Fixed. Thanks. > On July 7, 2016, 8:57 p.m., Satish Saley wrote: > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java, > > line 96 > > <https://reviews.apache.org/r/49074/diff/2/?file=1438360#file1438360line96> > > > > It became clear after discussing with Rohini, we will write only to > > ACTION_DATA_EXTERNAL_CHILD_IDS. > > > > And for backward compatibility, we need to make changes in the > > JavaActionExecutor to read from ACTION_DATA_OUTPUT_PROPS as well. Also, we > > need to remove getCaptureOutput() and getActionData() methods from > > executors. > > I will fix those things as part of OOZIE-2561 As per the changes here, I think it is not braeking any backward compatibility things. I do observe that, currently with the successful job, external child ids are set twice, once using the ACTION_DATA_EXTERNAL_CHILD_IDS and later in the getActionData();. I guess, that is what you wanted to say for, getActionData(). I did not get the getCaptureOutput() output part in your comment. Thanks. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49074/#review141204 ----------------------------------------------------------- On July 7, 2016, 5:41 a.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49074/ > ----------------------------------------------------------- > > (Updated July 7, 2016, 5:41 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2582 > https://issues.apache.org/jira/browse/OOZIE-2582 > > > Repository: oozie-git > > > Description > ------- > > Currently Oozie external child ids are populated into workflow bean, when the > job/action completes successfully. It should populate external child ids in > case of job failures as well. > > > Diffs > ----- > > examples/src/main/apps/hive/script.q 3abc757 > > sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java > 6ac5ad6 > sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > cb0172d > > sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java > d72e298 > > sharelib/hive2/src/test/java/org/apache/oozie/action/hadoop/TestHive2ActionExecutor.java > 5963e42 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > fb190d6 > sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > 360cf1e > > Diff: https://reviews.apache.org/r/49074/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Bafna > >
