> On júl. 21, 2016, 11:32 de, Attila Sasvari wrote: > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java, > > line 142 > > <https://reviews.apache.org/r/50202/diff/1/?file=1447527#file1447527line142> > > > > This method does too many things / goes againts the Single > > responsibility principle. > > > > Can you extract methods?
You mean I should walk the graph multiple times and verify the conditions separately or shall I just extract methods from performValidation() to make it readable? - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50202/#review143068 ----------------------------------------------------------- On júl. 19, 2016, 7:56 du, Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50202/ > ----------------------------------------------------------- > > (Updated júl. 19, 2016, 7:56 du) > > > Review request for oozie. > > > Bugs: OOZIE-1978 > https://issues.apache.org/jira/browse/OOZIE-1978 > > > Repository: oozie-git > > > Description > ------- > > See OOZIE-1978 for details. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/ErrorCode.java 2907ca2 > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > a1b9cdb > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java > PRE-CREATION > core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java > 73464c8 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 9002b6c > > Diff: https://reviews.apache.org/r/50202/diff/ > > > Testing > ------- > > Existing tests pass. > > We might need to add some more, at least testing acyclic graph detection. > > > Thanks, > > Peter Bacsko > >
