> On July 26, 2016, 9 a.m., Attila Sasvari wrote: > > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, line 169 > > <https://reviews.apache.org/r/50372/diff/1/?file=1451549#file1451549line169> > > > > Would it makes sense to log when this (rare) situation happens? It > > could be useful for later analysis.
Added an INFO level log, every time config-default is resolved from workflow conf. As these cases are not so common, so should not be noise. > On July 26, 2016, 9 a.m., Attila Sasvari wrote: > > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, line 170 > > <https://reviews.apache.org/r/50372/diff/1/?file=1451549#file1451549line170> > > > > Can you please extract entry.getKey() to a local String variable (e.g. > > defaultConfKey)? Done. > On July 26, 2016, 9 a.m., Attila Sasvari wrote: > > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, line 163 > > <https://reviews.apache.org/r/50372/diff/1/?file=1451549#file1451549line163> > > > > Can you extract this part into a new method , something like private > > Configuration resolveVariablesFromConfigDefault(Configuration defaultConf)? > > > > Then you could just > > defaultConf = > > resolveVariablesFromConfigDefault(defaultConf); Done. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50372/#review143499 ----------------------------------------------------------- On July 23, 2016, 4:58 a.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50372/ > ----------------------------------------------------------- > > (Updated July 23, 2016, 4:58 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2583 > https://issues.apache.org/jira/browse/OOZIE-2583 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2583: oozie throws EL Exception when reference variable name containing > dot > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 27274b9 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java > 73464c8 > > Diff: https://reviews.apache.org/r/50372/diff/ > > > Testing > ------- > > Unit test. > > > Thanks, > > Abhishek Bafna > >
