> On Aug. 1, 2016, 7:55 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/lock/MemoryLocks.java, lines 90-92 > > <https://reviews.apache.org/r/47837/diff/1-3/?file=1393789#file1393789line90> > > > > This is redundant. lockEntry cannot be null here.
ConcurrentMap.putIfAbscent returns the previous value associated with the specified key, or null if there was no mapping for the key. Refer http://stackoverflow.com/questions/21621803/concurrenthashmap-putifabsent-is-returning-null > On Aug. 1, 2016, 7:55 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/service/ZKLocksService.java, lines > > 151-153 > > <https://reviews.apache.org/r/47837/diff/1-3/?file=1393791#file1393791line151> > > > > This is redundant. lockEntry cannot be null here. ConcurrentMap.putIfAbscent returns the previous value associated with the specified key, or null if there was no mapping for the key. Refer http://stackoverflow.com/questions/21621803/concurrenthashmap-putifabsent-is-returning-null - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/#review144379 ----------------------------------------------------------- On Aug. 1, 2016, 6:23 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47837/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 6:23 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2501 > https://issues.apache.org/jira/browse/OOZIE-2501 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2501 ZK reentrant lock doesn't work for few cases > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 41f4430f69cb7a9b132a4000c3e5c8aa7573c0a0 > core/src/main/java/org/apache/oozie/lock/MemoryLocks.java > 7d65ac0e24a62086732ec91fc24f89b62469451d > core/src/main/java/org/apache/oozie/service/MemoryLocksService.java > d7c6a89fd47a219b2ec8ea4fe0caf05dc008943b > core/src/main/java/org/apache/oozie/service/ZKLocksService.java > 952b90d5dfbfeccf4600238f75885c792709ffc7 > core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java > 61fec19b346748b22df1b58f014c32b1c04c8c1f > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > d1acadfff36fff637fb9ccb8e3feffb24248c792 > > Diff: https://reviews.apache.org/r/47837/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
