----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50833/#review145958 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/50833/#comment212312> Do we need to wait for Oozie 5 to remove this? It would break backwards compatibility. I don't think we formally define our compatibility guarantees though. tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java <https://reviews.apache.org/r/50833/#comment212313> This will only prevent the creation of this table for new databases. What about users upgrading to this version of Oozie? We need to add a new DB version where the upgrade procedure is to drop this table. Another reason why I think this will need to wait for Oozie 5. webapp/src/main/webapp/WEB-INF/web.xml (lines 26 - 30) <https://reviews.apache.org/r/50833/#comment212311> Don't forget this. - Robert Kanter On Aug. 6, 2016, 12:30 a.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50833/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2016, 12:30 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2364 > https://issues.apache.org/jira/browse/OOZIE-2364 > > > Repository: oozie-git > > > Description > ------- > > Remove deprecated SLAEventBean and related code > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java f1d0f2b > client/src/main/java/org/apache/oozie/client/OozieClient.java eee2d63 > core/pom.xml f19d83b > core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b > core/src/main/java/org/apache/oozie/command/SchemaCheckXCommand.java > 1cc086e > > core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > bdbbd24 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 45abe5a > > core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > ef49ea5 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > f6c1782 > core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > f1509e6 > core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > cae9591 > core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 740b8d3 > core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > ac096cc > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 41f4430 > core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 40b93d3 > core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java e95a60a > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 27274b9 > > core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java > bda1e48 > > core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java > 7797ff5 > > core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java > fac803a > > core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetJPAExecutor.java > 909c8d5 > core/src/main/java/org/apache/oozie/service/JPAService.java 028381d > core/src/main/java/org/apache/oozie/service/SLAStoreService.java 02899cc > core/src/main/java/org/apache/oozie/service/StoreService.java 7868e02 > core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8fad98b > core/src/main/java/org/apache/oozie/store/SLAStore.java 34f47fb > core/src/main/java/org/apache/oozie/store/Store.java b60f022 > core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java d11f7dc > core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java 285827d > core/src/main/resources/oozie-default.xml 6a9d5c4 > core/src/test/java/org/apache/oozie/TestDagELFunctions.java 3fb2029 > core/src/test/java/org/apache/oozie/TestSLAEventBean.java de942de > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 10498cb > core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java badbb16 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 29e7ca1 > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java > 7613454 > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java > 37bb4da > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java > d939478 > core/src/test/java/org/apache/oozie/store/TestSLAStore.java 7c95718 > core/src/test/java/org/apache/oozie/test/XDataTestCase.java ea778bd > core/src/test/java/org/apache/oozie/test/XTestCase.java 8ce44f3 > core/src/test/java/org/apache/oozie/util/db/TestSLADbOperations.java > 37dee73 > core/src/test/java/org/apache/oozie/util/db/TestSLADbXOperations.java > 94218be > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki e3ac514 > docs/src/site/twiki/DG_CommandLineTool.twiki af29b56 > tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 8b3e939 > webapp/src/main/webapp/WEB-INF/web.xml 89f15f3 > > Diff: https://reviews.apache.org/r/50833/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Satish Saley > >
