----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43970/#review148786 -----------------------------------------------------------
LGTM +1 after this. core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java (line 93) <https://reviews.apache.org/r/43970/#comment216298> When you rebase the patch, this is where you'll see a trivial conflict. core/src/main/java/org/apache/oozie/util/XLogFilter.java (line 213) <https://reviews.apache.org/r/43970/#comment216293> Shouldn't this be true? - Robert Kanter On June 14, 2016, 11:15 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43970/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 11:15 p.m.) > > > Review request for oozie. > > > Bugs: https://issues.apache.org/jira/browse/OOZIE-2417 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OOZIE-2417 > > > Repository: oozie-git > > > Description > ------- > > This patch tries to minimize the parsing of same log line for multiple times > using different regex. > It also caches the log parts once we figure out what those are, thus avoiding > the re-parsing of log line to get log parts whenever needed. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/util/LogLine.java PRE-CREATION > > core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java > 78cb042 > core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > f691409 > core/src/main/java/org/apache/oozie/util/XLogFilter.java 3b49f77 > > Diff: https://reviews.apache.org/r/43970/diff/ > > > Testing > ------- > > > Thanks, > > Satish Saley > >
