----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52429/ -----------------------------------------------------------
(Updated Oct. 3, 2016, 11:26 a.m.) Review request for oozie and Robert Kanter. Changes ------- Check that the downloaded FindBugs JAR file has the same MD5 as expected. Repository: oozie-git Description ------- We go for that solution: 1. create a new script as `bin/test-patch-11-findbugs-diff` so that it comes right after compile 2. `mvn clean verify -DskipTests` before and after applying the patch, and saving each and every module's `target/findbugs/findbugsXml.xml` to a secure folder 3. call the `findbugs-diff` app for all the before / after FindBugs xml pairs 4. analyze all the `findbugs-new.xml` entries for nodes with XPath `/BugCollection/BugInstance` entries. Stop on any BugInstance w/ `priority` and / or `rank` lower than threshold 5. have the reports merged and be downloadable in any case in following scenarios: * -1 for bugs that are too serious to apply the patch with them * 0 for other new bugs * +1 if there is no new bug Diffs (updated) ----- bin/test-patch-11-findbugs-diff PRE-CREATION bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION pom.xml 29184b2 Diff: https://reviews.apache.org/r/52429/diff/ Testing ------- Thanks, András Piros
