> On Oct. 21, 2016, 7:59 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java, lines > > 398-401 > > <https://reviews.apache.org/r/52227/diff/4/?file=1538373#file1538373line398> > > > > The "(w.appName LIKE..." can be made into a ````private static final > > String```` constant.
Updated the diff on upstream jira https://issues.apache.org/jira/secure/attachment/12835008/OOZIE-2225-010.patch - Sai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52227/#review153592 ----------------------------------------------------------- On Oct. 14, 2016, 6:45 p.m., Sai Chirravuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52227/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 6:45 p.m.) > > > Review request for oozie and Robert Kanter. > > > Bugs: OOZIE-2225 > https://issues.apache.org/jira/browse/OOZIE-2225 > > > Repository: oozie-git > > > Description > ------- > > commit 05c108f61f4c3da437d826b73251e92662a4518b > Author: krish <kr...@cloudera.com> > Date: Fri Sep 23 13:50:24 2016 -0700 > > OOZIE-2225 Add wild card filter for gathering jobs > > :100644 100644 f1d0f2b... f10de36... M > client/src/main/java/org/apache/oozie/cli/OozieCLI.java > :100644 100644 a882cab... 53a6ecf... M > client/src/main/java/org/apache/oozie/client/OozieClient.java > :100644 100644 01aeddf... 7597142... M > core/src/main/java/org/apache/oozie/DagEngine.java > :100644 100644 3c03267... 275aabf... M > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java > :100644 100644 fb1db29... 80f0756... M > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java > :000000 100644 0000000... dd1e943... A > core/src/main/java/org/apache/oozie/util/db/JPAUtils.java > :100644 100644 0b1f644... 87fccd6... M > core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java > :100644 100644 7d468f1... 4378286... M > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java > :100644 100644 ddb5506... 12cb16b... M > core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java > :100644 100644 ea778bd... 2fed1f8... M > core/src/test/java/org/apache/oozie/test/XDataTestCase.java > :100644 100644 567e260... 3daf38a... M > docs/src/site/twiki/DG_CommandLineTool.twiki > :100644 100644 13e1691... a66e564... M > docs/src/site/twiki/WebServicesAPI.twiki > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java > f1d0f2b7442e04e01bea93622cf378fc92934497 > client/src/main/java/org/apache/oozie/client/OozieClient.java > a882cab95c4b75c3fc641fb8e5511357d482eeff > core/src/main/java/org/apache/oozie/CoordinatorEngine.java > cec6347905233d9a5fe0eb0e2fa27336a6a967a9 > core/src/main/java/org/apache/oozie/DagEngine.java > 01aeddfc282261d9ad396565a9d3d30efec2dc59 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java > 3c032678d06641ae7bb2f2a9c0631948190ea662 > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java > fb1db29cdfe1dbe37c8e2176079f39f841232ee3 > core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java > 18df836713918a2864566b56646f711dd84a5f97 > > core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java > 0b1f644c1ff74ce24b78eadf0ed7c0cbc87e93a3 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java > 7d468f16981710d96473155df25b8de0d5ef322b > > core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java > ddb5506de90ae32d760657f8a867ab46599f1a86 > docs/src/site/twiki/DG_CommandLineTool.twiki > 567e260dd3e05c7619d957520ed49882b0cf37f2 > docs/src/site/twiki/WebServicesAPI.twiki > 13e1691c3497bed94957ef959e16e788d1196c67 > > Diff: https://reviews.apache.org/r/52227/diff/ > > > Testing > ------- > > CLI manual testing looks good and unit tests passed > > > Thanks, > > Sai Chirravuri > >
