----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53775/#review156184 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java (line 540) <https://reviews.apache.org/r/53775/#comment226323> Thanks Satish for providing the detailed information about the method. Can you please add the information about method parameters also beacuse java 8 java doc will generate a warning about it. Which We want to improve for the compelete Oozie project itself. Same for the 'getDSTOffset' method. Thanks. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java (line 679) <https://reviews.apache.org/r/53775/#comment226325> Trivial: Can this extra empty line be removed. Thanks. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java (line 976) <https://reviews.apache.org/r/53775/#comment226324> You have defined the same method into the CoordMaterializeTransitionXCommand class so can this be removed and we can use the newly added method in the testcasee. Thanks. - Abhishek Bafna On Nov. 16, 2016, 10:14 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53775/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 10:14 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2726 > https://issues.apache.org/jira/browse/OOZIE-2726 > > > Repository: oozie-git > > > Description > ------- > > [OOZIE-2726] Flaky test due to daylight saving changes > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > f6c1782 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 29e7ca1 > > Diff: https://reviews.apache.org/r/53775/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Satish Saley > >
