[
https://issues.apache.org/jira/browse/OOZIE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723686#comment-15723686
]
Robert Kanter commented on OOZIE-2741:
--------------------------------------
Looks good overall. Two minor things:
# We also need to remove {{webapp/src/main/webapp/WEB-INF/web.xml}}. And I
don't believe we need {{./webapp/src/main/webapp/META-INF/context.xml}} either?
# I found that {{JspHandler}} uses some Tomcat classes
({{org.apache.tomcat.InstanceManager}} and
{{org.apache.tomcat.SimpleInstanceManager}}) even though this is a file added
for Jetty (I missed that when reviewing OOZIE-2666). From what I can tell by a
quick search on the internet, this is the correct thing to do even though it's
Tomcat and even though we're not using any Tomcat dependencies. Can you just
double-check this? It seems strange.
> Remove Tomcat
> --------------
>
> Key: OOZIE-2741
> URL: https://issues.apache.org/jira/browse/OOZIE-2741
> Project: Oozie
> Issue Type: Sub-task
> Components: core
> Reporter: Attila Sasvari
> Assignee: Attila Sasvari
> Attachments: OOZIE-2741-1.patch, OOZIE-2741-2.patch,
> OOZIE-2741-3.patch, OOZIE-2741-4.patch
>
>
> Supporting both embedded Oozie and Tomcat makes things unnecessarily
> complicated.
> Some benefits of removing Tomcat:
> - Removing the new Tomcat profile completely that OOZIE-2666 introduces
> would make easier to understand how to build Oozie.
> - Cleaner and simpler packaging (and starting scripts) - we wouldn't need to
> deal with any war repackaging scripts, or special scripts for turning on SSL
> (this what we currently need to do when using Tomcat). Also we could get rid
> of assembly xml for tomcat.
> ??Note: We can still support building a WAR file for users who want to deploy
> Oozie in their own (not embedded) Tomcat or Jetty. So if someone wants to use
> Tomcat, they can deploy a Tomcat server and use the WAR file.??
> h5. Main tasks
> - Remove tomcat profile completely
> - distro: pom and shell scripts
> - src /main / assemblies distro-tomcat.xml
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
