[ https://issues.apache.org/jira/browse/OOZIE-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797117#comment-15797117 ]
Abhishek Bafna commented on OOZIE-2751: --------------------------------------- Thanks [~rkanter] for the feedback. I am not sure test case will help, because some of the methods defined in {{OozieClient}} are very specific to Coordinators which are not overridden into {{LocalOozieClient}} and {{LocalOozieClientBundle}} e.g. {{reRunCoord}}, {{getCoordJobsInfo}} etc. At a higher level if we see then each of these LocalXXX classes implement only a specific set of methods. Though a little more which can be done is overriding these methods into {{BaseLocalOozieClient}} and throwing a Exception as default implementation and their right behavior is overridden into their respective classes. Let me know me your further thoughts on this. > LocalOozieClient is missing methods from OozieClient > ---------------------------------------------------- > > Key: OOZIE-2751 > URL: https://issues.apache.org/jira/browse/OOZIE-2751 > Project: Oozie > Issue Type: Bug > Reporter: Robert Kanter > Assignee: Abhishek Bafna > Fix For: 5.0.0 > > Attachments: OOZIE-2751-00.patch, OOZIE-2751-01.patch, > OOZIE-2751-02.patch, OOZIE-2751-03.patch, OOZIE-2751-04.patch > > > {{LocalOozieClient}} works by wrapping direct calls to {{DagEngine}} in the > normal {{OozieClient}} methods instead of making REST calls to an Oozie > Server. However, it currently doesn't override all methods, which means you > hit the {{OozieClient}} implementation, which tries to make a REST call and > will fail (because it's not setup for that). For example, {{getStatus(String > jobId)}} isn't overridden, and doesn't work when used from > {{LocalOozieClient}}. > We should also create a test that verifies that all methods are overridden. -- This message was sent by Atlassian JIRA (v6.3.4#6332)