> On Jan. 11, 2017, 11:10 a.m., András Piros wrote: > > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java, lines > > 118-131 > > <https://reviews.apache.org/r/55404/diff/1/?file=1602406#file1602406line118> > > > > Should be in `class HCatURIParser`.
Renamed the method iwht more specific name. I think we should keep this into the HCatURI class only as URI is getting pasrsed during the initialization. > On Jan. 11, 2017, 11:10 a.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java, lines > > 325-336 > > <https://reviews.apache.org/r/55404/diff/1/?file=1602402#file1602402line325> > > > > Extract to separate `class HCatURIParser`. Should not be `static`. Moved. Keeping it static as it is used as a helper method and does not have state to hold for parsing. > On Jan. 11, 2017, 11:10 a.m., András Piros wrote: > > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java, lines > > 56-62 > > <https://reviews.apache.org/r/55404/diff/1/?file=1602406#file1602406line56> > > > > Should be in `class HCatURIParser`. Moved. Marked as static method which parse the URI and retrun URI. > On Jan. 11, 2017, 11:10 a.m., András Piros wrote: > > sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java, > > lines 55-57 > > <https://reviews.apache.org/r/55404/diff/1/?file=1602407#file1602407line55> > > > > JUnit 4's `@Rule public ExpectedException expected = > > ExpectedException.none(); expected.expect(HCatAccessorException.class);` > > comes to the rescue. Removed the try-catch. Added the 'Exception' as part of the test method signatore, if any exception occurs then test should fail and should be analyzed and fixed. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55404/#review161205 ----------------------------------------------------------- On Jan. 11, 2017, 5:41 a.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55404/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2017, 5:41 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2701 > https://issues.apache.org/jira/browse/OOZIE-2701 > > > Repository: oozie-git > > > Description > ------- > > Oozie to support Multiple HCatalog URIs > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java 9475f72 > core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 67b37ec > core/src/main/resources/oozie-default.xml 943f9bc > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java e1cf133 > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java 8ec3fae > sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1b1a8fa > > Diff: https://reviews.apache.org/r/55404/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Bafna > >
