> On Jan. 19, 2017, 8:46 p.m., Rohini Palaniswamy wrote: > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java, line 182 > > <https://reviews.apache.org/r/55214/diff/1/?file=1598979#file1598979line182> > > > > missingdeps instead of missingDependencies. Too long and we don't use > > camel case for command line options.
Agree. > On Jan. 19, 2017, 8:46 p.m., Rohini Palaniswamy wrote: > > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java, lines > > 248-249 > > <https://reviews.apache.org/r/55214/diff/1/?file=1598981#file1598981line248> > > > > Indentation does not look right. it's correct. > On Jan. 19, 2017, 8:46 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java, > > lines 325-327 > > <https://reviews.apache.org/r/55214/diff/1/?file=1598989#file1598989line325> > > > > I don't see CoordPushInputDependency implementing this method. How does > > it work for that? For input-logic first missing dependencies is always null ( and it doesn't get displayed in CLI/UI), because it difficult to find first since we don execute expression > On Jan. 19, 2017, 8:46 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java, > > line 66 > > <https://reviews.apache.org/r/55214/diff/1/?file=1598994#file1598994line66> > > > > GET_COORD_ACTION_DEPENDENCIES This is already being used by CoordActionInputCheckXCommand. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55214/#review162319 ----------------------------------------------------------- On Jan. 23, 2017, 9:05 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55214/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2017, 9:05 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2770 > https://issues.apache.org/jira/browse/OOZIE-2770 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2770 Show missing dependencies for coord actions > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 6e30d7eb667fe74440281fab3ca06c9f4df7bcf7 > client/src/main/java/org/apache/oozie/client/OozieClient.java > a107c4a3224dba76a59b9eb7c1903c0022d553a4 > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > d670142f446798f39fbb1cd8c3aed738a0897b18 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 9a3be979e1acf6fce8dc13ccdf985ce47215cf49 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java > 91fe5a1d709ba1a90e493d301030465aa35ca790 > core/src/main/java/org/apache/oozie/ErrorCode.java > 9a843bd0f60ef3b946748adcd45563863c291a60 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 0af7edc9094aaf24a6636ccebea17493e457fcce > > core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java > b8affd67a412fac7d4ec452d7e2efa02c62ce25a > core/src/main/java/org/apache/oozie/coord/CoordUtils.java > 82f9bede0878b361ffb47d865036573b15448c68 > > core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java > 0da60ec70373399414a637c22753da7e2a7e6618 > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java > 504bc3d5f8c48676736cb461462677ddac400d17 > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java > aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java > f20dcae0ff44d745ffbcb22bce2653d042a65122 > core/src/main/java/org/apache/oozie/dependency/ActionDependency.java > fe7a3272190718f21aa594188013fadfa9b58646 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > c0e6c198f4978744016f35dd8940db345a71f92c > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java > 87a2b426ad3f5eeb08e76e1be473fdcdf387d293 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java > 0c4212877f3051ef85ca04bb8d2e075b5f9c4c72 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 95dcca63c459475b8d41a85e0db11ca2a530a2e4 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java > 3a0ffb0181a0feec31d9aceeea2df5aba0681ae9 > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java > 8ec38e498f31bb69923125e34cda5abfc8e72aa9 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java > 6684a1fc7e8d1ed85b9e309cd163ae92f005f281 > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 0e74f2d1df67dd5d4aaccbdb66a3829f5894e751 > core/src/test/resources/coord-multiple-output-instance5.xml > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > docs/src/site/twiki/DG_CommandLineTool.twiki > 2dbbd4c820b9d8e11a51fdfe84185f5a1b3e6707 > docs/src/site/twiki/WebServicesAPI.twiki > 8406da6ab3bec859a9ef2b889e558f6c9ad1d652 > webapp/src/main/webapp/oozie-console.js > 7b20e9196cc6129b53fc610d34f6090311474eae > > Diff: https://reviews.apache.org/r/55214/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
