[ https://issues.apache.org/jira/browse/OOZIE-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839896#comment-15839896 ]
Hadoop QA commented on OOZIE-2777: ---------------------------------- Testing JIRA OOZIE-2777 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:red}-1{color} the patch contains 2 line(s) longer than 132 characters . {color:green}+1{color} the patch does adds/modifies 3 testcase(s) {color:red}-1 RAT{color} . {color:red}-1{color} the patch seems to introduce 1 new RAT warning(s) {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [455] new bugs found below threshold in total that must be fixed. . {color:red}-1{color} There are [98] new bugs found below threshold in [server] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): server/findbugs-new.html . The most important FindBugs errors are: . At CLIParser.java:[line 169]: Found reliance on default encoding in org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new java.io.PrintWriter(OutputStream) . At CLIParser.java:[line 57]: new org.apache.oozie.cli.CLIParser(String, String[]) may expose internal representation by storing an externally mutable object into CLIParser.cliHelp . At CLIParser.java:[lines 80-104]: Should org.apache.oozie.cli.CLIParser$Command be a _static_ inner class? . At OozieCLI.java:[line 835]: Found reliance on default encoding in org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new java.io.FileReader(File) . At OozieCLI.java:[line 2149]: Found reliance on default encoding in org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new java.io.FileReader(File) . Obligation to clean up resource created at OozieCLI.java:[line 838] is not discharged: org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine) may fail to clean up java.io.InputStream . Path continues at OozieCLI.java:[line 848]: Path continues at OozieCLI.java:[line 844] . Obligation to clean up resource created at OozieCLI.java:[line 835] is not discharged: org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine) may fail to clean up java.io.Reader . Path continues at OozieCLI.java:[line 848]: Path continues at OozieCLI.java:[line 844] . At OozieCLI.java:[line 835]: org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine) may fail to close stream . At OozieCLI.java:[line 2152]: Exception is caught when Exception is not thrown in org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine) . At OozieCLI.java:[line 1384]: Format-string method String.format(String, Object[]) called with format string "%-43s%-10s%-37s%-10s%-21s%-21s" wants 6 arguments but is given 7 in org.apache.oozie.cli.OozieCLI.printCoordJob(CoordinatorJob, String, boolean) . At AuthOozieClient.java:[line 218]: Found reliance on default encoding in org.apache.oozie.client.AuthOozieClient.readAuthToken(): new java.io.FileReader(File) . At AuthOozieClient.java:[line 248]: Found reliance on default encoding in org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token): new java.io.FileWriter(File) . At AuthOozieClient.java:[line 285]: Load of known null value in org.apache.oozie.client.AuthOozieClient.getAuthenticator() . At AuthOozieClient.java:[line 326]: Load of known null value in org.apache.oozie.client.AuthOozieClient.getAuthenticator() . Obligation to clean up resource created at AuthOozieClient.java:[line 248] is not discharged: org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token) may fail to clean up java.io.Writer on checked exception . Path continues at AuthOozieClient.java:[line 257]: Path continues at AuthOozieClient.java:[line 249] . Path continues at AuthOozieClient.java:[line 264]: Path continues at AuthOozieClient.java:[line 261] . At AuthOozieClient.java:[line 129]: Exceptional return value of java.io.File.delete() ignored in org.apache.oozie.client.AuthOozieClient.createConnection(URL, String) . Another occurrence at AuthOozieClient.java:[line 159]: Another occurrence at AuthOozieClient.java:[line 143] . Exceptional return value of java.io.File.delete() ignored in org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token): Another occurrence at AuthOozieClient.java:[line 174] . Exceptional return value of java.io.File.setWritable(boolean, boolean) ignored in org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token): At AuthOozieClient.java:[line 261] . Found reliance on default encoding in org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new java.io.InputStreamReader(InputStream): At AuthOozieClient.java:[line 255] . Result of integer multiplication cast to long in org.apache.oozie.client.OozieClient.pollJob(String, int, int, boolean): At OozieClient.java:[line 409] . Inconsistent synchronization of org.apache.oozie.client.OozieClient.protocolUrl; locked 50% of time: At OozieClient.java:[line 2288] . Unsynchronized access at OozieClient.java:[line 484]: Unsynchronized access at OozieClient.java:[line 309] . Synchronized access at OozieClient.java:[line 384]: Unsynchronized access at OozieClient.java:[line 508] . Synchronized access at OozieClient.java:[line 391]: Synchronized access at OozieClient.java:[line 387] . Unsynchronized access at OozieClient.java:[line 339]: Inconsistent synchronization of org.apache.oozie.client.OozieClient.supportedVersions; locked 60% of time . Unsynchronized access at OozieClient.java:[line 340]: Unsynchronized access at OozieClient.java:[line 342] . Synchronized access at OozieClient.java:[line 366]: Unsynchronized access at OozieClient.java:[line 345] . Synchronized access at OozieClient.java:[line 370]: Synchronized access at OozieClient.java:[line 367] . Synchronized access at OozieClient.java:[line 370]: Synchronized access at OozieClient.java:[line 383] . Synchronized access at OozieClient.java:[line 370]: Synchronized access at OozieClient.java:[line 386] . Synchronized access at OozieClient.java:[line 377]: Synchronized access at OozieClient.java:[line 390] . At OozieClient.java:[line 1594]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1403]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1568]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1423]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1621]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1644]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1356]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1541]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1674]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 2069]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 2740]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetInstrumentation.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 2507]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetMetrics.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 2365]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetQueueDump.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 2027]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetSystemMode.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[lines 2762-2900]: Should org.apache.oozie.client.OozieClient$Instrumentation be a _static_ inner class? . At OozieClient.java:[line 2825]: Boxing/unboxing to parse a primitive new org.apache.oozie.client.OozieClient$Instrumentation$Timer(OozieClient$Instrumentation, JSONObject) . Another occurrence at OozieClient.java:[line 2827]: Another occurrence at OozieClient.java:[line 2826] . Another occurrence at OozieClient.java:[line 2830]: Another occurrence at OozieClient.java:[line 2829] . Another occurrence at OozieClient.java:[line 2832]: Another occurrence at OozieClient.java:[line 2831] . At OozieClient.java:[line 999]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$JMSInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1212]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$JMSTopic.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1967]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobIdAction.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 980]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1268]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobMetadata.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 713]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobSubmit.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 768]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobsAction.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1514]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobsStatus.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 2170]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$ListShareLib.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 606]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$MapClientCallable.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 610]: org.apache.oozie.client.OozieClient$MapClientCallable.call(HttpURLConnection) makes inefficient use of keySet iterator instead of entrySet iterator . At OozieClient.java:[lines 2530-2573]: Should org.apache.oozie.client.OozieClient$Metrics be a _static_ inner class? . At OozieClient.java:[line 2655]: Boxing/unboxing to parse a primitive new org.apache.oozie.client.OozieClient$Metrics$Histogram(OozieClient$Metrics, JSONObject) . At OozieClient.java:[line 1944]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$SlaInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 1944]: org.apache.oozie.client.OozieClient$SlaInfo.call(HttpURLConnection) may fail to close stream . At OozieClient.java:[line 2342]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$Status.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 829]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$UpdateCoord.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 2128]: Found reliance on default encoding in org.apache.oozie.client.OozieClient$UpdateSharelib.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) . At OozieClient.java:[line 2135]: org.apache.oozie.client.OozieClient$UpdateSharelib.call(HttpURLConnection) makes inefficient use of keySet iterator instead of entrySet iterator . Found reliance on default encoding in org.apache.oozie.client.OozieClient$ValidateXML.call(HttpURLConnection): new java.io.InputStreamReader(InputStream): Another occurrence at OozieClient.java:[line 2144] . org.apache.oozie.client.OozieClient$ValidateXML.call(HttpURLConnection) may fail to clean up java.io.InputStream: At OozieClient.java:[line 2102] . Path continues at OozieClient.java:[line 2095]: Obligation to clean up resource created at OozieClient.java:[line 2094] is not discharged . Path continues at OozieClient.java:[line 2097]: Path continues at OozieClient.java:[line 2096] . Path continues at OozieClient.java:[line 2106]: Path continues at OozieClient.java:[line 2101] . org.apache.oozie.client.OozieClient$ValidateXML.call(HttpURLConnection) may fail to close stream: Path continues at OozieClient.java:[line 2107] . Found reliance on default encoding in org.apache.oozie.client.OozieClient$WfsForCoordAction.call(HttpURLConnection): new java.io.InputStreamReader(InputStream): At OozieClient.java:[line 2094] . Found reliance on default encoding in org.apache.oozie.client.OozieClient$WorkflowActionInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream): At OozieClient.java:[line 1377] . Found reliance on default encoding in org.apache.oozie.client.OozieClient$WorkflowActionRetriesInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream): At OozieClient.java:[line 1019] . Primitive boxed just to call toString in org.apache.oozie.client.XOozieClient.setStrings(Properties, String, String[]): At OozieClient.java:[line 1040] . Found reliance on default encoding in org.apache.oozie.client.XOozieClient.readScript(String): new java.io.FileReader(String): At XOozieClient.java:[line 118] . org.apache.oozie.client.XOozieClient.setStrings(Properties, String, String[]) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead: At XOozieClient.java:[line 90] . Possible null pointer dereference of br in org.apache.oozie.client.XOozieClient.readScript(String) on exception path: At XOozieClient.java:[line 118] . Null value at XOozieClient.java:[line 88]: Dereferenced at XOozieClient.java:[line 100] . Found reliance on default encoding in org.apache.oozie.client.XOozieClient$HttpJobSubmit.call(HttpURLConnection): new java.io.InputStreamReader(InputStream): Known null at XOozieClient.java:[line 90] . org.apache.oozie.client.event.JobEvent.getEndTime() may expose internal representation by returning JobEvent.endTime: At XOozieClient.java:[line 282] . org.apache.oozie.client.event.JobEvent.getStartTime() may expose internal representation by returning JobEvent.startTime: At JobEvent.java:[line 137] . org.apache.oozie.client.event.JobEvent.setEndTime(Date) may expose internal representation by storing an externally mutable object into JobEvent.endTime: At JobEvent.java:[line 129] . org.apache.oozie.client.event.JobEvent.setStartTime(Date) may expose internal representation by storing an externally mutable object into JobEvent.startTime: At JobEvent.java:[line 141] . org.apache.oozie.client.event.message.CoordinatorActionMessage.getNominalTime() may expose internal representation by returning CoordinatorActionMessage.nominalTime: At JobEvent.java:[line 133] . new org.apache.oozie.client.event.message.CoordinatorActionMessage(JobEvent$EventStatus, String, String, Date, Date, Date, CoordinatorAction$Status, String, String, String, String, String) may expose internal representation by storing an externally mutable object into CoordinatorActionMessage.nominalTime: At CoordinatorActionMessage.java:[line 111] . org.apache.oozie.client.event.message.CoordinatorActionMessage.setNominalTime(Date) may expose internal representation by storing an externally mutable object into CoordinatorActionMessage.nominalTime: At CoordinatorActionMessage.java:[line 75] . org.apache.oozie.client.event.message.JobMessage.getEndTime() may expose internal representation by returning JobMessage.endTime: At CoordinatorActionMessage.java:[line 103] . org.apache.oozie.client.event.message.JobMessage.getStartTime() may expose internal representation by returning JobMessage.startTime: At JobMessage.java:[line 166] . new org.apache.oozie.client.event.message.JobMessage(JobEvent$EventStatus, AppType, String, String, Date, Date, String, String) may expose internal representation by storing an externally mutable object into JobMessage.endTime: At JobMessage.java:[line 148] . new org.apache.oozie.client.event.message.JobMessage(JobEvent$EventStatus, AppType, String, String, Date, Date, String, String) may expose internal representation by storing an externally mutable object into JobMessage.startTime: At JobMessage.java:[line 87] . org.apache.oozie.client.event.message.JobMessage.setEndTime(Date) may expose internal representation by storing an externally mutable object into JobMessage.endTime: At JobMessage.java:[line 84] . org.apache.oozie.client.event.message.JobMessage.setStartTime(Date) may expose internal representation by storing an externally mutable object into JobMessage.startTime: At JobMessage.java:[line 157] . org.apache.oozie.client.event.message.SLAMessage.getActualEndTime() may expose internal representation by returning SLAMessage.actualEndTime: At JobMessage.java:[line 139] . org.apache.oozie.client.event.message.SLAMessage.getActualStartTime() may expose internal representation by returning SLAMessage.actualStartTime: At SLAMessage.java:[line 207] . org.apache.oozie.client.event.message.SLAMessage.getExpectedEndTime() may expose internal representation by returning SLAMessage.expectedEndTime: At SLAMessage.java:[line 171] . org.apache.oozie.client.event.message.SLAMessage.getExpectedStartTime() may expose internal representation by returning SLAMessage.expectedStartTime: At SLAMessage.java:[line 189] . org.apache.oozie.client.event.message.SLAMessage.getNominalTime() may expose internal representation by returning SLAMessage.nominalTime: At SLAMessage.java:[line 153] . new org.apache.oozie.client.event.message.SLAMessage(SLAEvent$EventStatus, SLAEvent$SLAStatus, AppType, String, String, String, String, Date, Date, Date, Date, Date, long, long, String, String) may expose internal representation by storing an externally mutable object into SLAMessage.actualEndTime: At SLAMessage.java:[line 135] . new org.apache.oozie.client.event.message.SLAMessage(SLAEvent$EventStatus, SLAEvent$SLAStatus, AppType, String, String, String, String, Date, Date, Date, Date, Date, long, long, String, String) may expose internal representation by storing an externally mutable object into SLAMessage.actualStartTime: At SLAMessage.java:[line 86] . new org.apache.oozie.client.event.message.SLAMessage(SLAEvent$EventStatus, SLAEvent$SLAStatus, AppType, String, String, String, String, Date, Date, Date, Date, Date, long, long, String, String) may expose internal representation by storing an externally mutable object into SLAMessage.expectedEndTime: At SLAMessage.java:[line 84] . new org.apache.oozie.client.event.message.SLAMessage(SLAEvent$EventStatus, SLAEvent$SLAStatus, AppType, String, String, String, String, Date, Date, Date, Date, Date, long, long, String, String) may expose internal representation by storing an externally mutable object into SLAMessage.expectedStartTime: At SLAMessage.java:[line 85] . new org.apache.oozie.client.event.message.SLAMessage(SLAEvent$EventStatus, SLAEvent$SLAStatus, AppType, String, String, String, String, Date, Date, Date, Date, Date, long, long, String, String) may expose internal representation by storing an externally mutable object into SLAMessage.nominalTime: At SLAMessage.java:[line 83] . org.apache.oozie.client.event.message.SLAMessage.setActualEndTime(Date) may expose internal representation by storing an externally mutable object into SLAMessage.actualEndTime: At SLAMessage.java:[line 82] . org.apache.oozie.client.event.message.SLAMessage.setActualStartTime(Date) may expose internal representation by storing an externally mutable object into SLAMessage.actualStartTime: At SLAMessage.java:[line 216] . org.apache.oozie.client.event.message.SLAMessage.setExpectedEndTime(Date) may expose internal representation by storing an externally mutable object into SLAMessage.expectedEndTime: At SLAMessage.java:[line 180] . org.apache.oozie.client.event.message.SLAMessage.setExpectedStartTime(Date) may expose internal representation by storing an externally mutable object into SLAMessage.expectedStartTime: At SLAMessage.java:[line 198] . org.apache.oozie.client.event.message.SLAMessage.setNominalTime(Date) may expose internal representation by storing an externally mutable object into SLAMessage.nominalTime: At SLAMessage.java:[line 162] . org.apache.oozie.client.rest.JsonToBean$JsonInvocationHandler.parseType(Class, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead: At SLAMessage.java:[line 144] . org.apache.oozie.client.rest.JsonToBean$JsonInvocationHandler.parseType(Class, Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead: At JsonToBean.java:[line 258] . At JsonToBean.java:[line 261] . {color:red}-1{color} There are [338] new bugs found below threshold in [client] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): client/findbugs-new.html . The most important FindBugs errors are: . At BinaryBlob.java:[line 68]: org.apache.oozie.BinaryBlob.getBytes() may expose internal representation by returning BinaryBlob.bytes . org.apache.oozie.BinaryBlob.getRawBlob() may expose internal representation by returning BinaryBlob.rawBlob: Another occurrence at BinaryBlob.java:[line 88] . Another occurrence at BinaryBlob.java:[line 116]: At BinaryBlob.java:[line 99] . At BinaryBlob.java:[line 43]: new org.apache.oozie.BinaryBlob(byte[], boolean) may expose internal representation by storing an externally mutable object into BinaryBlob.bytes . At BinaryBlob.java:[line 47]: new org.apache.oozie.BinaryBlob(byte[], boolean) may expose internal representation by storing an externally mutable object into BinaryBlob.rawBlob . At BinaryBlob.java:[line 57]: org.apache.oozie.BinaryBlob.setBytes(byte[]) may expose internal representation by storing an externally mutable object into BinaryBlob.bytes . In BundleActionBean.java: org.apache.oozie.BundleActionBean.pcIsDetached() has Boolean return type and returns explicit null . In BundleJobBean.java: org.apache.oozie.BundleJobBean.pcIsDetached() has Boolean return type and returns explicit null . In CoordinatorActionBean.java: org.apache.oozie.CoordinatorActionBean.pcIsDetached() has Boolean return type and returns explicit null . At CoordinatorActionBean.java:[lines 494-498]: Switch statement found in org.apache.oozie.CoordinatorActionBean.isTerminalWithFailure() where default case is missing . At CoordinatorEngine.java:[line 104]: org.apache.oozie.CoordinatorEngine.VALID_JOB_FILTERS should be package protected . In CoordinatorJobBean.java: org.apache.oozie.CoordinatorJobBean.pcIsDetached() has Boolean return type and returns explicit null . Dereferenced at DagEngine.java:[line 176]: Possible null pointer dereference of submit in org.apache.oozie.DagEngine.submitHttpJob(Configuration, String) . Known null at DagEngine.java:[line 172]: Null value at DagEngine.java:[line 162] . At StringBlob.java:[line 119]: Found reliance on default encoding in org.apache.oozie.StringBlob.getRawBlob(): String.getBytes() . At StringBlob.java:[line 104]: org.apache.oozie.StringBlob.getRawBlob() may expose internal representation by returning StringBlob.rawBlob . new org.apache.oozie.StringBlob(byte[]) may expose internal representation by storing an externally mutable object into StringBlob.rawBlob: Another occurrence at StringBlob.java:[line 121] . org.apache.oozie.WorkflowActionBean.pcIsDetached() has Boolean return type and returns explicit null: At StringBlob.java:[line 43] . Possible null pointer dereference of status in org.apache.oozie.WorkflowActionBean.setEndData(WorkflowAction$Status, String): In WorkflowActionBean.java . Known null at WorkflowActionBean.java:[line 600]: Dereferenced at WorkflowActionBean.java:[line 601] . At WorkflowActionBean.java:[lines 412-416]: Switch statement found in org.apache.oozie.WorkflowActionBean.isTerminalWithFailure() where default case is missing . In WorkflowJobBean.java: org.apache.oozie.WorkflowJobBean.pcIsDetached() has Boolean return type and returns explicit null . At WorkflowJobBean.java:[line 277]: Useless control flow in org.apache.oozie.WorkflowJobBean.readFields(DataInput) . At ActionExecutor.java:[line 354]: Found reliance on default encoding in org.apache.oozie.action.ActionExecutor.registerError(String, ActionExecutorException$ErrorType, String): java.io.ByteArrayOutputStream.toString() . At ActionExecutor.java:[line 353]: Found reliance on default encoding in org.apache.oozie.action.ActionExecutor.registerError(String, ActionExecutorException$ErrorType, String): new java.io.PrintStream(OutputStream) . At EmailActionExecutor.java:[line 123]: Dead store to ccs in org.apache.oozie.action.email.EmailActionExecutor.validateAndMail(ActionExecutor$Context, Element) . At EmailActionExecutor.java:[line 122]: Dead store to tos in org.apache.oozie.action.email.EmailActionExecutor.validateAndMail(ActionExecutor$Context, Element) . At EmailActionExecutor.java:[line 90]: Unread field: org.apache.oozie.action.email.EmailActionExecutor.LOG . At EmailActionExecutor.java:[lines 344-370]: Should org.apache.oozie.action.email.EmailActionExecutor$URIDataSource be a _static_ inner class? . At CredentialsProvider.java:[lines 97-102]: The method name org.apache.oozie.action.hadoop.CredentialsProvider.Trim(String) doesn't start with a lower case letter . At DistcpActionExecutor.java:[line 81]: org.apache.oozie.action.hadoop.DistcpActionExecutor.getClassNamebyType(String) invokes inefficient new String(String) constructor . At DistcpActionExecutor.java:[lines 95-100]: The method name org.apache.oozie.action.hadoop.DistcpActionExecutor.Trim(String) doesn't start with a lower case letter . At FsActionExecutor.java:[line 233]: Exception is caught when Exception is not thrown in org.apache.oozie.action.hadoop.FsActionExecutor.doOperations(ActionExecutor$Context, Element) . At FsELFunctions.java:[line 46]: Dead store to group in org.apache.oozie.action.hadoop.FsELFunctions.getFileSystem(URI) . At JavaActionExecutor.java:[line 1411]: Dead store to group in org.apache.oozie.action.hadoop.JavaActionExecutor.createJobClient(ActionExecutor$Context, JobConf) . Dereferenced at JavaActionExecutor.java:[line 632]: Possible null pointer dereference of uri in org.apache.oozie.action.hadoop.JavaActionExecutor.addToCache(Configuration, Path, String, boolean) on exception path . Known null at JavaActionExecutor.java:[line 593]: Null value at JavaActionExecutor.java:[line 591] . Redundant null check at JavaActionExecutor.java:[line 1243]: Redundant nullcheck of credPropertiesMap, which is known to be non-null in org.apache.oozie.action.hadoop.JavaActionExecutor.setCredentialPropertyToActionConf(ActionExecutor$Context, WorkflowAction, Configuration) . At JavaActionExecutor.java:[line 631]: Exception is caught when Exception is not thrown in org.apache.oozie.action.hadoop.JavaActionExecutor.addToCache(Configuration, Path, String, boolean) . At JavaActionExecutor.java:[line 1032]: Exception is caught when Exception is not thrown in org.apache.oozie.action.hadoop.JavaActionExecutor.createLauncherConf(FileSystem, ActionExecutor$Context, WorkflowAction, Element, Configuration) . At JavaActionExecutor.java:[line 175]: Write to static field org.apache.oozie.action.hadoop.JavaActionExecutor.maxActionOutputLen from instance method org.apache.oozie.action.hadoop.JavaActionExecutor.initActionType() . At JavaActionExecutor.java:[line 177]: Write to static field org.apache.oozie.action.hadoop.JavaActionExecutor.maxExternalStatsSize from instance method org.apache.oozie.action.hadoop.JavaActionExecutor.initActionType() . Write to static field org.apache.oozie.action.hadoop.JavaActionExecutor.maxFSGlobMax from instance method org.apache.oozie.action.hadoop.JavaActionExecutor.initActionType(): Another occurrence at JavaActionExecutor.java:[line 178] . org.apache.oozie.action.hadoop.JavaActionExecutor.setCredentialPropertyToActionConf(ActionExecutor$Context, WorkflowAction, Configuration) makes inefficient use of keySet iterator instead of entrySet iterator: At JavaActionExecutor.java:[line 180] . org.apache.oozie.action.hadoop.JavaActionExecutor.updateConfForUberMode(Configuration) makes inefficient use of keySet iterator instead of entrySet iterator: At JavaActionExecutor.java:[line 1245] . Another occurrence at JavaActionExecutor.java:[line 370]: At JavaActionExecutor.java:[line 345] . At LauncherMapperHelper.java:[line 69]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMapperHelper.getRecoveryId(Configuration, Path, String): new java.io.InputStreamReader(InputStream) . At LauncherMapperHelper.java:[line 181]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMapperHelper.getTag(String): String.getBytes() . At LauncherMapperHelper.java:[line 292]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMapperHelper$1.run(): new java.io.InputStreamReader(InputStream) . Another occurrence at LauncherMapperHelper.java:[line 306]: Another occurrence at LauncherMapperHelper.java:[line 298] . Another occurrence at LauncherMapperHelper.java:[line 320]: Another occurrence at LauncherMapperHelper.java:[line 314] . At MapReduceActionExecutor.java:[line 214]: Found reliance on default encoding in org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context, WorkflowAction): String.getBytes() . At SqoopActionExecutor.java:[line 173]: Found reliance on default encoding in org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context, WorkflowAction): String.getBytes() . At SqoopActionExecutor.java:[line 186]: Exception is caught when Exception is not thrown in org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context, WorkflowAction) . At SubWorkflowActionExecutor.java:[line 87]: Dead store to group in org.apache.oozie.action.oozie.SubWorkflowActionExecutor.getWorkflowClient(ActionExecutor$Context, String) . At SubWorkflowActionExecutor.java:[line 245]: Exception is caught when Exception is not thrown in org.apache.oozie.action.oozie.SubWorkflowActionExecutor.start(ActionExecutor$Context, WorkflowAction) . At SshActionExecutor.java:[line 289]: Boxing/unboxing to parse a primitive org.apache.oozie.action.ssh.SshActionExecutor.checkIfRunning(String, ActionExecutor$Context, WorkflowAction) . At SshActionExecutor.java:[line 684]: Found reliance on default encoding in org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process, StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream) . Found reliance on default encoding in org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new java.io.FileWriter(String): Another occurrence at SshActionExecutor.java:[line 685] . Another occurrence at SshActionExecutor.java:[line 504]: At SshActionExecutor.java:[line 502] . Dereferenced at SshActionExecutor.java:[line 486]: Possible null pointer dereference of ps in org.apache.oozie.action.ssh.SshActionExecutor.getReturnValue(String) on exception path . Known null at SshActionExecutor.java:[line 478]: Null value at SshActionExecutor.java:[line 476] . At SshActionExecutor.java:[line 296]: Exception is caught when Exception is not thrown in org.apache.oozie.action.ssh.SshActionExecutor.checkIfRunning(String, ActionExecutor$Context, WorkflowAction) . At SshActionExecutor.java:[line 497]: Exceptional return value of java.io.File.mkdirs() ignored in org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts() . At SshActionExecutor.java:[line 99]: Write to static field org.apache.oozie.action.ssh.SshActionExecutor.maxLen from instance method org.apache.oozie.action.ssh.SshActionExecutor.initActionType() . At SshActionExecutor.java:[line 100]: Write to static field org.apache.oozie.action.ssh.SshActionExecutor.allowSshUserAtHost from instance method org.apache.oozie.action.ssh.SshActionExecutor.initActionType() . At JsonSLAEvent.java:[line 203]: org.apache.oozie.client.rest.JsonSLAEvent.getExpectedEnd() may expose internal representation by returning JsonSLAEvent.expectedEnd . At JsonSLAEvent.java:[line 195]: org.apache.oozie.client.rest.JsonSLAEvent.getExpectedStart() may expose internal representation by returning JsonSLAEvent.expectedStart . At JsonSLAEvent.java:[line 211]: org.apache.oozie.client.rest.JsonSLAEvent.getStatusTimestamp() may expose internal representation by returning JsonSLAEvent.statusTimestamp . At JsonSLAEvent.java:[line 207]: org.apache.oozie.client.rest.JsonSLAEvent.setExpectedEnd(Date) may expose internal representation by storing an externally mutable object into JsonSLAEvent.expectedEnd . At JsonSLAEvent.java:[line 199]: org.apache.oozie.client.rest.JsonSLAEvent.setExpectedStart(Date) may expose internal representation by storing an externally mutable object into JsonSLAEvent.expectedStart . At JsonSLAEvent.java:[line 215]: org.apache.oozie.client.rest.JsonSLAEvent.setStatusTimestamp(Date) may expose internal representation by storing an externally mutable object into JsonSLAEvent.statusTimestamp . In JsonSLAEvent.java: org.apache.oozie.client.rest.JsonSLAEvent.pcIsDetached() has Boolean return type and returns explicit null . In StartTransitionXCommand.java: The method name org.apache.oozie.command.StartTransitionXCommand.StartChildren() doesn't start with a lower case letter . In XCommand.java: org.apache.oozie.command.XCommand.eventService should be package protected . At XCommand.java:[line 98]: Write to static field org.apache.oozie.command.XCommand.eventService from instance method new org.apache.oozie.command.XCommand(String, String, int) . At BundleStartXCommand.java:[lines 131-135]: The method name org.apache.oozie.command.bundle.BundleStartXCommand.StartChildren() doesn't start with a lower case letter . At BundleStatusUpdateXCommand.java:[line 110]: Exception is caught when Exception is not thrown in org.apache.oozie.command.bundle.BundleStatusUpdateXCommand.execute() . At BundleSubmitXCommand.java:[line 154]: Dead store to endTime in org.apache.oozie.command.bundle.BundleSubmitXCommand.submit() . At BundleSubmitXCommand.java:[line 322]: Found reliance on default encoding in org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String): new java.io.InputStreamReader(InputStream) . At BundleSubmitXCommand.java:[line 177]: Exception is caught when Exception is not thrown in org.apache.oozie.command.bundle.BundleSubmitXCommand.submit() . At BundleUnpauseXCommand.java:[line 35]: Unread field: org.apache.oozie.command.bundle.BundleUnpauseXCommand.jpaService . At CoordActionNotificationXCommand.java:[line 45]: Unread field: org.apache.oozie.command.coord.CoordActionNotificationXCommand.retries . At CoordCommandUtils.java:[line 76]: org.apache.oozie.command.coord.CoordCommandUtils.ABSOLUTE isn't final but should be . At CoordCommandUtils.java:[line 72]: org.apache.oozie.command.coord.CoordCommandUtils.CURRENT isn't final but should be . At CoordCommandUtils.java:[line 74]: org.apache.oozie.command.coord.CoordCommandUtils.FUTURE isn't final but should be . At CoordCommandUtils.java:[line 73]: org.apache.oozie.command.coord.CoordCommandUtils.LATEST isn't final but should be . At CoordCommandUtils.java:[line 75]: org.apache.oozie.command.coord.CoordCommandUtils.OFFSET isn't final but should be . At CoordCommandUtils.java:[line 77]: org.apache.oozie.command.coord.CoordCommandUtils.UNEXPECTED isn't final but should be . At CoordCommandUtils.java:[line 720]: org.apache.oozie.command.coord.CoordCommandUtils.materializeInputDataEvents(List, SyncCoordAction, Configuration, CoordinatorActionBean, boolean) makes inefficient use of keySet iterator instead of entrySet iterator . At CoordMaterializeTransitionXCommand.java:[line 112]: new org.apache.oozie.command.coord.CoordMaterializeTransitionXCommand(CoordinatorJobBean, int, Date, Date) may expose internal representation by storing an externally mutable object into CoordMaterializeTransitionXCommand.endMatdTime . At CoordMaterializeTransitionXCommand.java:[line 111]: new org.apache.oozie.command.coord.CoordMaterializeTransitionXCommand(CoordinatorJobBean, int, Date, Date) may expose internal representation by storing an externally mutable object into CoordMaterializeTransitionXCommand.startMatdTime . At CoordSLAChangeXCommand.java:[line 64]: org.apache.oozie.command.coord.CoordSLAChangeXCommand.executeSlaCommand() makes inefficient use of keySet iterator instead of entrySet iterator . At CoordSubmitXCommand.java:[line 314]: Dead store to jobConf in org.apache.oozie.command.coord.CoordSubmitXCommand.getDryRun(CoordinatorJobBean) . At CoordSubmitXCommand.java:[line 1193]: Found reliance on default encoding in org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String): new java.io.InputStreamReader(InputStream) . At CoordSubmitXCommand.java:[line 735]: Comparison of String objects using == or != in org.apache.oozie.command.coord.CoordSubmitXCommand.resolveInitial(Configuration, String, CoordinatorJobBean) . Field CoordSubmitXCommand.dryrun masks field in superclass org.apache.oozie.command.XCommand: Another occurrence at CoordSubmitXCommand.java:[line 788] . org.apache.oozie.command.coord.CoordSubmitXCommand.resolveTagContents(String, Element, ELEvaluator) concatenates strings using + in a loop: In CoordSubmitXCommand.java . Unread field: org.apache.oozie.command.coord.CoordSubmitXCommand.COORD_INPUT_EVENTS; should this field be static?: At CoordSubmitXCommand.java:[line 1037] . Unread field: org.apache.oozie.command.coord.CoordSubmitXCommand.COORD_INPUT_EVENTS_DATA_IN; should this field be static?: At CoordSubmitXCommand.java:[line 111] . Unread field: org.apache.oozie.command.coord.CoordSubmitXCommand.COORD_OUTPUT_EVENTS; should this field be static?: At CoordSubmitXCommand.java:[line 113] . Unread field: org.apache.oozie.command.coord.CoordSubmitXCommand.COORD_OUTPUT_EVENTS_DATA_OUT; should this field be static?: At CoordSubmitXCommand.java:[line 112] . Found reliance on default encoding in org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, String): java.io.ByteArrayOutputStream.toString(): At CoordSubmitXCommand.java:[line 114] . Found reliance on default encoding in org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String, String): String.getBytes(): At CoordUpdateXCommand.java:[line 203] . Another occurrence at CoordUpdateXCommand.java:[line 199]: At CoordUpdateXCommand.java:[line 198] . At SLAJobEventXCommand.java:[line 41]: Unread field: org.apache.oozie.command.sla.SLAJobEventXCommand.jpaService . At SLAJobHistoryXCommand.java:[line 106]: Nullcheck of sla at line 106 of value previously dereferenced in org.apache.oozie.command.sla.SLAJobHistoryXCommand.updateSLASummary(String, Date, Date, String) . Switch statement found in org.apache.oozie.command.wf.ActionCheckXCommand.execute() where default case is missing: Redundant null check at SLAJobHistoryXCommand.java:[line 110] . Load of known null value in org.apache.oozie.command.wf.ActionXCommand$ForkedActionExecutorContext.setVar(String, String): At ActionCheckXCommand.java:[lines 210-226] . Dead store to oldVars in org.apache.oozie.command.wf.ReRunXCommand.copyActionData(WorkflowInstance, WorkflowInstance): At ActionXCommand.java:[line 566] . org.apache.oozie.command.wf.ReRunXCommand.copyActionData(WorkflowInstance, WorkflowInstance) makes inefficient use of keySet iterator instead of entrySet iterator: At ReRunXCommand.java:[line 378] . Exception is caught when Exception is not thrown in org.apache.oozie.command.wf.SignalXCommand.startForkedActions(List): At ReRunXCommand.java:[line 384] . org.apache.oozie.command.wf.SignalXCommand.startForkedActions(List) makes inefficient use of keySet iterator instead of entrySet iterator: At SignalXCommand.java:[line 521] . Public static org.apache.oozie.compression.CodecFactory.getHeaderBytes() may expose internal representation by returning CodecFactory.headerBytes: At SignalXCommand.java:[line 494] . org.apache.oozie.compression.CodecFactory.getDeCompressionCodec(DataInputStream) ignores result of java.io.DataInputStream.read(byte[], int, int): At CodecFactory.java:[line 170] . org.apache.oozie.coord.CoordELEvaluator.createELEvaluatorForDataEcho(Configuration, String, HashMap) makes inefficient use of keySet iterator instead of entrySet iterator: At CodecFactory.java:[line 135] . Redundant nullcheck of replace, which is known to be non-null in org.apache.oozie.coord.CoordELFunctions.checkIfResolved(String, String): At CoordELEvaluator.java:[line 88] . Private method org.apache.oozie.coord.CoordELFunctions.getDSEndOfFlag() is never called: Redundant null check at CoordELFunctions.java:[line 1251] . org.apache.oozie.coord.SyncCoordAction.getActualTime() may expose internal representation by returning SyncCoordAction.actualTime: At CoordELFunctions.java:[lines 1548-1549] . org.apache.oozie.coord.SyncCoordAction.getNominalTime() may expose internal representation by returning SyncCoordAction.nominalTime: At SyncCoordAction.java:[line 100] . org.apache.oozie.coord.SyncCoordAction.setActualTime(Date) may expose internal representation by storing an externally mutable object into SyncCoordAction.actualTime: At SyncCoordAction.java:[line 86] . org.apache.oozie.coord.SyncCoordAction.setNominalTime(Date) may expose internal representation by storing an externally mutable object into SyncCoordAction.nominalTime: At SyncCoordAction.java:[line 107] . org.apache.oozie.coord.SyncCoordDataset.getInitInstance() may expose internal representation by returning SyncCoordDataset.initInstance: At SyncCoordAction.java:[line 93] . org.apache.oozie.coord.SyncCoordDataset.setInitInstance(Date) may expose internal representation by storing an externally mutable object into SyncCoordDataset.initInstance: At SyncCoordDataset.java:[line 117] . Non serializable org.apache.oozie.coord.input.dependency.CoordUnResolvedInputDependency written to ObjectOutput in org.apache.oozie.coord.input.dependency.CoordPullInputDependency.writeObject(ObjectOutputStream): At SyncCoordDataset.java:[line 121] . Unread field: org.apache.oozie.coord.input.logic.CoordInputLogicBuilder.bf: At CoordPullInputDependency.java:[line 97] . Unread public/protected field: org.apache.oozie.coord.input.logic.CoordInputLogicBuilder.dependencyBuilder: At CoordInputLogicBuilder.java:[line 27] . Exception is caught when Exception is not thrown in org.apache.oozie.coord.input.logic.CoordInputLogicEvaluatorPhaseOne.combine(AbstractCoordInputDependency, String[], int, int): At CoordInputLogicBuilder.java:[line 36] . new org.apache.oozie.coord.input.logic.CoordInputLogicEvaluatorPhaseTwo(CoordinatorActionBean, Date) may expose internal representation by storing an externally mutable object into CoordInputLogicEvaluatorPhaseTwo.actualTime: At CoordInputLogicEvaluatorPhaseOne.java:[line 211] . Unread public/protected field: org.apache.oozie.coord.input.logic.CoordInputLogicEvaluatorPhaseValidate.coordJob: At CoordInputLogicEvaluatorPhaseTwo.java:[line 47] . Unused public or protected field: org.apache.oozie.coord.input.logic.CoordInputLogicEvaluatorPhaseValidate.dependencyMap: At CoordInputLogicEvaluatorPhaseValidate.java:[line 38] . Should org.apache.oozie.coord.input.logic.CoordInputLogicEvaluatorUtil$OozieJexlParser be a _static_ inner class?: In CoordInputLogicEvaluatorPhaseValidate.java . Possible null pointer dereference of client in org.apache.oozie.dependency.HCatURIHandler.delete(URI, Configuration, String) on exception path: At CoordInputLogicEvaluatorUtil.java:[lines 210-227] . Known null at HCatURIHandler.java:[line 191]: Dereferenced at HCatURIHandler.java:[line 204] . At HCatURIHandler.java:[lines 365-375]: Should org.apache.oozie.dependency.HCatURIHandler$HCatClientWithToken be a _static_ inner class? . At EhcacheHCatDependencyCache.java:[line 153]: Synchronization performed on java.util.concurrent.ConcurrentMap in org.apache.oozie.dependency.hcat.EhcacheHCatDependencyCache.addMissingDependency(HCatURI, String) . At EhcacheHCatDependencyCache.java:[line 399]: Synchronization performed on java.util.concurrent.ConcurrentMap in org.apache.oozie.dependency.hcat.EhcacheHCatDependencyCache.decrementPartKeyPatternCount(String, String, String) . At EhcacheHCatDependencyCache.java:[line 239]: Synchronization performed on java.util.concurrent.ConcurrentMap in org.apache.oozie.dependency.hcat.EhcacheHCatDependencyCache.markDependencyAvailable(String, String, String, Map) . At EhcacheHCatDependencyCache.java:[line 55]: org.apache.oozie.dependency.hcat.EhcacheHCatDependencyCache.CONF_CACHE_NAME isn't final but should be . At SimpleHCatDependencyCache.java:[line 104]: Synchronization performed on java.util.concurrent.ConcurrentMap in org.apache.oozie.dependency.hcat.SimpleHCatDependencyCache.addMissingDependency(HCatURI, String) . At SimpleHCatDependencyCache.java:[line 96]: Synchronization performed on java.util.concurrent.ConcurrentMap in org.apache.oozie.dependency.hcat.SimpleHCatDependencyCache.addMissingDependency(HCatURI, String) . At SimpleHCatDependencyCache.java:[line 134]: Synchronization performed on java.util.concurrent.ConcurrentMap in org.apache.oozie.dependency.hcat.SimpleHCatDependencyCache.removeMissingDependency(HCatURI, String) . At SimpleHCatDependencyCache.java:[line 380]: Synchronization performed on java.util.concurrent.ConcurrentMap in org.apache.oozie.dependency.hcat.SimpleHCatDependencyCache.removeNonWaitingCoordActions(Set) . Dereferenced at SimpleHCatDependencyCache.java:[line 139]: Possible null pointer dereference of partKeys in org.apache.oozie.dependency.hcat.SimpleHCatDependencyCache.removeMissingDependency(HCatURI, String) . Possible null pointer dereference of waitingActions in org.apache.oozie.dependency.hcat.SimpleHCatDependencyCache.removePartitions(String, Collection, Map): Known null at SimpleHCatDependencyCache.java:[line 136] . Known null at SimpleHCatDependencyCache.java:[line 346]: Dereferenced at SimpleHCatDependencyCache.java:[line 364] . At SimpleHCatDependencyCache.java:[line 390]: org.apache.oozie.dependency.hcat.SimpleHCatDependencyCache.removeNonWaitingCoordActions(Set) makes inefficient use of keySet iterator instead of entrySet iterator . At SimpleHCatDependencyCache.java:[line 345]: org.apache.oozie.dependency.hcat.SimpleHCatDependencyCache.removePartitions(String, Collection, Map) makes inefficient use of keySet iterator instead of entrySet iterator . At WaitingAction.java:[line 64]: Equals method for org.apache.oozie.dependency.hcat.WaitingAction assumes the argument is of type WaitingAction . At BundleJobEvent.java:[lines 55-69]: Switch statement found in org.apache.oozie.event.BundleJobEvent.setStatus(Job$Status) where default case is missing . At CoordinatorActionEvent.java:[line 89]: org.apache.oozie.event.CoordinatorActionEvent.getNominalTime() may expose internal representation by returning CoordinatorActionEvent.nominalTime . At CoordinatorActionEvent.java:[line 93]: org.apache.oozie.event.CoordinatorActionEvent.setNominalTime(Date) may expose internal representation by storing an externally mutable object into CoordinatorActionEvent.nominalTime . At CoordinatorActionEvent.java:[lines 66-84]: Switch statement found in org.apache.oozie.event.CoordinatorActionEvent.setStatus(CoordinatorAction$Status) where default case is missing . At CoordinatorJobEvent.java:[lines 55-70]: Switch statement found in org.apache.oozie.event.CoordinatorJobEvent.setStatus(Job$Status) where default case is missing . At MemoryEventQueue.java:[line 47]: Write to static field org.apache.oozie.event.MemoryEventQueue.eventQueue from instance method org.apache.oozie.event.MemoryEventQueue.init(Configuration) . At MemoryEventQueue.java:[line 51]: Write to static field org.apache.oozie.event.MemoryEventQueue.LOG from instance method org.apache.oozie.event.MemoryEventQueue.init(Configuration) . At MemoryEventQueue.java:[line 50]: Write to static field org.apache.oozie.event.MemoryEventQueue.batchSize from instance method org.apache.oozie.event.MemoryEventQueue.init(Configuration) . At MemoryEventQueue.java:[line 49]: Write to static field org.apache.oozie.event.MemoryEventQueue.currentSize from instance method org.apache.oozie.event.MemoryEventQueue.init(Configuration) . At MemoryEventQueue.java:[line 48]: Write to static field org.apache.oozie.event.MemoryEventQueue.maxSize from instance method org.apache.oozie.event.MemoryEventQueue.init(Configuration) . At WorkflowActionEvent.java:[lines 58-72]: Switch statement found in org.apache.oozie.event.WorkflowActionEvent.setStatus(WorkflowAction$Status) where default case is missing . At WorkflowJobEvent.java:[lines 79-91]: Switch statement found in org.apache.oozie.event.WorkflowJobEvent.setStatus(WorkflowJob$Status) where default case is missing . At ZKConnectionListener.java:[line 62]: org.apache.oozie.event.listener.ZKConnectionListener.stateChanged(CuratorFramework, ConnectionState) invokes System.exit(...), which shuts down the entire virtual machine . At ZKConnectionListener.java:[line 43]: Write to static field org.apache.oozie.event.listener.ZKConnectionListener.connectionState from instance method org.apache.oozie.event.listener.ZKConnectionListener.stateChanged(CuratorFramework, ConnectionState) . Dereferenced at BulkJPAExecutor.java:[line 126]: Possible null pointer dereference of whereClause in org.apache.oozie.executor.jpa.BulkJPAExecutor.bundleQuery(EntityManager) . Known null at BulkJPAExecutor.java:[line 121]: Null value at BulkJPAExecutor.java:[line 114] . At BundleJobsGetNeedStartJPAExecutor.java:[line 39]: new org.apache.oozie.executor.jpa.BundleJobsGetNeedStartJPAExecutor(Date) may expose internal representation by storing an externally mutable object into BundleJobsGetNeedStartJPAExecutor.date . At CoordActionsCountForJobIdJPAExecutor.java:[line 79]: org.apache.oozie.executor.jpa.CoordActionsCountForJobIdJPAExecutor.setQueryParameters(Query, EntityManager) makes inefficient use of keySet iterator instead of entrySet iterator . At CoordJobGetActionForNominalTimeJPAExecutor.java:[line 44]: new org.apache.oozie.executor.jpa.CoordJobGetActionForNominalTimeJPAExecutor(String, Date) may expose internal representation by storing an externally mutable object into CoordJobGetActionForNominalTimeJPAExecutor.nominalTime . At CoordJobGetActionsSubsetJPAExecutor.java:[line 115]: org.apache.oozie.executor.jpa.CoordJobGetActionsSubsetJPAExecutor.setQueryParameters(Query, EntityManager) makes inefficient use of keySet iterator instead of entrySet iterator . At CoordJobsToBeMaterializedJPAExecutor.java:[line 82]: org.apache.oozie.executor.jpa.CoordJobsToBeMaterializedJPAExecutor.getDateInput() may expose internal representation by returning CoordJobsToBeMaterializedJPAExecutor.dateInput . At CoordJobsToBeMaterializedJPAExecutor.java:[line 47]: new org.apache.oozie.executor.jpa.CoordJobsToBeMaterializedJPAExecutor(Date, int) may expose internal representation by storing an externally mutable object into CoordJobsToBeMaterializedJPAExecutor.dateInput . At CoordJobsToBeMaterializedJPAExecutor.java:[line 89]: org.apache.oozie.executor.jpa.CoordJobsToBeMaterializedJPAExecutor.setDateInput(Date) may expose internal representation by storing an externally mutable object into CoordJobsToBeMaterializedJPAExecutor.dateInput . At QueryExecutor.java:[line 58]: Unwritten field: org.apache.oozie.executor.jpa.QueryExecutor.LOG . At SLAEventsGetForFilterJPAExecutor.java:[line 48]: new org.apache.oozie.executor.jpa.SLAEventsGetForFilterJPAExecutor(long, int, Map, long[]) may expose internal representation by storing an externally mutable object into SLAEventsGetForFilterJPAExecutor.lastSeqId . In SLAEventsGetForFilterJPAExecutor.java: Unused field: org.apache.oozie.executor.jpa.SLAEventsGetForFilterJPAExecutor.sb . At SLAEventsGetForSeqIdJPAExecutor.java:[line 40]: new org.apache.oozie.executor.jpa.SLAEventsGetForSeqIdJPAExecutor(long, int, long[]) may expose internal representation by storing an externally mutable object into SLAEventsGetForSeqIdJPAExecutor.lastSeqId . At SLASummaryQueryExecutor.java:[lines 122-126]: Switch statement found in org.apache.oozie.executor.jpa.SLASummaryQueryExecutor.getSelectQuery(SLASummaryQueryExecutor$SLASummaryQuery, EntityManager, Object[]) where default case is missing . At WorkflowActionSubsetGetJPAExecutor.java:[line 64]: Dead store to actionList in org.apache.oozie.executor.jpa.WorkflowActionSubsetGetJPAExecutor.execute(EntityManager) . At SLASummaryGetForFilterJPAExecutor.java:[line 310]: org.apache.oozie.executor.jpa.sla.SLASummaryGetForFilterJPAExecutor$SLASummaryFilter.getNominalEnd() may expose internal representation by returning SLASummaryGetForFilterJPAExecutor$SLASummaryFilter.nominalEnd . At SLASummaryGetForFilterJPAExecutor.java:[line 302]: org.apache.oozie.executor.jpa.sla.SLASummaryGetForFilterJPAExecutor$SLASummaryFilter.getNominalStart() may expose internal representation by returning SLASummaryGetForFilterJPAExecutor$SLASummaryFilter.nominalStart . At SLASummaryGetForFilterJPAExecutor.java:[line 314]: org.apache.oozie.executor.jpa.sla.SLASummaryGetForFilterJPAExecutor$SLASummaryFilter.setNominalEnd(Date) may expose internal representation by storing an externally mutable object into SLASummaryGetForFilterJPAExecutor$SLASummaryFilter.nominalEnd . At SLASummaryGetForFilterJPAExecutor.java:[line 306]: org.apache.oozie.executor.jpa.sla.SLASummaryGetForFilterJPAExecutor$SLASummaryFilter.setNominalStart(Date) may expose internal representation by storing an externally mutable object into SLASummaryGetForFilterJPAExecutor$SLASummaryFilter.nominalStart . At SLASummaryGetRecordsOnRestartJPAExecutor.java:[line 53]: Result of integer multiplication cast to long in org.apache.oozie.executor.jpa.sla.SLASummaryGetRecordsOnRestartJPAExecutor.execute(EntityManager) . At JMSJobEventListener.java:[line 68]: Write to static field org.apache.oozie.jms.JMSJobEventListener.LOG from instance method org.apache.oozie.jms.JMSJobEventListener.init(Configuration) . At JMSSLAEventListener.java:[line 54]: Write to static field org.apache.oozie.jms.JMSSLAEventListener.LOG from instance method org.apache.oozie.jms.JMSSLAEventListener.init(Configuration) . At MemoryLocks.java:[line 109]: Synchronization performed on java.util.concurrent.ConcurrentMap in org.apache.oozie.lock.MemoryLocks.getLock(String, MemoryLocksService$Type, long) . At MemoryLocks.java:[lines 43-62]: Should org.apache.oozie.lock.MemoryLocks$MemoryLockToken be a _static_ inner class? . At AbandonedCoordCheckerService.java:[line 177]: Write to static field org.apache.oozie.service.AbandonedCoordCheckerService.serverURL from instance method org.apache.oozie.service.AbandonedCoordCheckerService.init(Services) . At AbandonedCoordCheckerService.java:[line 174]: Write to static field org.apache.oozie.service.AbandonedCoordCheckerService.to from instance method org.apache.oozie.service.AbandonedCoordCheckerService.init(Services) . At AbandonedCoordCheckerService.java:[line 96]: Result of integer multiplication cast to long in org.apache.oozie.service.AbandonedCoordCheckerService$AbandonedCoordCheckerRunnable.checkCoordJobs() . At AuthorizationService.java:[line 172]: Found reliance on default encoding in org.apache.oozie.service.AuthorizationService.loadAdminUsers(): new java.io.InputStreamReader(InputStream) . At AuthorizationService.java:[line 172]: org.apache.oozie.service.AuthorizationService.loadAdminUsers() may fail to close stream . At CallableQueueService.java:[line 355]: org.apache.oozie.service.CallableQueueService$CompositeCallable.toString() may return null . Obligation to clean up resource created at ConfigurationService.java:[line 239] is not discharged: org.apache.oozie.service.ConfigurationService.loadConf() may fail to clean up java.io.InputStream . Path continues at ConfigurationService.java:[line 241]: Path continues at ConfigurationService.java:[line 240] . Path continues at ConfigurationService.java:[line 247]: Path continues at ConfigurationService.java:[line 242] . Path continues at ConfigurationService.java:[line 264]: Path continues at ConfigurationService.java:[line 249] . Path continues at ConfigurationService.java:[line 269]: Path continues at ConfigurationService.java:[line 265] . Path continues at ConfigurationService.java:[line 288]: Path continues at ConfigurationService.java:[line 276] . Write to static field org.apache.oozie.service.ConfigurationService.log from instance method new org.apache.oozie.service.ConfigurationService(): Path continues at ConfigurationService.java:[line 296] . Should org.apache.oozie.service.ConfigurationService$LogChangesConfiguration be a _static_ inner class?: At ConfigurationService.java:[line 143] . Field only ever set to null: org.apache.oozie.service.CoordMaterializeTriggerService$CoordMaterializeTriggerRunnable.delayedCallables: At ConfigurationService.java:[lines 315-420] . Write to static field org.apache.oozie.service.EventHandlerService.eventsEnabled from instance method org.apache.oozie.service.EventHandlerService.destroy(): At CoordMaterializeTriggerService.java:[line 104] . Write to static field org.apache.oozie.service.EventHandlerService.eventQueue from instance method org.apache.oozie.service.EventHandlerService.init(Services): At EventHandlerService.java:[line 172] . Write to static field org.apache.oozie.service.EventHandlerService.eventsEnabled from instance method org.apache.oozie.service.EventHandlerService.init(Services): At EventHandlerService.java:[line 78] . Write to static field org.apache.oozie.service.HCatAccessorService.LOG from instance method org.apache.oozie.service.HCatAccessorService.init(Services): At EventHandlerService.java:[line 86] . org.apache.oozie.service.HadoopAccessorService.readActionConfFile(File) may fail to clean up java.io.InputStream: At HCatAccessorService.java:[line 74] . Path continues at HadoopAccessorService.java:[line 427]: Obligation to clean up resource created at HadoopAccessorService.java:[line 426] is not discharged . Path continues at HadoopAccessorService.java:[line 432]: Path continues at HadoopAccessorService.java:[line 428] . Path continues at HadoopAccessorService.java:[line 434]: Path continues at HadoopAccessorService.java:[line 433] . org.apache.oozie.service.InstrumentationService.instrumentation should be package protected: Path continues at HadoopAccessorService.java:[line 440] . Write to static field org.apache.oozie.service.InstrumentationService.instrumentation from instance method org.apache.oozie.service.InstrumentationService.destroy(): At InstrumentationService.java:[line 42] . Write to static field org.apache.oozie.service.InstrumentationService.isEnabled from instance method org.apache.oozie.service.InstrumentationService.destroy(): At InstrumentationService.java:[line 122] . Write to static field org.apache.oozie.service.InstrumentationService.instrumentation from instance method org.apache.oozie.service.InstrumentationService.init(Services): At InstrumentationService.java:[line 121] . Write to static field org.apache.oozie.service.InstrumentationService.isEnabled from instance method org.apache.oozie.service.InstrumentationService.init(Services): At InstrumentationService.java:[line 74] . Inconsistent synchronization of org.apache.oozie.service.JMSAccessorService.jmsProducerConnContext; locked 42% of time: At InstrumentationService.java:[line 75] . Unsynchronized access at JMSAccessorService.java:[line 332]: Unsynchronized access at JMSAccessorService.java:[line 331] . Unsynchronized access at JMSAccessorService.java:[line 278]: Unsynchronized access at JMSAccessorService.java:[line 278] . Unsynchronized access at JMSAccessorService.java:[line 298]: Unsynchronized access at JMSAccessorService.java:[line 279] . Synchronized access at JMSAccessorService.java:[line 283]: Synchronized access at JMSAccessorService.java:[line 283] . Synchronized access at JMSAccessorService.java:[line 286]: Synchronized access at JMSAccessorService.java:[line 285] . Synchronized access at JMSAccessorService.java:[line 287]: Synchronized access at JMSAccessorService.java:[line 287] . At JMSAccessorService.java:[line 85]: Write to static field org.apache.oozie.service.JMSAccessorService.LOG from instance method org.apache.oozie.service.JMSAccessorService.init(Services) . At JMSTopicService.java:[line 99]: Write to static field org.apache.oozie.service.JMSTopicService.LOG from instance method org.apache.oozie.service.JMSTopicService.init(Services) . At JPAService.java:[line 141]: Write to static field org.apache.oozie.service.JPAService.LOG from instance method org.apache.oozie.service.JPAService.init(Services) . At JobsConcurrencyService.java:[line 47]: Write to static field org.apache.oozie.service.JobsConcurrencyService.urls from instance method org.apache.oozie.service.JobsConcurrencyService.init(Services) . At MetricsInstrumentationService.java:[line 54]: Write to static field org.apache.oozie.service.MetricsInstrumentationService.isEnabled from instance method org.apache.oozie.service.MetricsInstrumentationService.destroy() . At MetricsInstrumentationService.java:[line 45]: Write to static field org.apache.oozie.service.InstrumentationService.instrumentation from instance method org.apache.oozie.service.MetricsInstrumentationService.init(Services) . At MetricsInstrumentationService.java:[line 46]: Write to static field org.apache.oozie.service.MetricsInstrumentationService.isEnabled from instance method org.apache.oozie.service.MetricsInstrumentationService.init(Services) . At PartitionDependencyManagerService.java:[line 96]: Unread field: org.apache.oozie.service.PartitionDependencyManagerService$CachePurgeWorker.cache . Dereferenced at RecoveryService.java:[line 213]: Possible null pointer dereference of bundleJob in org.apache.oozie.service.RecoveryService$RecoveryRunnable.runBundleRecovery() . Known null at RecoveryService.java:[line 209]: Null value at RecoveryService.java:[line 208] . At Service.java:[line 56]: Initialization of org.apache.oozie.service.Service accesses class org.apache.oozie.service.ConfigurationService, which isn't initialized yet . At Services.java:[lines 105-109]: Incorrect lazy initialization of static field org.apache.oozie.service.Services.SERVICES in new org.apache.oozie.service.Services() . At Services.java:[line 132]: Exceptional return value of java.io.File.delete() ignored in org.apache.oozie.service.Services.createRuntimeDir() . At Services.java:[line 109]: Write to static field org.apache.oozie.service.Services.SERVICES from instance method new org.apache.oozie.service.Services() . At Services.java:[line 349]: Write to static field org.apache.oozie.service.Services.SERVICES from instance method org.apache.oozie.service.Services.destroy() . At Services.java:[line 211]: Write to static field org.apache.oozie.service.Services.SERVICES from instance method org.apache.oozie.service.Services.init() . org.apache.oozie.service.Services.getSystemMode() is unsynchronized, org.apache.oozie.service.Services.setSystemMode(OozieClient$SYSTEM_MODE) is synchronized: Another occurrence at Services.java:[line 221] . Result of integer multiplication cast to long in new org.apache.oozie.service.ShareLibService(): At Services.java:[line 155] . Result of integer multiplication cast to long in org.apache.oozie.service.ShareLibService.init(Services): At ShareLibService.java:[line 113] . org.apache.oozie.service.ShareLibService.SHARE_LIB_CONF_PREFIX isn't final but should be: At ShareLibService.java:[line 162] . Call to method of static java.text.DateFormat in org.apache.oozie.service.ShareLibService.getLatestLibPath(Path, String): At ShareLibService.java:[line 103] . Call to method of static java.text.DateFormat in org.apache.oozie.service.ShareLibService.getLauncherlibPath(): At ShareLibService.java:[line 692] . org.apache.oozie.service.ShareLibService.dateFormat is a static field of type java.text.DateFormat, which isn't thread safe: At ShareLibService.java:[line 662] . Call to method of static java.text.DateFormat in org.apache.oozie.service.ShareLibService$2.accept(Path): In ShareLibService.java . Found reliance on default encoding in org.apache.oozie.service.SparkConfigurationService.loadSparkConfigs(): new java.io.FileReader(File): At ShareLibService.java:[line 479] . org.apache.oozie.service.StatusTransitService.lastInstanceStartTime should be package protected: At SparkConfigurationService.java:[line 85] . org.apache.oozie.service.StatusTransitService.limit isn't final but should be: At StatusTransitService.java:[line 59] . org.apache.oozie.service.URIHandlerService.getAuthorityWithScheme(String) invokes substring(0), which returns the original value: At StatusTransitService.java:[line 58] . Found reliance on default encoding in org.apache.oozie.service.WorkflowAppService.readDefinition(String, String, Configuration): new java.io.InputStreamReader(InputStream): At URIHandlerService.java:[line 210] . Should org.apache.oozie.service.WorkflowAppService$NoPathFilter be a _static_ inner class?: At WorkflowAppService.java:[line 133] . org.apache.oozie.service.XLogService.init(Services) may fail to clean up java.io.InputStream: At WorkflowAppService.java:[lines 320-323] . Path continues at XLogService.java:[line 203]: Obligation to clean up resource created at XLogService.java:[line 202] is not discharged . Path continues at XLogService.java:[line 208]: Path continues at XLogService.java:[line 207] . At XLogUtil.java:[line 34]: org.apache.oozie.service.XLogUtil.log isn't final but should be . At ZKJobsConcurrencyService.java:[line 73]: Write to static field org.apache.oozie.service.ZKJobsConcurrencyService.leaderLatch from instance method org.apache.oozie.service.ZKJobsConcurrencyService.init(Services) . At ZKLocksService.java:[lines 174-201]: Should org.apache.oozie.service.ZKLocksService$ZKLockToken be a _static_ inner class? . At ZKXLogStreamingService.java:[line 208]: Dead store to xLogService in org.apache.oozie.service.ZKXLogStreamingService.collateLogs(XLogFilter, Date, Date, Writer, Map, String, String, int, String) . At BaseAdminServlet.java:[line 194]: org.apache.oozie.servlet.BaseAdminServlet.getShareLib(String) makes inefficient use of keySet iterator instead of entrySet iterator . At BaseJobServlet.java:[line 239]: Load of known null value in org.apache.oozie.servlet.BaseJobServlet.checkAuthorizationForApp(Configuration) . Redundant null check at CallbackServlet.java:[line 76]: Redundant nullcheck of actionId, which is known to be non-null in org.apache.oozie.servlet.CallbackServlet.doGet(HttpServletRequest, HttpServletResponse) . Redundant null check at CallbackServlet.java:[line 107]: Redundant nullcheck of actionId, which is known to be non-null in org.apache.oozie.servlet.CallbackServlet.doPost(HttpServletRequest, HttpServletResponse) . In CallbackServlet.java: Class org.apache.oozie.servlet.CallbackServlet defines non-transient non-serializable instance field log . At CallbackServlet.java:[line 60]: Write to static field org.apache.oozie.servlet.CallbackServlet.maxDataLen from instance method org.apache.oozie.servlet.CallbackServlet.init() . In JVMInfo.java: Class org.apache.oozie.servlet.JVMInfo defines non-transient non-serializable instance field jThreadInfos . In JVMInfo.java: Class org.apache.oozie.servlet.JVMInfo defines non-transient non-serializable instance field classLoadingMXBean . In JVMInfo.java: Class org.apache.oozie.servlet.JVMInfo defines non-transient non-serializable instance field memoryMXBean . In JVMInfo.java: Class org.apache.oozie.servlet.JVMInfo defines non-transient non-serializable instance field threadMXBean . At JVMInfo.java:[lines 224-271]: org.apache.oozie.servlet.JVMInfo$ThreadComparator implements Comparator but not Serializable . At SLAServlet.java:[line 80]: Dead store to eResponse in org.apache.oozie.servlet.SLAServlet.doGet(HttpServletRequest, HttpServletResponse) . At ServicesLoader.java:[line 59]: org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServletContextEvent) invokes System.exit(...), which shuts down the entire virtual machine . At ServicesLoader.java:[line 45]: Write to static field org.apache.oozie.servlet.ServicesLoader.services from instance method org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServletContextEvent) . At ServicesLoader.java:[line 42]: Write to static field org.apache.oozie.servlet.ServicesLoader.sslEnabled from instance method org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServletContextEvent) . At ServletUtilities.java:[lines 36-46]: The method name org.apache.oozie.servlet.ServletUtilities.ValidateAppPath(String, String) doesn't start with a lower case letter . At ServletUtilities.java:[lines 59-80]: The method name org.apache.oozie.servlet.ServletUtilities.ValidateAppPath(String, String, String) doesn't start with a lower case letter . At ServletUtilities.java:[lines 89-92]: The method name org.apache.oozie.servlet.ServletUtilities.ValidateLibPath(String) doesn't start with a lower case letter . At V1JobServlet.java:[line 625]: Dead store to json in org.apache.oozie.servlet.V1JobServlet.rerunBundleJob(HttpServletRequest, HttpServletResponse, Configuration) . At V1JobServlet.java:[line 220]: Found reliance on default encoding in org.apache.oozie.servlet.V1JobServlet.getJob(HttpServletRequest, HttpServletResponse): new String(byte[]) . Dereferenced at V1JobsServlet.java:[line 606]: Possible null pointer dereference of jobs in org.apache.oozie.servlet.V1JobsServlet.bulkModifyJobs(HttpServletRequest, HttpServletResponse) . Known null at V1JobsServlet.java:[line 597]: Null value at V1JobsServlet.java:[line 578] . At V2AdminServlet.java:[line 59]: Write to static field org.apache.oozie.servlet.V2AdminServlet.metricsInstrumentation from instance method new org.apache.oozie.servlet.V2AdminServlet() . Dead store to coordActions in org.apache.oozie.servlet.V2JobServlet.ignoreCoordinatorJob(HttpServletRequest, HttpServletResponse): Another occurrence at V2AdminServlet.java:[line 61] . Redundant nullcheck of json, which is known to be non-null in org.apache.oozie.servlet.V2SLAServlet.doGet(HttpServletRequest, HttpServletResponse): At V2JobServlet.java:[line 218] . Found reliance on default encoding in org.apache.oozie.servlet.V2ValidateServlet.doPost(HttpServletRequest, HttpServletResponse): new java.io.InputStreamReader(InputStream): Redundant null check at V2SLAServlet.java:[line 98] . Another occurrence at V2ValidateServlet.java:[line 92]: At V2ValidateServlet.java:[line 84] . At V2ValidateServlet.java:[line 86]: Exception is caught when Exception is not thrown in org.apache.oozie.servlet.V2ValidateServlet.doPost(HttpServletRequest, HttpServletResponse) . At SLACalcStatus.java:[line 139]: org.apache.oozie.sla.SLACalcStatus.getActualEnd() may expose internal representation by returning SLACalcStatus.actualEnd . At SLACalcStatus.java:[line 130]: org.apache.oozie.sla.SLACalcStatus.getActualStart() may expose internal representation by returning SLACalcStatus.actualStart . At SLACalcStatus.java:[line 284]: org.apache.oozie.sla.SLACalcStatus.getLastModifiedTime() may expose internal representation by returning SLACalcStatus.lastModifiedTime . At SLACalcStatus.java:[line 143]: org.apache.oozie.sla.SLACalcStatus.setActualEnd(Date) may expose internal representation by storing an externally mutable object into SLACalcStatus.actualEnd . At SLACalcStatus.java:[line 134]: org.apache.oozie.sla.SLACalcStatus.setActualStart(Date) may expose internal representation by storing an externally mutable object into SLACalcStatus.actualStart . At SLACalcStatus.java:[line 183]: org.apache.oozie.sla.SLACalcStatus.setLastModifiedTime(Date) may expose internal representation by storing an externally mutable object into SLACalcStatus.lastModifiedTime . At SLACalcStatus.java:[line 37]: org.apache.oozie.sla.SLACalcStatus.SLA_ENTITYKEY_PREFIX isn't final but should be . At SLACalculatorMemory.java:[line 85]: Write to static field org.apache.oozie.sla.SLACalculatorMemory.capacity from instance method org.apache.oozie.sla.SLACalculatorMemory.init(Configuration) . At SLACalculatorMemory.java:[line 86]: Write to static field org.apache.oozie.sla.SLACalculatorMemory.jobEventLatency from instance method org.apache.oozie.sla.SLACalculatorMemory.init(Configuration) . At SLACalculatorMemory.java:[line 89]: Write to static field org.apache.oozie.sla.SLACalculatorMemory.jpaService from instance method org.apache.oozie.sla.SLACalculatorMemory.init(Configuration) . At SLACalculatorMemory.java:[line 92]: Write to static field org.apache.oozie.sla.SLACalculatorMemory.modifiedAfter from instance method org.apache.oozie.sla.SLACalculatorMemory.init(Configuration) . At SLAOperations.java:[line 89]: Invocation of toString on org.apache.oozie.client.event.SLAEvent$EventStatus.values() in org.apache.oozie.sla.SLAOperations.createSlaRegistrationEvent(Element, String, String, AppType, String, String, XLog, boolean, boolean) . At SLAOperations.java:[line 50]: org.apache.oozie.sla.SLAOperations.LOG isn't final but should be . In SLARegistrationBean.java: org.apache.oozie.sla.SLARegistrationBean.pcIsDetached() has Boolean return type and returns explicit null . At SLASummaryBean.java:[line 447]: org.apache.oozie.sla.SLASummaryBean.getTimeOnTimeZone(Timestamp, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead . In SLASummaryBean.java: org.apache.oozie.sla.SLASummaryBean.pcIsDetached() has Boolean return type and returns explicit null . At SLAEmailEventListener.java:[line 115]: Boxing/unboxing to parse a primitive org.apache.oozie.sla.listener.SLAEmailEventListener.init(Configuration) . org.apache.oozie.sla.listener.SLAEmailEventListener.EMAIL_BODY_FIELD_INDENT isn't final but should be: Another occurrence at SLAEmailEventListener.java:[line 116] . org.apache.oozie.sla.listener.SLAEmailEventListener.EMAIL_BODY_FIELD_SEPARATER isn't final but should be: At SLAEmailEventListener.java:[line 80] . org.apache.oozie.sla.listener.SLAEmailEventListener.EMAIL_BODY_HEADER_SEPARATER isn't final but should be: At SLAEmailEventListener.java:[line 79] . org.apache.oozie.sla.service.SLAService.LOG should be package protected: At SLAEmailEventListener.java:[line 81] . Write to static field org.apache.oozie.sla.service.SLAService.slaEnabled from instance method org.apache.oozie.sla.service.SLAService.destroy(): In SLAService.java . Write to static field org.apache.oozie.sla.service.SLAService.LOG from instance method org.apache.oozie.sla.service.SLAService.init(Services): At SLAService.java:[line 96] . Write to static field org.apache.oozie.sla.service.SLAService.calcImpl from instance method org.apache.oozie.sla.service.SLAService.init(Services): At SLAService.java:[line 74] . Write to static field org.apache.oozie.sla.service.SLAService.slaEnabled from instance method org.apache.oozie.sla.service.SLAService.init(Services): At SLAService.java:[line 67] . Should org.apache.oozie.sla.service.SLAService$SLAWorker be a _static_ inner class?: At SLAService.java:[line 85] . Dead store to schema in new org.apache.oozie.store.WorkflowStore(boolean): At SLAService.java:[lines 121-136] . Dead store to oq in org.apache.oozie.store.WorkflowStore$11.call(): At WorkflowStore.java:[line 91] . Dead store to actions in org.apache.oozie.store.WorkflowStore$13.call(): At WorkflowStore.java:[line 378] . Possible null pointer dereference of q in org.apache.oozie.store.WorkflowStore$15.call(): At WorkflowStore.java:[line 434] . Null value at WorkflowStore.java:[line 642]: Dereferenced at WorkflowStore.java:[line 672] . Possible null pointer dereference of qTotal in org.apache.oozie.store.WorkflowStore$15.call(): Known null at WorkflowStore.java:[line 651] . Null value at WorkflowStore.java:[line 643]: Dereferenced at WorkflowStore.java:[line 681] . org.apache.oozie.util.AuthUrlClient.getQueryParamString(Map) makes inefficient use of keySet iterator instead of entrySet iterator: Known null at WorkflowStore.java:[line 651] . Found reliance on default encoding in org.apache.oozie.util.AuthUrlClient$1.run(): new java.io.InputStreamReader(InputStream): At AuthUrlClient.java:[line 153] . org.apache.oozie.util.ConfigUtils.BOOLEAN_DEFAULT isn't final but should be: At AuthUrlClient.java:[line 135] . org.apache.oozie.util.ConfigUtils.FLOAT_DEFAULT isn't final but should be: At ConfigUtils.java:[line 36] . org.apache.oozie.util.ConfigUtils.INT_DEFAULT isn't final but should be: At ConfigUtils.java:[line 39] . org.apache.oozie.util.ConfigUtils.LONG_DEFAULT isn't final but should be: At ConfigUtils.java:[line 38] . org.apache.oozie.util.ConfigUtils.STRING_DEFAULT isn't final but should be: At ConfigUtils.java:[line 40] . Load of known null value in org.apache.oozie.util.DateUtils.getTimeZone(String): At ConfigUtils.java:[line 37] . Redundant nullcheck of d, which is known to be non-null in org.apache.oozie.util.DateUtils.parseDateOozieTZ(String): At DateUtils.java:[line 140] . org.apache.oozie.util.GraphGenerator.finalize() is public; should be protected: Redundant null check at DateUtils.java:[line 177] . Unread field: org.apache.oozie.util.GraphGenerator.actionsLimit; should this field be static?: At GraphGenerator.java:[line 95] . Switch statement found in org.apache.oozie.util.GraphGenerator$XMLParser.endDocument() where default case is missing: At GraphGenerator.java:[line 62] . Found reliance on default encoding in org.apache.oozie.util.IOUtils.getResourceAsReader(String, int): new java.io.InputStreamReader(InputStream): At GraphGenerator.java:[lines 160-165] . Found reliance on default encoding in org.apache.oozie.util.IOUtils.getResourceAsString(String, int): new java.io.InputStreamReader(InputStream): At IOUtils.java:[line 119] . org.apache.oozie.util.IOUtils.zipDir(File, String, ZipOutputStream, boolean) may fail to clean up java.io.InputStream on checked exception: At IOUtils.java:[line 136] . Path continues at IOUtils.java:[line 210]: Obligation to clean up resource created at IOUtils.java:[line 209] is not discharged . Integral division result cast to double or float in org.apache.oozie.util.Instrumentation$Timer.evalStdDev(long, long, long): Path continues at IOUtils.java:[line 211] . Found reliance on default encoding in org.apache.oozie.util.MultiFileReader.openNextReader(): new java.io.FileReader(File): At Instrumentation.java:[line 437] . Found reliance on default encoding in org.apache.oozie.util.MultiFileReader.openNextReader(): new java.io.InputStreamReader(InputStream): At MultiFileReader.java:[line 86] . Exceptional return value of java.io.File.delete() ignored in org.apache.oozie.util.OozieRollingPolicy.deleteOldFiles(): At MultiFileReader.java:[line 82] . org.apache.oozie.util.OozieRollingPolicy$FileInfo defines compareTo(OozieRollingPolicy$FileInfo) and uses Object.equals(): At OozieRollingPolicy.java:[line 162] . Should org.apache.oozie.util.OozieRollingPolicy$FileInfo be a _static_ inner class?: At OozieRollingPolicy.java:[lines 203-211] . key must be nonnull but is marked as nullable: At OozieRollingPolicy.java:[lines 184-211] . value must be nonnull but is marked as nullable: At PasswordMasker.java:[lines 74-85] . org.apache.oozie.util.PriorityDelayQueue$QueueElement defines compareTo(Object) and uses Object.equals(): At PasswordMasker.java:[lines 74-85] . Dead store to conf in org.apache.oozie.util.StatusUtils.isV1CoordjobKillable(CoordinatorJobBean): At PriorityDelayQueue.java:[line 63] . Load of known null value in org.apache.oozie.util.StringSerializationUtil.writeString(DataOutput, String): At StatusUtils.java:[line 134] . Found reliance on default encoding in org.apache.oozie.util.XConfiguration.toXmlString(boolean): new String(byte[]): At StringSerializationUtil.java:[line 48] . org.apache.oozie.util.XLogFilter.getEndDate() may expose internal representation by returning XLogFilter.endDate: At XConfiguration.java:[line 368] . org.apache.oozie.util.XLogFilter.getStartDate() may expose internal representation by returning XLogFilter.startDate: At XLogFilter.java:[line 207] . org.apache.oozie.util.XLogFilter.MAX_ACTIONLIST_SCAN_DURATION isn't final but should be: At XLogFilter.java:[line 219] . org.apache.oozie.util.XLogFilter.MAX_SCAN_DURATION isn't final but should be: At XLogFilter.java:[line 43] . org.apache.oozie.util.XLogStreamer$FileInfo defines compareTo(XLogStreamer$FileInfo) and uses Object.equals(): At XLogFilter.java:[line 44] . Should org.apache.oozie.util.XLogStreamer$FileInfo be a _static_ inner class?: At XLogStreamer.java:[lines 139-147] . org.apache.oozie.util.XLogUserFilterParam.getEndDate() may expose internal representation by returning XLogUserFilterParam.endTime: At XLogStreamer.java:[lines 121-147] . org.apache.oozie.util.XLogUserFilterParam.getEndTime() may expose internal representation by returning XLogUserFilterParam.endTime: At XLogUserFilterParam.java:[line 183] . org.apache.oozie.util.XLogUserFilterParam.getStartDate() may expose internal representation by returning XLogUserFilterParam.startTime: At XLogUserFilterParam.java:[line 251] . Found reliance on default encoding in org.apache.oozie.util.XmlUtils.validateXml(Schema, String): String.getBytes(): At XLogUserFilterParam.java:[line 174] . Should org.apache.oozie.util.ZKUtils$ZKMetadataKeys be a _static_ inner class?: At XmlUtils.java:[line 284] . Result of integer multiplication cast to long in org.apache.oozie.util.db.SLADbOperations.createSlaRegistrationEvent(Element, String, SLAEvent$SlaAppType, String, String, XLog): At ZKUtils.java:[line 389] . Another occurrence at SLADbOperations.java:[line 148]: At SLADbOperations.java:[line 131] . At SLADbOperations.java:[line 63]: Result of integer multiplication cast to long in org.apache.oozie.util.db.SLADbOperations.createSlaRegistrationEvent(Element, Store, String, SLAEvent$SlaAppType, String, String) . Result of integer multiplication cast to long in org.apache.oozie.util.db.SLADbXOperations.createSlaRegistrationEvent(Element, String, SLAEvent$SlaAppType, String, String): Another occurrence at SLADbOperations.java:[line 80] . Another occurrence at SLADbXOperations.java:[line 89]: At SLADbXOperations.java:[line 71] . At SqlStatement.java:[line 897]: Dead store to stmt in org.apache.oozie.util.db.SqlStatement.prepareForBatch(Connection, List, PreparedStatement) . Dereferenced at SqlStatement.java:[line 971]: Possible null pointer dereference of retVal in org.apache.oozie.util.db.SqlStatement.create(ArrayList) . Known null at SqlStatement.java:[line 965]: Null value at SqlStatement.java:[line 952] . Obligation to clean up resource created at SqlStatement.java:[line 842] is not discharged: org.apache.oozie.util.db.SqlStatement.prepareAndSetValues(Connection) may fail to clean up java.sql.Statement on checked exception . Path continues at SqlStatement.java:[line 844]: Path continues at SqlStatement.java:[line 843] . org.apache.oozie.util.db.SqlStatement$ResultSetReader.getByteArray(Schema$Column) may fail to close stream: Path continues at SqlStatement.java:[line 845] . Unwritten field: org.apache.oozie.util.db.ValidateConnectionBean.pcPCSuperclass: At SqlStatement.java:[line 116] . org.apache.oozie.workflow.lite.LiteWorkflowApp defines equals(LiteWorkflowApp) method and uses Object.equals(Object): In ValidateConnectionBean.java . Should org.apache.oozie.workflow.lite.LiteWorkflowAppParser$GlobalSectionData be a _static_ inner class?: At LiteWorkflowApp.java:[line 58] . Inconsistent synchronization of org.apache.oozie.workflow.lite.LiteWorkflowInstance.log; locked 86% of time: At LiteWorkflowAppParser.java:[lines 368-413] . Unsynchronized access at LiteWorkflowInstance.java:[line 324]: Unsynchronized access at LiteWorkflowInstance.java:[line 543] . Synchronized access at LiteWorkflowInstance.java:[line 472]: Unsynchronized access at LiteWorkflowInstance.java:[line 329] . Synchronized access at LiteWorkflowInstance.java:[line 381]: Synchronized access at LiteWorkflowInstance.java:[line 173] . Synchronized access at LiteWorkflowInstance.java:[line 194]: Synchronized access at LiteWorkflowInstance.java:[line 190] . Synchronized access at LiteWorkflowInstance.java:[line 299]: Synchronized access at LiteWorkflowInstance.java:[line 202] . Synchronized access at LiteWorkflowInstance.java:[line 221]: Synchronized access at LiteWorkflowInstance.java:[line 306] . Synchronized access at LiteWorkflowInstance.java:[line 255]: Synchronized access at LiteWorkflowInstance.java:[line 252] . Synchronized access at LiteWorkflowInstance.java:[line 265]: Synchronized access at LiteWorkflowInstance.java:[line 258] . Synchronized access at LiteWorkflowInstance.java:[line 493]: Synchronized access at LiteWorkflowInstance.java:[line 449] . Synchronized access at LiteWorkflowInstance.java:[line 360]: Synchronized access at LiteWorkflowInstance.java:[line 357] . Synchronized access at LiteWorkflowInstance.java:[line 348]: Synchronized access at LiteWorkflowInstance.java:[line 341] . Inconsistent synchronization of org.apache.oozie.workflow.lite.LiteWorkflowInstance.status; locked 81% of time: Synchronized access at LiteWorkflowInstance.java:[line 369] . Unsynchronized access at LiteWorkflowInstance.java:[line 547]: Unsynchronized access at LiteWorkflowInstance.java:[line 568] . Unsynchronized access at LiteWorkflowInstance.java:[line 604]: Unsynchronized access at LiteWorkflowInstance.java:[line 551] . Unsynchronized access at LiteWorkflowInstance.java:[line 427]: Unsynchronized access at LiteWorkflowInstance.java:[line 374] . Synchronized access at LiteWorkflowInstance.java:[line 174]: Synchronized access at LiteWorkflowInstance.java:[line 170] . Synchronized access at LiteWorkflowInstance.java:[line 382]: Synchronized access at LiteWorkflowInstance.java:[line 378] . Synchronized access at LiteWorkflowInstance.java:[line 198]: Synchronized access at LiteWorkflowInstance.java:[line 185] . Synchronized access at LiteWorkflowInstance.java:[line 206]: Synchronized access at LiteWorkflowInstance.java:[line 193] . Synchronized access at LiteWorkflowInstance.java:[line 201]: Synchronized access at LiteWorkflowInstance.java:[line 296] . Synchronized access at LiteWorkflowInstance.java:[line 297]: Synchronized access at LiteWorkflowInstance.java:[line 312] . Synchronized access at LiteWorkflowInstance.java:[line 218]: Synchronized access at LiteWorkflowInstance.java:[line 298] . Synchronized access at LiteWorkflowInstance.java:[line 299]: Synchronized access at LiteWorkflowInstance.java:[line 246] . Synchronized access at LiteWorkflowInstance.java:[line 251]: Synchronized access at LiteWorkflowInstance.java:[line 306] . Synchronized access at LiteWorkflowInstance.java:[line 254]: Synchronized access at LiteWorkflowInstance.java:[line 221] . Synchronized access at LiteWorkflowInstance.java:[line 354]: Synchronized access at LiteWorkflowInstance.java:[line 257] . Synchronized access at LiteWorkflowInstance.java:[line 336]: Synchronized access at LiteWorkflowInstance.java:[line 362] . Synchronized access at LiteWorkflowInstance.java:[line 366]: Synchronized access at LiteWorkflowInstance.java:[line 350] . Should org.apache.oozie.workflow.lite.LiteWorkflowValidator$ForkJoinCount be a _static_ inner class?: Synchronized access at LiteWorkflowInstance.java:[line 370] . org.apache.oozie.workflow.lite.NodeDef defines equals(NodeDef) method and uses Object.equals(Object): At LiteWorkflowValidator.java:[lines 347-349] . At NodeDef.java:[line 81] . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:red}-1{color} There are [19] new bugs found below threshold in [hadooplibs/hadoop-utils-2] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): hadooplibs/hadoop-utils-2/findbugs-new.html . The most important FindBugs errors are: . At LauncherMain.java:[line 69]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMain.getHadoopJobIds(String, Pattern[]): new java.io.FileReader(String) . At LauncherMain.java:[line 99]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMain.writeExternalChildIDs(String, Pattern[], String): String.getBytes() . At LauncherMain.java:[line 55]: org.apache.oozie.action.hadoop.LauncherMain.HADOOP_SITE_FILES should be both final and package protected . At LauncherMain.java:[line 266]: Exceptional return value of java.io.File.mkdirs() ignored in org.apache.oozie.action.hadoop.LauncherMain.writeHadoopConfig(String, File) . At LauncherMapper.java:[line 407]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File, String, int): new java.io.FileReader(File) . At LauncherMapper.java:[line 355]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new java.io.FileWriter(String) . At LauncherMapper.java:[line 356]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new java.io.OutputStreamWriter(OutputStream) . At LauncherMapper.java:[line 105]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration, Path, String): new java.io.InputStreamReader(InputStream) . At LauncherMapper.java:[line 95]: Found reliance on default encoding in org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration, Path, String): new java.io.OutputStreamWriter(OutputStream) . Obligation to clean up resource created at LauncherMapper.java:[line 407] is not discharged: org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File, String, int) may fail to clean up java.io.Reader on checked exception . Path continues at LauncherMapper.java:[line 410]: Path continues at LauncherMapper.java:[line 408] . org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf() may fail to clean up java.io.Writer on checked exception: Path continues at LauncherMapper.java:[line 411] . Write to static field org.apache.oozie.action.hadoop.LauncherSecurityManager.exitCode from instance method org.apache.oozie.action.hadoop.LauncherSecurityManager.checkExit(int): Obligation to clean up resource created at LauncherMapper.java:[line 355] is not discharged . Write to static field org.apache.oozie.action.hadoop.LauncherSecurityManager.exitInvoked from instance method org.apache.oozie.action.hadoop.LauncherSecurityManager.checkExit(int): At LauncherMapper.java:[line 679] . Found reliance on default encoding in org.apache.oozie.action.hadoop.MapReduceMain.writeJobIdFile(File, String): String.getBytes(): At LauncherMapper.java:[line 678] . org.apache.oozie.action.hadoop.MapReduceMain.writeJobIdFile(File, String) may fail to clean up java.io.OutputStream on checked exception: At MapReduceMain.java:[line 76] . Path continues at MapReduceMain.java:[line 76]: Obligation to clean up resource created at MapReduceMain.java:[line 75] is not discharged . At ShellMain.java:[line 228]: Found reliance on default encoding in org.apache.oozie.action.hadoop.ShellMain.handleShellOutput(Process, boolean): new java.io.InputStreamReader(InputStream) . Found reliance on default encoding in org.apache.oozie.action.hadoop.ShellMain.writeLoggerProperties(Configuration, File): new java.io.PrintWriter(OutputStream): Another occurrence at ShellMain.java:[line 229] . Found reliance on default encoding in org.apache.oozie.action.hadoop.ShellMain$OutputWriteThread.run(): new java.io.FileWriter(File): At ShellMain.java:[line 172] . Should org.apache.oozie.action.hadoop.ShellMain$OutputWriteThread be a _static_ inner class?: At ShellMain.java:[line 265] . At ShellMain.java:[lines 247-305] . {color:green}+1{color} There are no new bugs found in [tools]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} . Tests run: 1844 {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3583/ > Config-default.xml longer than 64k results in java.io.UTFDataFormatException > ----------------------------------------------------------------------------- > > Key: OOZIE-2777 > URL: https://issues.apache.org/jira/browse/OOZIE-2777 > Project: Oozie > Issue Type: Bug > Reporter: Peter Cseh > Assignee: Peter Cseh > Attachments: OOZIE-2777-10.patch, OOZIE-2777-1.patch, > OOZIE-2777-2.patch, OOZIE-2777-3.patch, OOZIE-2777-4.patch, > OOZIE-2777-5.patch, OOZIE-2777-7.patch, OOZIE-2777-8.patch, OOZIE-2777-9.patch > > > OOZIE-1642 introduced a workaround for DataOutputStream's 64k limit for > Strings. > We've encountered the same error when a config-default.xml is larger than the > limit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)