----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/#review168048 -----------------------------------------------------------
core/src/main/resources/oozie-default.xml Line 298 (original), 298 (patched) <https://reviews.apache.org/r/57305/#comment240076> The extra whitespace changes are still here. core/src/main/resources/oozie-default.xml Line 2884 (original), 2884 (patched) <https://reviews.apache.org/r/57305/#comment240078> I don't think we should remove this. That makes it an undocumented config property. We should just note that it is deprecated and mention the new property. core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java Lines 95-97 (original), 59-61 (patched) <https://reviews.apache.org/r/57305/#comment240079> I think this is easier to read with the original indenting. core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java Line 128 (original), 93 (patched) <https://reviews.apache.org/r/57305/#comment240080> I think this is easier to read with the original indenting. core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java Lines 136-138 (patched) <https://reviews.apache.org/r/57305/#comment240081> I like the other indenting better. - Robert Kanter On March 5, 2017, 9:53 p.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57305/ > ----------------------------------------------------------- > > (Updated March 5, 2017, 9:53 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2811 > https://issues.apache.org/jira/browse/OOZIE-2811 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2811 > Add support for filtering out properties from SparkConfigurationService > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > e2e023e6d9a14fa1feb8abb2028dfbd67a163090 > core/src/main/java/org/apache/oozie/service/SparkConfigurationService.java > b29ab8d80b7d900603b4697e54a03365fc2e8634 > core/src/main/resources/oozie-default.xml > 95e0c36e1b2f5aef18637f6f956a990ba36166f2 > > core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java > 9d82fdc1a75be5c17da36f1cc2189246e2be0859 > > > Diff: https://reviews.apache.org/r/57305/diff/3/ > > > Testing > ------- > > Existing tests passed and added some more. > > > Thanks, > > Peter Cseh > >
