[ https://issues.apache.org/jira/browse/OOZIE-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934125#comment-15934125 ]
Xiaobin Zheng commented on OOZIE-2835: -------------------------------------- Thx for the improvement [~asasvari]! +1 (non-binding) for the patch with one minor nit: fail() seems to be more widely used across the codebase. > TestIOUtils shall not be an XTestCase > ------------------------------------- > > Key: OOZIE-2835 > URL: https://issues.apache.org/jira/browse/OOZIE-2835 > Project: Oozie > Issue Type: Bug > Reporter: Attila Sasvari > Assignee: Attila Sasvari > Priority: Trivial > Attachments: OOZIE-2835.01.patch > > > TestIOUtils unnecessary extends XTestCase that makes the execution time of > the test case really long: > {code} > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.675 sec > Results : > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 > {code} > XTestCase sets up Oozie services which is not needed for testing IOUtils, > that's why it takes ~20 seconds. > If we make TestIOUtils a true unit test class, the execution time of the > tests could be drastically reduced: > {code} > Running org.apache.oozie.util.TestIOUtils > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec > Results : > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)