See
<https://builds.apache.org/job/oozie-trunk-precommit-build/3720/display/redirect>
------------------------------------------
[...truncated 1.21 MB...]
At HCatAccessorService.java:[line 74]: Write to static field
org.apache.oozie.service.HCatAccessorService.LOG from instance method
org.apache.oozie.service.HCatAccessorService.init(Services)
Obligation to clean up resource created at HadoopAccessorService.java:[line
426] is not discharged:
org.apache.oozie.service.HadoopAccessorService.readActionConfFile(File) may
fail to clean up java.io.InputStream
Path continues at HadoopAccessorService.java:[line 428]: Path continues at
HadoopAccessorService.java:[line 427]
Path continues at HadoopAccessorService.java:[line 433]: Path continues at
HadoopAccessorService.java:[line 432]
Path continues at HadoopAccessorService.java:[line 440]: Path continues at
HadoopAccessorService.java:[line 434]
At InstrumentationService.java:[line 42]:
org.apache.oozie.service.InstrumentationService.instrumentation should be
package protected
At InstrumentationService.java:[line 122]: Write to static field
org.apache.oozie.service.InstrumentationService.instrumentation from instance
method org.apache.oozie.service.InstrumentationService.destroy()
At InstrumentationService.java:[line 121]: Write to static field
org.apache.oozie.service.InstrumentationService.isEnabled from instance method
org.apache.oozie.service.InstrumentationService.destroy()
At InstrumentationService.java:[line 74]: Write to static field
org.apache.oozie.service.InstrumentationService.instrumentation from instance
method org.apache.oozie.service.InstrumentationService.init(Services)
At InstrumentationService.java:[line 75]: Write to static field
org.apache.oozie.service.InstrumentationService.isEnabled from instance method
org.apache.oozie.service.InstrumentationService.init(Services)
Unsynchronized access at JMSAccessorService.java:[line 331]: Inconsistent
synchronization of
org.apache.oozie.service.JMSAccessorService.jmsProducerConnContext; locked 42%
of time
Unsynchronized access at JMSAccessorService.java:[line 278]: Unsynchronized
access at JMSAccessorService.java:[line 332]
Unsynchronized access at JMSAccessorService.java:[line 279]: Unsynchronized
access at JMSAccessorService.java:[line 278]
Synchronized access at JMSAccessorService.java:[line 283]: Unsynchronized
access at JMSAccessorService.java:[line 298]
Synchronized access at JMSAccessorService.java:[line 285]: Synchronized
access at JMSAccessorService.java:[line 283]
Synchronized access at JMSAccessorService.java:[line 287]: Synchronized
access at JMSAccessorService.java:[line 286]
Write to static field org.apache.oozie.service.JMSAccessorService.LOG from
instance method org.apache.oozie.service.JMSAccessorService.init(Services):
Synchronized access at JMSAccessorService.java:[line 287]
Write to static field org.apache.oozie.service.JMSTopicService.LOG from
instance method org.apache.oozie.service.JMSTopicService.init(Services): At
JMSAccessorService.java:[line 85]
Write to static field org.apache.oozie.service.JPAService.LOG from instance
method org.apache.oozie.service.JPAService.init(Services): At
JMSTopicService.java:[line 99]
Write to static field org.apache.oozie.service.JobsConcurrencyService.urls
from instance method
org.apache.oozie.service.JobsConcurrencyService.init(Services): At
JPAService.java:[line 141]
Write to static field
org.apache.oozie.service.MetricsInstrumentationService.isEnabled from instance
method org.apache.oozie.service.MetricsInstrumentationService.destroy(): At
JobsConcurrencyService.java:[line 47]
Write to static field
org.apache.oozie.service.InstrumentationService.instrumentation from instance
method org.apache.oozie.service.MetricsInstrumentationService.init(Services):
At MetricsInstrumentationService.java:[line 54]
Write to static field
org.apache.oozie.service.MetricsInstrumentationService.isEnabled from instance
method org.apache.oozie.service.MetricsInstrumentationService.init(Services):
At MetricsInstrumentationService.java:[line 45]
Unread field:
org.apache.oozie.service.PartitionDependencyManagerService$CachePurgeWorker.cache:
At MetricsInstrumentationService.java:[line 46]
Possible null pointer dereference of bundleJob in
org.apache.oozie.service.RecoveryService$RecoveryRunnable.runBundleRecovery():
At PartitionDependencyManagerService.java:[line 96]
Null value at RecoveryService.java:[line 208]: Dereferenced at
RecoveryService.java:[line 213]
Initialization of org.apache.oozie.service.Service accesses class
org.apache.oozie.service.ConfigurationService, which isn't initialized yet:
Known null at RecoveryService.java:[line 209]
Incorrect lazy initialization of static field
org.apache.oozie.service.Services.SERVICES in new
org.apache.oozie.service.Services(): At Service.java:[line 56]
Exceptional return value of java.io.File.delete() ignored in
org.apache.oozie.service.Services.createRuntimeDir(): At Services.java:[lines
105-109]
Write to static field org.apache.oozie.service.Services.SERVICES from
instance method new org.apache.oozie.service.Services(): At Services.java:[line
132]
Write to static field org.apache.oozie.service.Services.SERVICES from
instance method org.apache.oozie.service.Services.destroy(): At
Services.java:[line 109]
Write to static field org.apache.oozie.service.Services.SERVICES from
instance method org.apache.oozie.service.Services.init(): At
Services.java:[line 349]
Another occurrence at Services.java:[line 221]: At Services.java:[line 211]
At Services.java:[line 155]:
org.apache.oozie.service.Services.getSystemMode() is unsynchronized,
org.apache.oozie.service.Services.setSystemMode(OozieClient$SYSTEM_MODE) is
synchronized
At ShareLibService.java:[line 113]: Result of integer multiplication cast
to long in new org.apache.oozie.service.ShareLibService()
At ShareLibService.java:[line 162]: Result of integer multiplication cast
to long in org.apache.oozie.service.ShareLibService.init(Services)
At ShareLibService.java:[line 103]:
org.apache.oozie.service.ShareLibService.SHARE_LIB_CONF_PREFIX isn't final but
should be
At ShareLibService.java:[line 692]: Call to method of static
java.text.DateFormat in
org.apache.oozie.service.ShareLibService.getLatestLibPath(Path, String)
At ShareLibService.java:[line 662]: Call to method of static
java.text.DateFormat in
org.apache.oozie.service.ShareLibService.getLauncherlibPath()
In ShareLibService.java:
org.apache.oozie.service.ShareLibService.dateFormat is a static field of type
java.text.DateFormat, which isn't thread safe
At ShareLibService.java:[line 479]: Call to method of static
java.text.DateFormat in org.apache.oozie.service.ShareLibService$2.accept(Path)
At StatusTransitService.java:[line 59]:
org.apache.oozie.service.StatusTransitService.lastInstanceStartTime should be
package protected
At StatusTransitService.java:[line 58]:
org.apache.oozie.service.StatusTransitService.limit isn't final but should be
At URIHandlerService.java:[line 210]:
org.apache.oozie.service.URIHandlerService.getAuthorityWithScheme(String)
invokes substring(0), which returns the original value
At WorkflowAppService.java:[line 133]: Found reliance on default encoding
in org.apache.oozie.service.WorkflowAppService.readDefinition(String, String,
Configuration): new java.io.InputStreamReader(InputStream)
At WorkflowAppService.java:[lines 320-323]: Should
org.apache.oozie.service.WorkflowAppService$NoPathFilter be a _static_ inner
class?
Obligation to clean up resource created at XLogService.java:[line 202] is
not discharged: org.apache.oozie.service.XLogService.init(Services) may fail to
clean up java.io.InputStream
Path continues at XLogService.java:[line 207]: Path continues at
XLogService.java:[line 203]
org.apache.oozie.service.XLogUtil.log isn't final but should be: Path
continues at XLogService.java:[line 208]
Write to static field
org.apache.oozie.service.ZKJobsConcurrencyService.leaderLatch from instance
method org.apache.oozie.service.ZKJobsConcurrencyService.init(Services): At
XLogUtil.java:[line 34]
Should org.apache.oozie.service.ZKLocksService$ZKLockToken be a _static_
inner class?: At ZKJobsConcurrencyService.java:[line 73]
Dead store to xLogService in
org.apache.oozie.service.ZKXLogStreamingService.collateLogs(XLogFilter, Date,
Date, Writer, Map, String, String, int, String): At ZKLocksService.java:[lines
174-201]
org.apache.oozie.servlet.BaseAdminServlet.getShareLib(String) makes
inefficient use of keySet iterator instead of entrySet iterator: At
ZKXLogStreamingService.java:[line 208]
Load of known null value in
org.apache.oozie.servlet.BaseJobServlet.checkAuthorizationForApp(Configuration):
At BaseAdminServlet.java:[line 247]
Redundant nullcheck of actionId, which is known to be non-null in
org.apache.oozie.servlet.CallbackServlet.doGet(HttpServletRequest,
HttpServletResponse): At BaseJobServlet.java:[line 239]
Redundant nullcheck of actionId, which is known to be non-null in
org.apache.oozie.servlet.CallbackServlet.doPost(HttpServletRequest,
HttpServletResponse): Redundant null check at CallbackServlet.java:[line 76]
Class org.apache.oozie.servlet.CallbackServlet defines non-transient
non-serializable instance field log: Redundant null check at
CallbackServlet.java:[line 107]
Write to static field org.apache.oozie.servlet.CallbackServlet.maxDataLen
from instance method org.apache.oozie.servlet.CallbackServlet.init(): In
CallbackServlet.java
Class org.apache.oozie.servlet.JVMInfo defines non-transient
non-serializable instance field jThreadInfos: At CallbackServlet.java:[line 60]
Class org.apache.oozie.servlet.JVMInfo defines non-transient
non-serializable instance field classLoadingMXBean: In JVMInfo.java
Class org.apache.oozie.servlet.JVMInfo defines non-transient
non-serializable instance field memoryMXBean: In JVMInfo.java
Class org.apache.oozie.servlet.JVMInfo defines non-transient
non-serializable instance field threadMXBean: In JVMInfo.java
org.apache.oozie.servlet.JVMInfo$ThreadComparator implements Comparator but
not Serializable: In JVMInfo.java
Dead store to eResponse in
org.apache.oozie.servlet.SLAServlet.doGet(HttpServletRequest,
HttpServletResponse): At JVMInfo.java:[lines 224-271]
org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServletContextEvent)
invokes System.exit(...), which shuts down the entire virtual machine: At
SLAServlet.java:[line 80]
Write to static field org.apache.oozie.servlet.ServicesLoader.services from
instance method
org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServletContextEvent):
At ServicesLoader.java:[line 59]
Write to static field org.apache.oozie.servlet.ServicesLoader.sslEnabled
from instance method
org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServletContextEvent):
At ServicesLoader.java:[line 45]
The method name
org.apache.oozie.servlet.ServletUtilities.ValidateAppPath(String, String)
doesn't start with a lower case letter: At ServicesLoader.java:[line 42]
The method name
org.apache.oozie.servlet.ServletUtilities.ValidateAppPath(String, String,
String) doesn't start with a lower case letter: At ServletUtilities.java:[lines
36-46]
The method name
org.apache.oozie.servlet.ServletUtilities.ValidateLibPath(String) doesn't start
with a lower case letter: At ServletUtilities.java:[lines 59-80]
Dead store to json in
org.apache.oozie.servlet.V1JobServlet.rerunBundleJob(HttpServletRequest,
HttpServletResponse, Configuration): At ServletUtilities.java:[lines 89-92]
Found reliance on default encoding in
org.apache.oozie.servlet.V1JobServlet.getJob(HttpServletRequest,
HttpServletResponse): new String(byte[]): At V1JobServlet.java:[line 628]
Possible null pointer dereference of jobs in
org.apache.oozie.servlet.V1JobsServlet.bulkModifyJobs(HttpServletRequest,
HttpServletResponse): At V1JobServlet.java:[line 223]
Null value at V1JobsServlet.java:[line 578]: Dereferenced at
V1JobsServlet.java:[line 606]
Write to static field
org.apache.oozie.servlet.V2AdminServlet.metricsInstrumentation from instance
method new org.apache.oozie.servlet.V2AdminServlet(): Known null at
V1JobsServlet.java:[line 597]
Another occurrence at V2AdminServlet.java:[line 61]: At
V2AdminServlet.java:[line 59]
At V2JobServlet.java:[line 222]: Dead store to coordActions in
org.apache.oozie.servlet.V2JobServlet.ignoreCoordinatorJob(HttpServletRequest,
HttpServletResponse)
Redundant null check at V2SLAServlet.java:[line 98]: Redundant nullcheck of
json, which is known to be non-null in
org.apache.oozie.servlet.V2SLAServlet.doGet(HttpServletRequest,
HttpServletResponse)
At V2ValidateServlet.java:[line 84]: Found reliance on default encoding in
org.apache.oozie.servlet.V2ValidateServlet.doPost(HttpServletRequest,
HttpServletResponse): new java.io.InputStreamReader(InputStream)
Exception is caught when Exception is not thrown in
org.apache.oozie.servlet.V2ValidateServlet.doPost(HttpServletRequest,
HttpServletResponse): Another occurrence at V2ValidateServlet.java:[line 92]
org.apache.oozie.sla.SLACalcStatus.getActualEnd() may expose internal
representation by returning SLACalcStatus.actualEnd: At
V2ValidateServlet.java:[line 86]
org.apache.oozie.sla.SLACalcStatus.getActualStart() may expose internal
representation by returning SLACalcStatus.actualStart: At
SLACalcStatus.java:[line 139]
org.apache.oozie.sla.SLACalcStatus.getLastModifiedTime() may expose
internal representation by returning SLACalcStatus.lastModifiedTime: At
SLACalcStatus.java:[line 130]
org.apache.oozie.sla.SLACalcStatus.setActualEnd(Date) may expose internal
representation by storing an externally mutable object into
SLACalcStatus.actualEnd: At SLACalcStatus.java:[line 284]
org.apache.oozie.sla.SLACalcStatus.setActualStart(Date) may expose internal
representation by storing an externally mutable object into
SLACalcStatus.actualStart: At SLACalcStatus.java:[line 143]
org.apache.oozie.sla.SLACalcStatus.setLastModifiedTime(Date) may expose
internal representation by storing an externally mutable object into
SLACalcStatus.lastModifiedTime: At SLACalcStatus.java:[line 134]
org.apache.oozie.sla.SLACalcStatus.SLA_ENTITYKEY_PREFIX isn't final but
should be: At SLACalcStatus.java:[line 183]
Write to static field org.apache.oozie.sla.SLACalculatorMemory.capacity
from instance method
org.apache.oozie.sla.SLACalculatorMemory.init(Configuration): At
SLACalcStatus.java:[line 37]
Write to static field
org.apache.oozie.sla.SLACalculatorMemory.jobEventLatency from instance method
org.apache.oozie.sla.SLACalculatorMemory.init(Configuration): At
SLACalculatorMemory.java:[line 85]
Write to static field org.apache.oozie.sla.SLACalculatorMemory.jpaService
from instance method
org.apache.oozie.sla.SLACalculatorMemory.init(Configuration): At
SLACalculatorMemory.java:[line 86]
Write to static field
org.apache.oozie.sla.SLACalculatorMemory.modifiedAfter from instance method
org.apache.oozie.sla.SLACalculatorMemory.init(Configuration): At
SLACalculatorMemory.java:[line 89]
Invocation of toString on
org.apache.oozie.client.event.SLAEvent$EventStatus.values() in
org.apache.oozie.sla.SLAOperations.createSlaRegistrationEvent(Element, String,
String, AppType, String, String, XLog, boolean, boolean): At
SLACalculatorMemory.java:[line 92]
org.apache.oozie.sla.SLAOperations.LOG isn't final but should be: At
SLAOperations.java:[line 89]
org.apache.oozie.sla.SLARegistrationBean.pcIsDetached() has Boolean return
type and returns explicit null: At SLAOperations.java:[line 50]
org.apache.oozie.sla.SLASummaryBean.getTimeOnTimeZone(Timestamp, String)
invokes inefficient new Long(String) constructor; use Long.valueOf(String)
instead: In SLARegistrationBean.java
org.apache.oozie.sla.SLASummaryBean.pcIsDetached() has Boolean return type
and returns explicit null: At SLASummaryBean.java:[line 447]
Boxing/unboxing to parse a primitive
org.apache.oozie.sla.listener.SLAEmailEventListener.init(Configuration): In
SLASummaryBean.java
Another occurrence at SLAEmailEventListener.java:[line 116]: At
SLAEmailEventListener.java:[line 115]
At SLAEmailEventListener.java:[line 80]:
org.apache.oozie.sla.listener.SLAEmailEventListener.EMAIL_BODY_FIELD_INDENT
isn't final but should be
At SLAEmailEventListener.java:[line 79]:
org.apache.oozie.sla.listener.SLAEmailEventListener.EMAIL_BODY_FIELD_SEPARATER
isn't final but should be
At SLAEmailEventListener.java:[line 81]:
org.apache.oozie.sla.listener.SLAEmailEventListener.EMAIL_BODY_HEADER_SEPARATER
isn't final but should be
In SLAService.java: org.apache.oozie.sla.service.SLAService.LOG should be
package protected
At SLAService.java:[line 96]: Write to static field
org.apache.oozie.sla.service.SLAService.slaEnabled from instance method
org.apache.oozie.sla.service.SLAService.destroy()
At SLAService.java:[line 74]: Write to static field
org.apache.oozie.sla.service.SLAService.LOG from instance method
org.apache.oozie.sla.service.SLAService.init(Services)
At SLAService.java:[line 67]: Write to static field
org.apache.oozie.sla.service.SLAService.calcImpl from instance method
org.apache.oozie.sla.service.SLAService.init(Services)
At SLAService.java:[line 85]: Write to static field
org.apache.oozie.sla.service.SLAService.slaEnabled from instance method
org.apache.oozie.sla.service.SLAService.init(Services)
At SLAService.java:[lines 121-136]: Should
org.apache.oozie.sla.service.SLAService$SLAWorker be a _static_ inner class?
At WorkflowStore.java:[line 91]: Dead store to schema in new
org.apache.oozie.store.WorkflowStore(boolean)
At WorkflowStore.java:[line 378]: Dead store to oq in
org.apache.oozie.store.WorkflowStore$11.call()
At WorkflowStore.java:[line 434]: Dead store to actions in
org.apache.oozie.store.WorkflowStore$13.call()
Dereferenced at WorkflowStore.java:[line 672]: Possible null pointer
dereference of q in org.apache.oozie.store.WorkflowStore$15.call()
Known null at WorkflowStore.java:[line 651]: Null value at
WorkflowStore.java:[line 642]
Dereferenced at WorkflowStore.java:[line 681]: Possible null pointer
dereference of qTotal in org.apache.oozie.store.WorkflowStore$15.call()
Known null at WorkflowStore.java:[line 651]: Null value at
WorkflowStore.java:[line 643]
At AuthUrlClient.java:[line 153]:
org.apache.oozie.util.AuthUrlClient.getQueryParamString(Map) makes inefficient
use of keySet iterator instead of entrySet iterator
At AuthUrlClient.java:[line 135]: Found reliance on default encoding in
org.apache.oozie.util.AuthUrlClient$1.run(): new
java.io.InputStreamReader(InputStream)
At ConfigUtils.java:[line 36]:
org.apache.oozie.util.ConfigUtils.BOOLEAN_DEFAULT isn't final but should be
At ConfigUtils.java:[line 39]:
org.apache.oozie.util.ConfigUtils.FLOAT_DEFAULT isn't final but should be
At ConfigUtils.java:[line 38]:
org.apache.oozie.util.ConfigUtils.INT_DEFAULT isn't final but should be
At ConfigUtils.java:[line 40]:
org.apache.oozie.util.ConfigUtils.LONG_DEFAULT isn't final but should be
At ConfigUtils.java:[line 37]:
org.apache.oozie.util.ConfigUtils.STRING_DEFAULT isn't final but should be
At DateUtils.java:[line 140]: Load of known null value in
org.apache.oozie.util.DateUtils.getTimeZone(String)
Redundant null check at DateUtils.java:[line 177]: Redundant nullcheck of
d, which is known to be non-null in
org.apache.oozie.util.DateUtils.parseDateOozieTZ(String)
At GraphGenerator.java:[line 95]:
org.apache.oozie.util.GraphGenerator.finalize() is public; should be protected
At GraphGenerator.java:[line 62]: Unread field:
org.apache.oozie.util.GraphGenerator.actionsLimit; should this field be static?
At GraphGenerator.java:[lines 160-165]: Switch statement found in
org.apache.oozie.util.GraphGenerator$XMLParser.endDocument() where default case
is missing
At IOUtils.java:[line 119]: Found reliance on default encoding in
org.apache.oozie.util.IOUtils.getResourceAsReader(String, int): new
java.io.InputStreamReader(InputStream)
At IOUtils.java:[line 136]: Found reliance on default encoding in
org.apache.oozie.util.IOUtils.getResourceAsString(String, int): new
java.io.InputStreamReader(InputStream)
Obligation to clean up resource created at IOUtils.java:[line 209] is not
discharged: org.apache.oozie.util.IOUtils.zipDir(File, String, ZipOutputStream,
boolean) may fail to clean up java.io.InputStream on checked exception
Path continues at IOUtils.java:[line 211]: Path continues at
IOUtils.java:[line 210]
At Instrumentation.java:[line 438]: Integral division result cast to double
or float in org.apache.oozie.util.Instrumentation$Timer.evalStdDev(long, long,
long)
At MultiFileReader.java:[line 86]: Found reliance on default encoding in
org.apache.oozie.util.MultiFileReader.openNextReader(): new
java.io.FileReader(File)
At MultiFileReader.java:[line 82]: Found reliance on default encoding in
org.apache.oozie.util.MultiFileReader.openNextReader(): new
java.io.InputStreamReader(InputStream)
At OozieRollingPolicy.java:[line 162]: Exceptional return value of
java.io.File.delete() ignored in
org.apache.oozie.util.OozieRollingPolicy.deleteOldFiles()
At OozieRollingPolicy.java:[lines 203-211]:
org.apache.oozie.util.OozieRollingPolicy$FileInfo defines
compareTo(OozieRollingPolicy$FileInfo) and uses Object.equals()
At OozieRollingPolicy.java:[lines 184-211]: Should
org.apache.oozie.util.OozieRollingPolicy$FileInfo be a _static_ inner class?
At PriorityDelayQueue.java:[line 63]:
org.apache.oozie.util.PriorityDelayQueue$QueueElement defines compareTo(Object)
and uses Object.equals()
At StatusUtils.java:[line 134]: Dead store to conf in
org.apache.oozie.util.StatusUtils.isV1CoordjobKillable(CoordinatorJobBean)
At StringSerializationUtil.java:[line 48]: Load of known null value in
org.apache.oozie.util.StringSerializationUtil.writeString(DataOutput, String)
At XConfiguration.java:[line 368]: Found reliance on default encoding in
org.apache.oozie.util.XConfiguration.toXmlString(boolean): new String(byte[])
At XLogFilter.java:[line 207]:
org.apache.oozie.util.XLogFilter.getEndDate() may expose internal
representation by returning XLogFilter.endDate
At XLogFilter.java:[line 219]:
org.apache.oozie.util.XLogFilter.getStartDate() may expose internal
representation by returning XLogFilter.startDate
At XLogFilter.java:[line 43]:
org.apache.oozie.util.XLogFilter.MAX_ACTIONLIST_SCAN_DURATION isn't final but
should be
At XLogFilter.java:[line 44]:
org.apache.oozie.util.XLogFilter.MAX_SCAN_DURATION isn't final but should be
At XLogStreamer.java:[lines 139-147]:
org.apache.oozie.util.XLogStreamer$FileInfo defines
compareTo(XLogStreamer$FileInfo) and uses Object.equals()
At XLogStreamer.java:[lines 121-147]: Should
org.apache.oozie.util.XLogStreamer$FileInfo be a _static_ inner class?
At XLogUserFilterParam.java:[line 183]:
org.apache.oozie.util.XLogUserFilterParam.getEndDate() may expose internal
representation by returning XLogUserFilterParam.endTime
At XLogUserFilterParam.java:[line 251]:
org.apache.oozie.util.XLogUserFilterParam.getEndTime() may expose internal
representation by returning XLogUserFilterParam.endTime
At XLogUserFilterParam.java:[line 174]:
org.apache.oozie.util.XLogUserFilterParam.getStartDate() may expose internal
representation by returning XLogUserFilterParam.startTime
At XmlUtils.java:[line 284]: Found reliance on default encoding in
org.apache.oozie.util.XmlUtils.validateXml(Schema, String): String.getBytes()
At ZKUtils.java:[line 389]: Should
org.apache.oozie.util.ZKUtils$ZKMetadataKeys be a _static_ inner class?
At SLADbOperations.java:[line 131]: Result of integer multiplication cast
to long in
org.apache.oozie.util.db.SLADbOperations.createSlaRegistrationEvent(Element,
String, SLAEvent$SlaAppType, String, String, XLog)
Result of integer multiplication cast to long in
org.apache.oozie.util.db.SLADbOperations.createSlaRegistrationEvent(Element,
Store, String, SLAEvent$SlaAppType, String, String): Another occurrence at
SLADbOperations.java:[line 148]
Another occurrence at SLADbOperations.java:[line 80]: At
SLADbOperations.java:[line 63]
At SLADbXOperations.java:[line 71]: Result of integer multiplication cast
to long in
org.apache.oozie.util.db.SLADbXOperations.createSlaRegistrationEvent(Element,
String, SLAEvent$SlaAppType, String, String)
Dead store to stmt in
org.apache.oozie.util.db.SqlStatement.prepareForBatch(Connection, List,
PreparedStatement): Another occurrence at SLADbXOperations.java:[line 89]
Possible null pointer dereference of retVal in
org.apache.oozie.util.db.SqlStatement.create(ArrayList): At
SqlStatement.java:[line 897]
Null value at SqlStatement.java:[line 952]: Dereferenced at
SqlStatement.java:[line 971]
org.apache.oozie.util.db.SqlStatement.prepareAndSetValues(Connection) may
fail to clean up java.sql.Statement on checked exception: Known null at
SqlStatement.java:[line 965]
Path continues at SqlStatement.java:[line 843]: Obligation to clean up
resource created at SqlStatement.java:[line 842] is not discharged
Path continues at SqlStatement.java:[line 845]: Path continues at
SqlStatement.java:[line 844]
At SqlStatement.java:[line 116]:
org.apache.oozie.util.db.SqlStatement$ResultSetReader.getByteArray(Schema$Column)
may fail to close stream
In ValidateConnectionBean.java: Unwritten field:
org.apache.oozie.util.db.ValidateConnectionBean.pcPCSuperclass
At LiteWorkflowApp.java:[line 58]:
org.apache.oozie.workflow.lite.LiteWorkflowApp defines equals(LiteWorkflowApp)
method and uses Object.equals(Object)
At LiteWorkflowAppParser.java:[lines 368-413]: Should
org.apache.oozie.workflow.lite.LiteWorkflowAppParser$GlobalSectionData be a
_static_ inner class?
Unsynchronized access at LiteWorkflowInstance.java:[line 543]: Inconsistent
synchronization of org.apache.oozie.workflow.lite.LiteWorkflowInstance.log;
locked 86% of time
Unsynchronized access at LiteWorkflowInstance.java:[line 329]:
Unsynchronized access at LiteWorkflowInstance.java:[line 324]
Synchronized access at LiteWorkflowInstance.java:[line 173]: Synchronized
access at LiteWorkflowInstance.java:[line 472]
Synchronized access at LiteWorkflowInstance.java:[line 190]: Synchronized
access at LiteWorkflowInstance.java:[line 381]
Synchronized access at LiteWorkflowInstance.java:[line 202]: Synchronized
access at LiteWorkflowInstance.java:[line 194]
Synchronized access at LiteWorkflowInstance.java:[line 306]: Synchronized
access at LiteWorkflowInstance.java:[line 299]
Synchronized access at LiteWorkflowInstance.java:[line 252]: Synchronized
access at LiteWorkflowInstance.java:[line 221]
Synchronized access at LiteWorkflowInstance.java:[line 258]: Synchronized
access at LiteWorkflowInstance.java:[line 255]
Synchronized access at LiteWorkflowInstance.java:[line 449]: Synchronized
access at LiteWorkflowInstance.java:[line 265]
Synchronized access at LiteWorkflowInstance.java:[line 357]: Synchronized
access at LiteWorkflowInstance.java:[line 493]
Synchronized access at LiteWorkflowInstance.java:[line 341]: Synchronized
access at LiteWorkflowInstance.java:[line 360]
Synchronized access at LiteWorkflowInstance.java:[line 369]: Synchronized
access at LiteWorkflowInstance.java:[line 348]
Unsynchronized access at LiteWorkflowInstance.java:[line 568]: Inconsistent
synchronization of org.apache.oozie.workflow.lite.LiteWorkflowInstance.status;
locked 81% of time
Unsynchronized access at LiteWorkflowInstance.java:[line 551]:
Unsynchronized access at LiteWorkflowInstance.java:[line 547]
Unsynchronized access at LiteWorkflowInstance.java:[line 374]:
Unsynchronized access at LiteWorkflowInstance.java:[line 595]
Synchronized access at LiteWorkflowInstance.java:[line 170]: Unsynchronized
access at LiteWorkflowInstance.java:[line 427]
Synchronized access at LiteWorkflowInstance.java:[line 378]: Synchronized
access at LiteWorkflowInstance.java:[line 174]
Synchronized access at LiteWorkflowInstance.java:[line 185]: Synchronized
access at LiteWorkflowInstance.java:[line 382]
Synchronized access at LiteWorkflowInstance.java:[line 193]: Synchronized
access at LiteWorkflowInstance.java:[line 198]
Synchronized access at LiteWorkflowInstance.java:[line 296]: Synchronized
access at LiteWorkflowInstance.java:[line 206]
Synchronized access at LiteWorkflowInstance.java:[line 312]: Synchronized
access at LiteWorkflowInstance.java:[line 201]
Synchronized access at LiteWorkflowInstance.java:[line 298]: Synchronized
access at LiteWorkflowInstance.java:[line 297]
Synchronized access at LiteWorkflowInstance.java:[line 246]: Synchronized
access at LiteWorkflowInstance.java:[line 218]
Synchronized access at LiteWorkflowInstance.java:[line 306]: Synchronized
access at LiteWorkflowInstance.java:[line 299]
Synchronized access at LiteWorkflowInstance.java:[line 221]: Synchronized
access at LiteWorkflowInstance.java:[line 251]
Synchronized access at LiteWorkflowInstance.java:[line 257]: Synchronized
access at LiteWorkflowInstance.java:[line 254]
Synchronized access at LiteWorkflowInstance.java:[line 362]: Synchronized
access at LiteWorkflowInstance.java:[line 354]
Synchronized access at LiteWorkflowInstance.java:[line 350]: Synchronized
access at LiteWorkflowInstance.java:[line 336]
Synchronized access at LiteWorkflowInstance.java:[line 370]: Synchronized
access at LiteWorkflowInstance.java:[line 366]
At LiteWorkflowValidator.java:[lines 347-349]: Should
org.apache.oozie.workflow.lite.LiteWorkflowValidator$ForkJoinCount be a
_static_ inner class?
At NodeDef.java:[line 81]: org.apache.oozie.workflow.lite.NodeDef defines
equals(NodeDef) method and uses Object.equals(Object)
+1 There are no new bugs found in [core].
+1 There are no new bugs found in [docs].
-1 There are [19] new bugs found below threshold in
[hadooplibs/hadoop-utils-2] that must be fixed.
You can find the FindBugs diff here (look for the red and orange ones):
hadooplibs/hadoop-utils-2/findbugs-new.html
The most important FindBugs errors are:
At LauncherMain.java:[line 73]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMain.getHadoopJobIds(String, Pattern[]):
new java.io.FileReader(String)
At LauncherMain.java:[line 109]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMain.writeExternalChildIDs(String,
Pattern[], String): String.getBytes()
At LauncherMain.java:[line 59]:
org.apache.oozie.action.hadoop.LauncherMain.HADOOP_SITE_FILES should be both
final and package protected
At LauncherMain.java:[line 276]: Exceptional return value of
java.io.File.mkdirs() ignored in
org.apache.oozie.action.hadoop.LauncherMain.writeHadoopConfig(String, File)
At LauncherMapper.java:[line 407]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File,
String, int): new java.io.FileReader(File)
At LauncherMapper.java:[line 355]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new
java.io.FileWriter(String)
At LauncherMapper.java:[line 356]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new
java.io.OutputStreamWriter(OutputStream)
At LauncherMapper.java:[line 105]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration,
Path, String): new java.io.InputStreamReader(InputStream)
At LauncherMapper.java:[line 95]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration,
Path, String): new java.io.OutputStreamWriter(OutputStream)
Obligation to clean up resource created at LauncherMapper.java:[line 407]
is not discharged:
org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File,
String, int) may fail to clean up java.io.Reader on checked exception
Path continues at LauncherMapper.java:[line 410]: Path continues at
LauncherMapper.java:[line 408]
org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf() may
fail to clean up java.io.Writer on checked exception: Path continues at
LauncherMapper.java:[line 411]
Write to static field
org.apache.oozie.action.hadoop.LauncherSecurityManager.exitCode from instance
method org.apache.oozie.action.hadoop.LauncherSecurityManager.checkExit(int):
Obligation to clean up resource created at LauncherMapper.java:[line 355] is
not discharged
Write to static field
org.apache.oozie.action.hadoop.LauncherSecurityManager.exitInvoked from
instance method
org.apache.oozie.action.hadoop.LauncherSecurityManager.checkExit(int): At
LauncherMapper.java:[line 679]
Found reliance on default encoding in
org.apache.oozie.action.hadoop.MapReduceMain.writeJobIdFile(File, String):
String.getBytes(): At LauncherMapper.java:[line 678]
org.apache.oozie.action.hadoop.MapReduceMain.writeJobIdFile(File, String)
may fail to clean up java.io.OutputStream on checked exception: At
MapReduceMain.java:[line 85]
Path continues at MapReduceMain.java:[line 85]: Obligation to clean up
resource created at MapReduceMain.java:[line 84] is not discharged
At ShellMain.java:[line 228]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.ShellMain.handleShellOutput(Process, boolean):
new java.io.InputStreamReader(InputStream)
Found reliance on default encoding in
org.apache.oozie.action.hadoop.ShellMain.writeLoggerProperties(Configuration,
File): new java.io.PrintWriter(OutputStream): Another occurrence at
ShellMain.java:[line 229]
Found reliance on default encoding in
org.apache.oozie.action.hadoop.ShellMain$OutputWriteThread.run(): new
java.io.FileWriter(File): At ShellMain.java:[line 172]
Should org.apache.oozie.action.hadoop.ShellMain$OutputWriteThread be a
_static_ inner class?: At ShellMain.java:[line 265]
At ShellMain.java:[lines 247-305]
+1 There are no new bugs found in [tools].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 1909
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
-1 Overall result, please check the reported -1(s)
The full output of the test-patch run is available at
https://builds.apache.org/job/oozie-trunk-precommit-build/3720/
Adding comment to JIRA
Comment added.
test-patch exit code: 1
Build step 'Execute shell' marked build as failure
Archiving artifacts
Compressed 1.33 MB of artifacts by 11.8% relative to #3715
Recording test results
