----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/#review170838 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java Lines 81 (patched) <https://reviews.apache.org/r/57870/#comment243714> Are we sure that the default, uninitialized instance is good enough? So let's say we store the empty bean as a placeholder. How will that be returned to the user? As I can see, status will be PREP, wfId is null, id is null, everything else is pretty much null. Is this sufficient for us? Won't that be misleading? core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java Lines 82 (patched) <https://reviews.apache.org/r/57870/#comment243712> In this case please return null instead of creating a new bean and handle the null case on the caller side. core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java Lines 63 (patched) <https://reviews.apache.org/r/57870/#comment243711> Is it possible to refactor the test so that they run as a single testcase? core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 262 (patched) <https://reviews.apache.org/r/57870/#comment243708> How much overhead does this test have if we run all subtests as a separate testcase? Having them separately would be much better. - Peter Bacsko On ápr. 1, 2017, 11:31 de, Alonzo Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57870/ > ----------------------------------------------------------- > > (Updated ápr. 1, 2017, 11:31 de) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > More detailed view of the coordinator’s history can be observed from > perspective of workflow action. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 8ddb1f8 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 > core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 > > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java > 0b7f50d > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a > > core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 4fc8653 > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 > > > Diff: https://reviews.apache.org/r/57870/diff/4/ > > > Testing > ------- > > > Thanks, > > Alonzo Zhou > >