----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54383/#review174067 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java Lines 92 (patched) <https://reviews.apache.org/r/54383/#comment247169> This will cause an NPE if someone tries to use this. It would be nicer to return something like an empty string. (That's also more consistent with getHeaderNames(), which returns an empty iterator). core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java Lines 461-464 (patched) <https://reviews.apache.org/r/54383/#comment247170> Can you move this higher up near the other related methods (e.g. getHeader(), getHeaderNames(), etc). Also, why does this one throw an UnsupportedOperationException when the others don't? core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java Lines 47 (patched) <https://reviews.apache.org/r/54383/#comment247171> Can you add a method to LocalOozie for creating a LocalOozieClientBundle? If you look at https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/local/LocalOozie.java, you can see there are some methods for creating the WF and Coord local clients, but we need to add some for this new bundle local client. Also please update any Javadocs in LocalOozie that might be out of date. There's a lot of lists of NOP methods. - Robert Kanter On April 24, 2017, 1:22 p.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54383/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 1:22 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2751 > https://issues.apache.org/jira/browse/OOZIE-2751 > > > Repository: oozie-git > > > Description > ------- > > LocalOozieClient is missing methods from OozieClient > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java 7370808 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > f477531 > core/src/main/java/org/apache/oozie/BaseEngine.java 2780ec2 > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java PRE-CREATION > core/src/main/java/org/apache/oozie/LocalOozieClient.java f734f76 > core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java > PRE-CREATION > core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 32b0cd0 > core/src/main/java/org/apache/oozie/OozieClientOperationHandler.java > PRE-CREATION > core/src/main/java/org/apache/oozie/OozieJsonFactory.java PRE-CREATION > core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java 2c79ef0 > core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java 80c8ec4 > core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 4decd52 > > > Diff: https://reviews.apache.org/r/54383/diff/7/ > > > Testing > ------- > > > Thanks, > > Abhishek Bafna > >
