----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59635/#review176305 -----------------------------------------------------------
sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsBuilder.java Lines 48 (patched) <https://reviews.apache.org/r/59635/#comment249702> I don't see this option in any of the test cases, please add one. sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsBuilder.java Lines 202 (patched) <https://reviews.apache.org/r/59635/#comment249703> --conf screams for a constant :) sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsBuilder.java Lines 249 (patched) <https://reviews.apache.org/r/59635/#comment249704> There is a constant for this sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsBuilder.java Lines 257 (patched) <https://reviews.apache.org/r/59635/#comment249705> there is a constant for this sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java Line 386 (original), 189 (patched) <https://reviews.apache.org/r/59635/#comment249707> I know it's unrelated, but please change "distcpConf" to "actionConf" or something similar. It's probably copy-paste code, but we'll consolidate it later sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java Line 586 (original), 315 (patched) <https://reviews.apache.org/r/59635/#comment249706> If it does not cause big turmoil, please put this class to it's own file. - Peter Cseh On May 30, 2017, 8:50 a.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59635/ > ----------------------------------------------------------- > > (Updated May 30, 2017, 8:50 a.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2923 Improve Spark options parsing > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsBuilder.java > PRE-CREATION > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java > 68f7a607344ac8b3c11ab08220f27139433a998e > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java > PRE-CREATION > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsBuilder.java > PRE-CREATION > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java > 5f6a0cdcde21287580f6b7037594669b508d24ef > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkOptionsSplitter.java > 31f53acca24d1dd645e32a37b58643b7a0a3cacd > > > Diff: https://reviews.apache.org/r/59635/diff/1/ > > > Testing > ------- > > Please see the JUnit tests `TestSparkMain`, `TestSparkOptionsSplitter`, and > `TestSparkArgsBuilder` for test cases. > > > Thanks, > > András Piros > >
