[
https://issues.apache.org/jira/browse/OOZIE-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artem Ervits updated OOZIE-2902:
--------------------------------
Attachment: OOZIE-2902-1.patch
[~pbacsko] please review. Do you think refactoring the following code makes
sense?
{noformat}
private void testTimeLineServiceIsDisabled(JobConf launcherConf) {
if (HadoopShims.isYARN()) {
assertFalse(launcherConf.getBoolean(JavaActionExecutor.HADOOP_YARN_TIMELINE_SERVICE_ENABLED,
false));
} else {
assertNull(launcherConf.get(JavaActionExecutor.HADOOP_YARN_TIMELINE_SERVICE_ENABLED));
}
}
{noformat}
If it does, do you think changing method signature to pass a boolean and making
it more generic would make even more sense? So instead of assertFalse, I can
have the old way assertEquals. Nevertheless, I switched all of the assert
statements to match rather having a mix of assertEquals and assertTrue.
> org.apache.oozie.action.hadoop.TestJavaActionExecutor fails after hadoop 2.6
> upgrade
> ------------------------------------------------------------------------------------
>
> Key: OOZIE-2902
> URL: https://issues.apache.org/jira/browse/OOZIE-2902
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 4.3.0
> Reporter: Artem Ervits
> Assignee: Artem Ervits
> Priority: Blocker
> Fix For: 5.0.0
>
> Attachments: OOZIE-2902-0.patch, OOZIE-2902-1.patch
>
>
> after https://issues.apache.org/jira/browse/OOZIE-2780 jira,
> {code}TestJavaActionExecutor{code} fails with
> {noformat}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
> support was removed in 8.0
> Concurrency config is parallel='classes', perCoreThreadCount=false,
> threadCount=1, useUnlimitedThreads=false
> objc[81957]: Class JavaLaunchHelper is implemented in both
> /Library/Java/JavaVirtualMachines/jdk1.8.0_51.jdk/Contents/Home/jre/bin/java
> (0x107ee74c0) and
> /Library/Java/JavaVirtualMachines/jdk1.8.0_51.jdk/Contents/Home/jre/lib/libinstrument.dylib
> (0x1112e84e0). One of the two will be used. Which one is undefined.
> Running org.apache.oozie.action.hadoop.TestJavaActionExecutor
> Tests run: 49, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 210.336 sec
> <<< FAILURE!
> Results :
> Failed tests:
> testUpdateConfForTimeLineServiceEnabled(org.apache.oozie.action.hadoop.TestJavaActionExecutor):
> expected:<[tru]e> but was:<[fals]e>
> Tests run: 49, Failures: 1, Errors: 0, Skipped: 0
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Oozie Main .................................. SUCCESS [ 0.487
> s]
> [INFO] Apache Oozie Hadoop Utils hadoop-2-4.4.0-SNAPSHOT .. SUCCESS [ 2.005
> s]
> [INFO] Apache Oozie Hadoop Distcp hadoop-2-4.4.0-SNAPSHOT . SUCCESS [ 0.073
> s]
> [INFO] Apache Oozie Hadoop Auth hadoop-2-4.4.0-SNAPSHOT Test SUCCESS [ 0.271
> s]
> [INFO] Apache Oozie Hadoop Libs ........................... SUCCESS [ 0.015
> s]
> [INFO] Apache Oozie Client ................................ SUCCESS [ 2.365
> s]
> [INFO] Apache Oozie Share Lib Oozie ....................... SUCCESS [ 2.465
> s]
> [INFO] Apache Oozie Share Lib HCatalog .................... SUCCESS [ 1.812
> s]
> [INFO] Apache Oozie Share Lib Distcp ...................... SUCCESS [ 0.535
> s]
> [INFO] Apache Oozie Core .................................. FAILURE [03:52
> min]
> [INFO] Apache Oozie Share Lib Streaming ................... SKIPPED
> [INFO] Apache Oozie Share Lib Pig ......................... SKIPPED
> [INFO] Apache Oozie Share Lib Hive ........................ SKIPPED
> [INFO] Apache Oozie Share Lib Hive 2 ...................... SKIPPED
> [INFO] Apache Oozie Share Lib Sqoop ....................... SKIPPED
> [INFO] Apache Oozie Examples .............................. SKIPPED
> [INFO] Apache Oozie Share Lib Spark ....................... SKIPPED
> [INFO] Apache Oozie Share Lib ............................. SKIPPED
> [INFO] Apache Oozie Docs .................................. SKIPPED
> [INFO] Apache Oozie WebApp ................................ SKIPPED
> [INFO] Apache Oozie Tools ................................. SKIPPED
> [INFO] Apache Oozie MiniOozie ............................. SKIPPED
> [INFO] Apache Oozie Server ................................ SKIPPED
> [INFO] Apache Oozie Distro ................................ SKIPPED
> [INFO] Apache Oozie ZooKeeper Security Tests .............. SKIPPED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 04:03 min
> [INFO] Finished at: 2017-05-15T09:38:23-04:00
> [INFO] Final Memory: 150M/443M
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
