----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59906/#review177591 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java Lines 863 (patched) <https://reviews.apache.org/r/59906/#comment251280> You can move that within the `try` block to minimize variable scope. core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java Lines 869-872 (patched) <https://reviews.apache.org/r/59906/#comment251279> This is quite suspicious here, to catch any and all `Exception` instances... can you be please much more specific? core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java Lines 741 (patched) <https://reviews.apache.org/r/59906/#comment251281> It would be nicer to have a separate test case just for testing the new behavior. - András Piros On June 8, 2017, 4:01 a.m., Wen Chi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59906/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 4:01 a.m.) > > > Review request for oozie and András Piros. > > > Bugs: OOZIE-2929 > https://issues.apache.org/jira/browse/OOZIE-2929 > > > Repository: oozie-git > > > Description > ------- > > 1. coordinator.xml define SLA like this > ```xml > <sla:info> > <sla:nominal-time>${nominal_time}</sla:nominal-time> > <sla:should-end>${ 1 * HOURS}</sla:should-end> > <sla:max-duration>${1 * MINUTES}</sla:max-duration> > </sla:info> > ``` > 2. In job.properties define: **nominal_time=${coord:nominalTime()}** > 3. Then coordinator will run failed > > "Coord Job Materialization Error: Could not parse [${coord:nominalTime()}] > > using [yyyy-MM-dd'T'HH:mm+0800] mask"; > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 969336d2 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > dcc97ad0 > > > Diff: https://reviews.apache.org/r/59906/diff/1/ > > > Testing > ------- > > > Thanks, > > Wen Chi > >
