[ 
https://issues.apache.org/jira/browse/OOZIE-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055671#comment-16055671
 ] 

Peter Bacsko commented on OOZIE-2910:
-------------------------------------

1. {{yarnClient.killApplication(ConverterUtils.toApplicationId(childId));}} - 
can't this throw an exception? Shall we handle it?

2. What about trimming {{childId}} here? Just to be safe:

{noformat}
for(String childId : externalChildIDs.split(",")) {
     yarnClient.killApplication(ConverterUtils.toApplicationId(childId));
}
{noformat}

> Re-add testChildKill and adapt it to OYA
> ----------------------------------------
>
>                 Key: OOZIE-2910
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2910
>             Project: Oozie
>          Issue Type: Sub-task
>            Reporter: Peter Bacsko
>            Assignee: Peter Cseh
>         Attachments: OOZIE-2910-001.patch, OOZIE-2910-002.patch, 
> OOZIE-2910-003.patch
>
>
> Removed by OOZIE-1770: [link to the original 
> code|https://github.com/apache/oozie/blob/e0b7cde711b1b9e1a03660ec635041eeb9755049/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java#L546]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to