[
https://issues.apache.org/jira/browse/OOZIE-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064653#comment-16064653
]
Hadoop QA commented on OOZIE-2956:
----------------------------------
Testing JIRA OOZIE-2956
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
. {color:red}WARNING{color}: the current HEAD has 1 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1968
. Tests failed: 0
. Tests errors: 63
. The patch failed the following testcases:
.
. Tests failing with errors:
.
testAuthorizationServiceForBundle(org.apache.oozie.service.TestAuthorizationService)
.
testAdminUsersWithAdminFile(org.apache.oozie.service.TestAuthorizationService)
.
testAdminUsersWithAdminGroup(org.apache.oozie.service.TestAuthorizationService)
.
testAuthorizationServiceForCoord(org.apache.oozie.service.TestAuthorizationService)
.
testAuthorizationServiceUseDefaultGroup(org.apache.oozie.service.TestAuthorizationService)
. testDefaultGroup(org.apache.oozie.service.TestAuthorizationService)
. testErrors(org.apache.oozie.service.TestAuthorizationService)
.
testAuthorizationServiceUseACLs(org.apache.oozie.service.TestAuthorizationService)
. testRerunFork(org.apache.oozie.command.wf.TestReRunXCommand)
.
testPurgeMissingDependencies(org.apache.oozie.service.TestHAPartitionDependencyManagerEhCache)
.
testDependencyCacheWithHA(org.apache.oozie.service.TestHAPartitionDependencyManagerEhCache)
.
testCheckAfterActionDelete(org.apache.oozie.service.TestHAPartitionDependencyManagerEhCache)
.
testActionInputCheckLatestActionCreationTimeWithPushDependency(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC)
.
testActionInputCheckLatestCurrentTimeWithPushDependency(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC)
.
testHCatCanonicalHostName(org.apache.oozie.service.TestPartitionDependencyManagerService)
.
testActionCheckerService(org.apache.oozie.service.TestActionCheckerService)
.
testActionCheckerServiceCoord(org.apache.oozie.service.TestActionCheckerService)
.
testActionCheckerServiceDelay(org.apache.oozie.service.TestActionCheckerService)
. testEndError(org.apache.oozie.command.wf.TestActionErrors)
.
testStartNonTransientWithCoordActionUpdate(org.apache.oozie.command.wf.TestActionErrors)
.
testKillNodeErrorMessageError(org.apache.oozie.command.wf.TestActionErrors)
. testEndDataNotSet(org.apache.oozie.command.wf.TestActionErrors)
. testStartErrorWithUserRetry(org.apache.oozie.command.wf.TestActionErrors)
.
testKillNodeErrorMessageError2(org.apache.oozie.command.wf.TestActionErrors)
. testStartTransient(org.apache.oozie.command.wf.TestActionErrors)
. testKillNodeErrorMessage(org.apache.oozie.command.wf.TestActionErrors)
. testStartNonTransient(org.apache.oozie.command.wf.TestActionErrors)
. testEndNonTransient(org.apache.oozie.command.wf.TestActionErrors)
. testExecutionDataNotSet(org.apache.oozie.command.wf.TestActionErrors)
. testEndErrorWithUserRetry(org.apache.oozie.command.wf.TestActionErrors)
.
testEndNonTransientWithCoordActionUpdate(org.apache.oozie.command.wf.TestActionErrors)
. testEndTransient(org.apache.oozie.command.wf.TestActionErrors)
. testStartError(org.apache.oozie.command.wf.TestActionErrors)
.
testActionInputCheckLatestActionCreationTimeWithPushDependency(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommand)
.
testActionInputCheckLatestCurrentTimeWithPushDependency(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommand)
.
testPurgeMissingDependencies(org.apache.oozie.service.TestHAPartitionDependencyManagerService)
.
testDependencyCacheWithHA(org.apache.oozie.service.TestHAPartitionDependencyManagerService)
.
testCheckAfterActionDelete(org.apache.oozie.service.TestHAPartitionDependencyManagerService)
.
testRetryConsoleUrl(org.apache.oozie.command.wf.TestWorkflowActionRetryInfoXCommand)
.
testActionCheckErrorUserRetry(org.apache.oozie.command.wf.TestActionCheckXCommand)
.
testActionCheckErrorNoUserRetry(org.apache.oozie.command.wf.TestActionCheckXCommand)
. testWfFailure(org.apache.oozie.command.wf.TestForkedActionStartXCommand)
. testWfSuccess(org.apache.oozie.command.wf.TestForkedActionStartXCommand)
.
testCoordActionRecoveryServiceForSuspended(org.apache.oozie.service.TestRecoveryService)
.
testCoordCreateNotifyParentFailed(org.apache.oozie.service.TestRecoveryService)
.
testWorkflowActionRecoveryService(org.apache.oozie.service.TestRecoveryService)
.
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
.
testBundleRecoveryCoordCreate(org.apache.oozie.service.TestRecoveryService)
.
testCoordActionRecoveryServiceForKilled(org.apache.oozie.service.TestRecoveryService)
.
testBundleRecoveryCoordExists(org.apache.oozie.service.TestRecoveryService)
.
testCoordActionRecoveryServiceForResume(org.apache.oozie.service.TestRecoveryService)
.
testCoordActionRecoveryServiceForSubmitted(org.apache.oozie.service.TestRecoveryService)
.
testCoordActionRecoveryServiceForWaiting(org.apache.oozie.service.TestRecoveryService)
.
testWorkflowActionRecoveryUserRetry(org.apache.oozie.service.TestRecoveryService)
. testPurgeServiceForBundle(org.apache.oozie.service.TestPurgeService)
. testPurgeServiceForCoordinator(org.apache.oozie.service.TestPurgeService)
. testPurgeServiceForWorkflow(org.apache.oozie.service.TestPurgeService)
. testJobDefinition(org.apache.oozie.TestDagEngine)
. testGetJobs(org.apache.oozie.TestDagEngine)
. testSubmit(org.apache.oozie.TestDagEngine)
.
testHCatCanonicalHostName(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
. testUserRetryPolicy(org.apache.oozie.command.wf.TestActionUserRetry)
. testUserRetry(org.apache.oozie.command.wf.TestActionUserRetry)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3926/
> Fix Findbugs warnings related to reliance on default encoding in oozie-core
> ---------------------------------------------------------------------------
>
> Key: OOZIE-2956
> URL: https://issues.apache.org/jira/browse/OOZIE-2956
> Project: Oozie
> Issue Type: Sub-task
> Components: build, core
> Reporter: Jan Hentschel
> Assignee: Jan Hentschel
> Attachments: OOZIE-2956-1.patch
>
>
> Currently Findbugs complains about the following warnings related to the
> reliance on the default encoding in the *oozie-core* module:
> {code}
> [INFO] Found reliance on default encoding in
> org.apache.oozie.StringBlob.getRawBlob(): String.getBytes()
> [org.apache.oozie.StringBlob] At StringBlob.java:[line 119]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.ActionExecutor.registerError(String,
> ActionExecutorException$ErrorType, String):
> java.io.ByteArrayOutputStream.toString()
> [org.apache.oozie.action.ActionExecutor] At ActionExecutor.java:[line 354]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.ActionExecutor.registerError(String,
> ActionExecutorException$ErrorType, String): new
> java.io.PrintStream(OutputStream) [org.apache.oozie.action.ActionExecutor] At
> ActionExecutor.java:[line 353]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.LauncherHelper.getRecoveryId(Configuration,
> Path, String): new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.action.hadoop.LauncherHelper] At LauncherHelper.java:[line
> 69]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.LauncherHelper.getTag(String):
> String.getBytes() [org.apache.oozie.action.hadoop.LauncherHelper] At
> LauncherHelper.java:[line 160]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.LauncherHelper$1.run(): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.action.hadoop.LauncherHelper$1,
> org.apache.oozie.action.hadoop.LauncherHelper$1,
> org.apache.oozie.action.hadoop.LauncherHelper$1,
> org.apache.oozie.action.hadoop.LauncherHelper$1,
> org.apache.oozie.action.hadoop.LauncherHelper$1] At LauncherHelper.java:[line
> 271]Another occurrence at LauncherHelper.java:[line 277]Another occurrence at
> LauncherHelper.java:[line 285]Another occurrence at LauncherHelper.java:[line
> 293]Another occurrence at LauncherHelper.java:[line 299]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.MapReduceActionExecutor.end(ActionExecutor$Context,
> WorkflowAction): String.getBytes()
> [org.apache.oozie.action.hadoop.MapReduceActionExecutor] At
> MapReduceActionExecutor.java:[line 250]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.hadoop.SqoopActionExecutor.end(ActionExecutor$Context,
> WorkflowAction): String.getBytes()
> [org.apache.oozie.action.hadoop.SqoopActionExecutor] At
> SqoopActionExecutor.java:[line 186]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.ssh.SshActionExecutor.drainBuffers(Process,
> StringBuffer, StringBuffer, int): new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.action.ssh.SshActionExecutor,
> org.apache.oozie.action.ssh.SshActionExecutor] At
> SshActionExecutor.java:[line 684]Another occurrence at
> SshActionExecutor.java:[line 685]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.action.ssh.SshActionExecutor.initSshScripts(): new
> java.io.FileWriter(String) [org.apache.oozie.action.ssh.SshActionExecutor,
> org.apache.oozie.action.ssh.SshActionExecutor] At
> SshActionExecutor.java:[line 502]Another occurrence at
> SshActionExecutor.java:[line 504]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.command.bundle.BundleSubmitXCommand.readDefinition(String):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.command.bundle.BundleSubmitXCommand] At
> BundleSubmitXCommand.java:[line 322]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.command.coord.CoordSubmitXCommand.readDefinition(String):
> new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.command.coord.CoordSubmitXCommand] At
> CoordSubmitXCommand.java:[line 1193]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String,
> String): java.io.ByteArrayOutputStream.toString()
> [org.apache.oozie.command.coord.CoordUpdateXCommand] At
> CoordUpdateXCommand.java:[line 203]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.command.coord.CoordUpdateXCommand.getDiffinGitFormat(String,
> String): String.getBytes()
> [org.apache.oozie.command.coord.CoordUpdateXCommand,
> org.apache.oozie.command.coord.CoordUpdateXCommand] At
> CoordUpdateXCommand.java:[line 198]Another occurrence at
> CoordUpdateXCommand.java:[line 199]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.service.AuthorizationService.loadAdminUsers(): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.service.AuthorizationService] At
> AuthorizationService.java:[line 172]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.service.WorkflowAppService.readDefinition(String, String,
> Configuration): new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.service.WorkflowAppService] At
> WorkflowAppService.java:[line 132]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.servlet.V1JobServlet.getJob(HttpServletRequest,
> HttpServletResponse): new String(byte[])
> [org.apache.oozie.servlet.V1JobServlet] At V1JobServlet.java:[line 223]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.servlet.V2ValidateServlet.doPost(HttpServletRequest,
> HttpServletResponse): new java.io.InputStreamReader(InputStream)
> [org.apache.oozie.servlet.V2ValidateServlet,
> org.apache.oozie.servlet.V2ValidateServlet] At V2ValidateServlet.java:[line
> 84]Another occurrence at V2ValidateServlet.java:[line 92]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.AuthUrlClient$1.run(): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.util.AuthUrlClient$1] At AuthUrlClient.java:[line 136]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.IOUtils.getResourceAsReader(String, int): new
> java.io.InputStreamReader(InputStream) [org.apache.oozie.util.IOUtils] At
> IOUtils.java:[line 119]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.IOUtils.getResourceAsString(String, int): new
> java.io.InputStreamReader(InputStream) [org.apache.oozie.util.IOUtils] At
> IOUtils.java:[line 136]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.MultiFileReader.openNextReader(): new
> java.io.FileReader(File) [org.apache.oozie.util.MultiFileReader] At
> MultiFileReader.java:[line 86]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.MultiFileReader.openNextReader(): new
> java.io.InputStreamReader(InputStream)
> [org.apache.oozie.util.MultiFileReader] At MultiFileReader.java:[line 82]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.XConfiguration.toXmlString(boolean): new String(byte[])
> [org.apache.oozie.util.XConfiguration] At XConfiguration.java:[line 368]
> [INFO] Found reliance on default encoding in
> org.apache.oozie.util.XmlUtils.validateXml(Schema, String): String.getBytes()
> [org.apache.oozie.util.XmlUtils] At XmlUtils.java:[line 284]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
