----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61142/#review181793 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/db/PersistenceExceptionSubclassFilterRetryPredicate.java Lines 59 (patched) <https://reviews.apache.org/r/61142/#comment257545> Could you please rename it and ``CAUSE_BLACKLIST`` so that they better resolve their purpose? As I understand we examine exceptions without a cause in case of ``ROOT_BLACKLIST``. - Attila Sasvari On July 26, 2017, 5:28 p.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61142/ > ----------------------------------------------------------- > > (Updated July 26, 2017, 5:28 p.m.) > > > Review request for oozie, Attila Sasvari and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3009 Number of Oozie tests executed dropped > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/JPAService.java > 93fe9da1564b734831e7b988ffe760f808af49fa > core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1b8370f01e5097300ee20e903ac745c23c999ce3 > > core/src/main/java/org/apache/oozie/util/db/PersistenceExceptionSubclassFilterRetryPredicate.java > b742ca78520bdea804234460c36925beb105c5cb > > core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java > 9077970fb11e10f158b1b742e6abbf4d056f92a8 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteJPAExecutor.java > c7e0c38426d08c824b373409a9860a420e158821 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java > bff5836f209e1ec43de1b32203689909591896b7 > > core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java > c4ca61bf0ce678ae6bd0f6309a586f287e05537c > core/src/test/java/org/apache/oozie/service/TestConfigurationService.java > 4cb2530cae634517ab833676b68deba068c7560b > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 34011f6b6f7f7ee4c57d63a1e62af4acb0fe32ba > core/src/test/java/org/apache/oozie/test/XTestCase.java > 0ef4a4be6998744914e2ab56697cc2ae517070b9 > > core/src/test/java/org/apache/oozie/util/db/TestPersistenceExceptionSubclassFilterRetryPredicate.java > 76d2edc0e538732e65556d9255f49d4d1c0980b7 > > > Diff: https://reviews.apache.org/r/61142/diff/1/ > > > Testing > ------- > > Following test cases have been executed: > ``` > TestOperationRetryHandler > TestPersistenceExceptionSubclassFilterRetryPredicate > TestParallelJPAOperationRetries > TestWorkflow > TestWorkflowRetries > TestJPAService > TestRetryAttemptState > TestSLACalculatorMemory > TestWorkflowJobsDeleteJPAExecutor > TestPurgeService > TestCoordJobsDeleteJPAExecutor > TestBundleJobsDeleteJPAExecutor > TestPurgeXCommand > ``` > > > Thanks, > > András Piros > >
