[ https://issues.apache.org/jira/browse/OOZIE-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108889#comment-16108889 ]
Hadoop QA commented on OOZIE-3001: ---------------------------------- Testing JIRA OOZIE-3001 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings . {color:red}WARNING{color}: the current HEAD has 78 Javadoc warning(s) {color:red}-1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:red}-1{color} patch does not compile . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [73] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:red}-1{color} There are [8] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The top [5] most important FindBugs errors are: . At DateList.java:[line 55]: Nullcheck of date at line 55 of value previously dereferenced in org.apache.oozie.example.DateList.main(String[]) . Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called: Redundant null check at DateList.java:[line 62] . org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to clean up java.io.InputStream: At DateList.java:[line 97] . Path continues at LocalOozieExample.java:[line 76]: Obligation to clean up resource created at LocalOozieExample.java:[line 72] is not discharged . Path continues at LocalOozieExample.java:[line 78]: Path continues at LocalOozieExample.java:[line 77] . {color:red}-1{color} There are [65] new bugs found below threshold in [examples] that must be fixed, listing only the first [5] ones. . You can find the FindBugs diff here (look for the red and orange ones): examples/findbugs-new.html . The top [5] most important FindBugs errors are: . At OozieDBCLI.java:[line 548]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInMysql(String, Connection): new java.io.FileWriter(String, boolean) . At OozieDBCLI.java:[line 577]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInPostgres(String, Connection, String): new java.io.FileWriter(String, boolean) . At OozieDBCLI.java:[line 983]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.createOozieSysTable(String, boolean, String): new java.io.FileWriter(String, boolean) . At OozieDBCLI.java:[line 759]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.ddlTweaks(String, boolean): new java.io.FileWriter(String, boolean) . At OozieDBCLI.java:[line 712]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.ddlTweaksFor50(String, boolean, String): new java.io.FileWriter(String, boolean) {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} - patch does not compile, cannot run testcases {color:red}-1 DISTRO{color} . {color:red}-1{color} distro tarball fails with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/4014/ > core library has many instances of warnings with trailing spaces and lines > longer than 132 chars > ------------------------------------------------------------------------------------------------ > > Key: OOZIE-3001 > URL: https://issues.apache.org/jira/browse/OOZIE-3001 > Project: Oozie > Issue Type: Sub-task > Affects Versions: 4.3.0 > Reporter: Artem Ervits > Assignee: Artem Ervits > Labels: newbie > Fix For: 5.0.0 > > > {noformat} > /Users/aervits/NetBeansProjects/minioozie/oozie/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java:219: > warning: Line is longer than 132 characters. > /Users/aervits/NetBeansProjects/minioozie/oozie/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java:297: > warning: Line is longer than 132 characters. > /Users/aervits/NetBeansProjects/minioozie/oozie/core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java:40: > warning: Line is longer than 132 characters. > /Users/aervits/NetBeansProjects/minioozie/oozie/core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java:45: > warning: Line is longer than 132 characters. > /Users/aervits/NetBeansProjects/minioozie/oozie/core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java:35: > warning: Line is longer than 132 characters. > /Users/aervits/NetBeansProjects/minioozie/oozie/core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java:51: > warning: Line is longer than 132 characters. > /Users/aervits/NetBeansProjects/minioozie/oozie/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java:643: > warning: Line is longer than 132 characters. > /Users/aervits/NetBeansProjects/minioozie/oozie/core/src/main/java/org/apache/oozie/BundleActionBean.java:46: > warning: Line is longer than 132 characters. > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)