----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61529/#review184650 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java Lines 2268 (patched) <https://reviews.apache.org/r/61529/#comment260833> Have you considered creating new tests? Is this coverage enough? core/src/test/java/org/apache/oozie/service/TestSchemaService.java Lines 101 (patched) <https://reviews.apache.org/r/61529/#comment260834> Wouldn't it be better to store all these dummy workflows in an external file? - Peter Bacsko On szept. 5, 2017, 3:52 du, Attila Sasvari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61529/ > ----------------------------------------------------------- > > (Updated szept. 5, 2017, 3:52 du) > > > Review request for oozie and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > New workflow xsd to allow changing launcher configuration (e.g. setting java > system properties) > > > Diffs > ----- > > client/src/main/resources/hive-action-1.0.xsd PRE-CREATION > client/src/main/resources/hive2-action-1.0.xsd PRE-CREATION > client/src/main/resources/oozie-common-1.0.xsd PRE-CREATION > client/src/main/resources/oozie-workflow-1.0.xsd PRE-CREATION > client/src/main/resources/shell-action-1.0.xsd PRE-CREATION > client/src/main/resources/spark-action-1.0.xsd PRE-CREATION > client/src/main/resources/sqoop-action-1.0.xsd PRE-CREATION > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > bca79aa052521ea4f6f16e76bd69f84fb16be790 > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 8fdc50cce15271c13b20d1aaab2ffb95cb8fa711 > core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > 7e3348550e2ef44ae4bd6c5a7a417052bf9c108a > core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 47bfd2bcf9b53eed0882c51cdb5c530e0f6ccfe7 > core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java > ffc29af2f834da6d0890ea7215c5a62fd7cd693e > core/src/main/java/org/apache/oozie/service/SchemaService.java > 137e2c0b4840c6d3858683db1aa38f54bd55be92 > core/src/main/java/org/apache/oozie/util/WritableUtils.java > aa027e37ba23d4f481698e0bcd93c26c763a0b1f > core/src/main/java/org/apache/oozie/util/schema/Input.java PRE-CREATION > core/src/main/java/org/apache/oozie/util/schema/ResourceResolver.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/workflow/lite/LauncherConfigHandler.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > a74e5c759fe3e336e7e98c61b8f5ac52efa4100c > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java > 23df0867e5984c518e8424d79365997bec28f619 > core/src/main/resources/oozie-default.xml > 0d174b5069aff36ca3a9d48722c5bba69623a046 > > core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > d74160a09ee237f4067e00ded526e7ec94528a6b > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > 6cee7a8948ca7f2c7aaf44d4f172d18a1308a482 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > ce674adf9cffa20690083e6298875a6f9047a109 > core/src/test/java/org/apache/oozie/service/TestSchemaService.java > 88a10dbead32879334c3953a90a411a3a18fc0b3 > core/src/test/java/org/apache/oozie/util/TestMetricsInstrumentation.java > a882c82b25154338f89e8a90f831b6f0300fbfe7 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 21332404bea79fe0a3cea045d57b3e52a1f15cae > core/src/test/resources/wf-schema-global-launcherconf-override.xml > PRE-CREATION > core/src/test/resources/wf-schema-global-launcherconf.xml PRE-CREATION > release-log.txt e2311eab6392ca08ad855da887e391f3f14a7408 > > sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java > d17d5beb76754655720a0e29079daf676c507841 > sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > fb3fabf027a1dda537d2bd86d574abaf95a685db > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > 6a98d6ef3a09a7a75272f3f0f9a9c2fc5472e76d > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > f1f52c6e876fae56c90979baef3d31a0f5ba2396 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 77aaa62e23185e6df053f01fd1c4db1f2e972f6b > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java > 6a73bf9b8b1d0c5cbb008594c75c9e779298a29d > > sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestLauncherMain.java > a793df1330d10828101abf9107d565db7972a95f > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 13ee04f4482471b61ee363f9cb98f04436c9e580 > sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/UDFTester.java > ff999ff2cd4875fbf3ad5e1a7eacf9972e848630 > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java > 8aa8343cfcfa136aedef0bf9d53fb4a11800e07c > sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > e889ef9f857e8417353f28ccb8870f9d843a9d33 > > > Diff: https://reviews.apache.org/r/61529/diff/4/ > > > Testing > ------- > > - TestJavaActionExecutor, TestLiteWorkflowAppParser tests passed > - java-main example on pseudo hadoop succeeded, modified workflow xml so that > verbose class loading information is printed out of stdout of the launcher job > > > Thanks, > > Attila Sasvari > >
