-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61560/#review185217
-----------------------------------------------------------




core/src/main/java/org/apache/oozie/action/hadoop/HDFSCredentials.java
Lines 15 (patched)
<https://reviews.apache.org/r/61560/#comment261502>

    Add _an_ HDFS_DELEGATION_TOKEN



core/src/main/java/org/apache/oozie/action/hadoop/HDFSCredentials.java
Lines 36 (patched)
<https://reviews.apache.org/r/61560/#comment261503>

    LOG.debug("...");



core/src/main/java/org/apache/oozie/action/hadoop/HadoopTokenHelper.java
Lines 23 (patched)
<https://reviews.apache.org/r/61560/#comment261504>

    Do we still need the JT?



core/src/main/java/org/apache/oozie/action/hadoop/HadoopTokenHelper.java
Lines 31 (patched)
<https://reviews.apache.org/r/61560/#comment261506>

    This Jvadoc comment seems to have gotten lost...



core/src/main/java/org/apache/oozie/action/hadoop/YarnRMCredentials.java
Lines 19 (patched)
<https://reviews.apache.org/r/61560/#comment261508>

    The syntax is actually
    ````
    {@link Credentials}
    ````
    (The '@' goes inside)
    
    If done correctly, the IDE should make it a clickable link if you hold CMD


- Robert Kanter


On Sept. 12, 2017, 1:40 p.m., Peter Cseh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61560/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2017, 1:40 p.m.)
> 
> 
> Review request for oozie, Attila Sasvari, Peter Bacsko, Robert Kanter, and 
> Rohini Palaniswamy.
> 
> 
> Bugs: OOZIE-2909
>     https://issues.apache.org/jira/browse/OOZIE-2909
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Changing UGI calls and cleaning up things around requesting tokens.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 
> 662e1edc9c4b23b3606c751bf5ed4b531ee7ac62 
>   
> core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProperties.java 
> 20f93ce57618a529b1bd83b398add2cd1d96b36e 
>   
> core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
>  5ca8d3e80942840a5bba51a06694350929044042 
>   core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java 
> 9804c7b673a899cd9c778850c9a64731cc642fb3 
>   core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java 
> 52abbf17afa71e702d7871d10a4a190a4d21e47b 
>   core/src/main/java/org/apache/oozie/action/hadoop/HDFSCredentials.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/action/hadoop/HadoopTokenHelper.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java 
> 4add5f14cb20ab77c755b81eff939335c0c5fddc 
>   core/src/main/java/org/apache/oozie/action/hadoop/Hive2Credentials.java 
> 0b495f75842b0033a3337ef6728a334bf5651770 
>   core/src/main/java/org/apache/oozie/action/hadoop/JHSCredentials.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 49fd4b8560b21aef725c3268f0ec0e7f46a46ee9 
>   core/src/main/java/org/apache/oozie/action/hadoop/YarnRMCredentials.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 
> 187cee2290ba4bbe358913d28a052d9c75f2369a 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopTokenHelper.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 
> d1d78fd527a425b076edd7bb23ba56ebdba62664 
>   core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 
> 960c2f9750062c98fdf7a2b456d3668069e07ca5 
>   
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/AMRMClientAsyncFactory.java
>  b4cbb4b1d9b52aaebfb562c02edc91e15a2a9a2e 
>   
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/HdfsOperations.java
>  874d371664ced3ae19a7b5d615c67d4c72e7cfdd 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 
> 6a98d6ef3a09a7a75272f3f0f9a9c2fc5472e76d 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java 
> bde7f1daf123d663d47f5d2fb2350cfa1ac33ed8 
>   
> sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestHdfsOperations.java
>  68c0f4bafe0322ff0d1007297cd6e8f38c92020a 
>   
> sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAM.java
>  37af3dd9ed43f4504ff3909484237e2d05665c6c 
> 
> 
> Diff: https://reviews.apache.org/r/61560/diff/4/
> 
> 
> Testing
> -------
> 
> We're running tests on a Kerberized cluster with these changes.
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>

Reply via email to