> On szept. 15, 2017, 12:27 du, András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java > > Lines 68 (patched) > > <https://reviews.apache.org/r/62350/diff/1/?file=1827863#file1827863line68> > > > > Since `Class.forName()` is an expensive operation, it might be worth > > caching its result.
We do this very rarely, only when we copy the sharelib, so it's OK in this case. > On szept. 15, 2017, 12:27 du, András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java > > Lines 80 (patched) > > <https://reviews.apache.org/r/62350/diff/1/?file=1827863#file1827863line80> > > > > Would be better name all the possible `Exception` subclasses that may > > arise. There are too many. All of them are related to dynamic method access/invocation. I wouldn't bother naming them separately. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62350/#review185480 ----------------------------------------------------------- On szept. 15, 2017, 12:07 du, Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62350/ > ----------------------------------------------------------- > > (Updated szept. 15, 2017, 12:07 du) > > > Review request for oozie, András Piros, Peter Cseh, and Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-3054 > > > Diffs > ----- > > tools/src/main/java/org/apache/oozie/tools/Hadoop3Support.java PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java a844aa0f8 > > > Diff: https://reviews.apache.org/r/62350/diff/1/ > > > Testing > ------- > > > Thanks, > > Peter Bacsko > >
