[ https://issues.apache.org/jira/browse/OOZIE-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176331#comment-16176331 ]
Hadoop QA commented on OOZIE-2909: ---------------------------------- Testing JIRA OOZIE-2909 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:green}+1{color} the patch does adds/modifies 1 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings . {color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} . Tests run: 2032 . Tests rerun: 108 . Tests failed at first run: org.apache.oozie.service.TestStatusTransitService,org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC,org.apache.oozie.action.hadoop.TestJavaActionExecutor, {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:green}*+1 Overall result, good!, no -1s*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/44/ > LauncherAM: rewrite UGI calls > ----------------------------- > > Key: OOZIE-2909 > URL: https://issues.apache.org/jira/browse/OOZIE-2909 > Project: Oozie > Issue Type: Sub-task > Reporter: Peter Bacsko > Assignee: Andras Piros > Priority: Blocker > Fix For: 5.0.0 > > Attachments: OOZIE-2909-001.patch, OOZIE-2909-002.patch, > OOZIE-2909-003.patch, OOZIE-2909-004.patch, OOZIE-2909-005.patch, > OOZIE-2909-006.patch, OOZIE-2909-007.patch, OOZIE-2909-008.patch, > OOZIE-2909-009.patch, OOZIE-2909-010.patch, OOZIE-2909.amend.001.patch > > > There are two problems in LauncherAM: > 1) In a kerberized cluster, we have to use {{UGI.getLoginUser()}} even though > a call to {{createRemoteUser()}} should be enough, just like in > {{MRAppMaster.java}}. Reference code: > https://github.com/apache/hadoop/blob/3ed3062fe3979ff55a411b730a8eee2b2c96d6b3/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java#L1718-L1726 > 2) It's enough if we wrap the whole LauncherAM logic in a single {{doAs()}} > call. No need for multiple {{doAs()}}, just makes the whole thing more > complicated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)