[
https://issues.apache.org/jira/browse/OOZIE-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188091#comment-16188091
]
Hadoop QA commented on OOZIE-2406:
----------------------------------
Testing JIRA OOZIE-2406
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 5 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
. {color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that
must be fixed.
. {color:red}-1{color} There are [1] new bugs found below threshold in [core]
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The most important FindBugs errors are:
. At GraphGenerator.java:[line 81]: The use of XMLReader.parse(...) is
vulnerable to XML External Entity attacks
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 2036
. Tests failed: 0
. Tests errors: 1
. The patch failed the following testcases:
.
. Tests failing with errors:
. testJMXInstrumentation(org.apache.oozie.util.TestMetricsInstrumentation)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/61/
> Completely rewrite GraphGenerator code
> --------------------------------------
>
> Key: OOZIE-2406
> URL: https://issues.apache.org/jira/browse/OOZIE-2406
> Project: Oozie
> Issue Type: New Feature
> Affects Versions: 4.2.0
> Reporter: Robert Kanter
> Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: graphviz-10-action-nodes.png,
> graphviz-25-action-nodes.png, graphviz-50-action-nodes.png,
> graphviz-many-nodes.png, jung-many-nodes.png, OOZIE-2406.004.patch,
> OOZIE-2406.004.patch, OOZIE-2406.005.patch, OOZIE-2406.006.patch,
> OOZIE-2406.007.patch, Screen Shot 2017-10-02 at 1.55.58 PM.png, Screen Shot
> 2017-10-02 at 1.56.33 PM.png
>
>
> The Web UI currently generates a graph of the workflow DAG as a png image
> that it can show to the user ({{GraphGenerator}} class). Unfortunately,
> there are a number of downsides to the current implementation:
> # The image is generated server-side, which doesn't scale well and eats up
> lots of memory
> #- To help combat this issue, we only generate graphs for workflows with less
> than 25 nodes and we disabled the refresh button in the UI
> # It's slow
> # It uses a library ({{net.sf.jung}} from http://jung.sourceforge.net), which
> hasn't been updated since 2010.
> #- This library also has a dependency on a fork of Commons-Collections
> ({{net.sourceforge.collections}} from
> http://sourceforge.net/projects/collections/), which similarly hasn't been
> updated since 2010. This is a problem because we can't update
> Commons-Collections when there are security concerns such as COLLECTIONS-580
> (though Oozie is *not* susceptible to this attack).
> It would be good to do a complete rewrite, using a different library and
> remove Jung and the Commons-Collections fork. Whatever we choose, it should
> an svg which will draw the image on the browser.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
