> On Oct. 4, 2017, 10:07 a.m., Peter Cseh wrote: > > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > > Lines 54-56 (patched) > > <https://reviews.apache.org/r/62352/diff/6/?file=1845354#file1845354line54> > > > > Can this be null?
Test case removed. > On Oct. 4, 2017, 10:07 a.m., Peter Cseh wrote: > > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > > Lines 64-65 (patched) > > <https://reviews.apache.org/r/62352/diff/6/?file=1845354#file1845354line64> > > > > Can this ever be null? Test case removed. > On Oct. 4, 2017, 10:07 a.m., Peter Cseh wrote: > > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > > Lines 108-109 (patched) > > <https://reviews.apache.org/r/62352/diff/6/?file=1845354#file1845354line108> > > > > Can you add an assert here that validates that it's a dot format and > > contains some information? Yep, the same for SVGs. > On Oct. 4, 2017, 10:07 a.m., Peter Cseh wrote: > > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > > Lines 127-140 (patched) > > <https://reviews.apache.org/r/62352/diff/6/?file=1845354#file1845354line127> > > > > Can you consolidate down the test cases? The testManyNodesX() can have > > a basic assertion for PNG, dot and svg. Reorganized test cases, deleted and renamed a few of them in following classes: - simple graph: whether graph generation and writing to output formats PNG, DOT or SVG is correct - more sophisticated graph that doesn't have decision, fork, or join nodes: test that graph generation is correct - even more sophisticated graph that has decision, fork, and join nodes: test that graph generation is correct - András ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review187077 ----------------------------------------------------------- On Oct. 3, 2017, 9:05 p.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62352/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2017, 9:05 p.m.) > > > Review request for oozie and Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2406 Completely rewrite GraphGenerator code > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 74843dc9a3cbb8cef38e97f81e34731f191d9aab > core/pom.xml 6f9adb66af9344ac7d2212cdc31aa203ec06c286 > core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java > 059d3cf6dc251b49940af29d82cbdd817043a176 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 > core/src/main/java/org/apache/oozie/util/GraphGenerator.java > 6ded2c6dc15c9e8453ff800407ff0324be185f41 > core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java > PRE-CREATION > core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java > ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 > core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java > 002e925b57cd830ea6d83a87cea4383165116b80 > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > PRE-CREATION > core/src/test/resources/graphWF.xml > 6a7b0427a9951835a7533a04b66258ded369d5bf > core/src/test/resources/graphWF_26_actions.xml > a091be0f3559ede195ccc3339adee4478a8da8c0 > core/src/test/resources/graphWF_50_actions.xml PRE-CREATION > core/src/test/resources/graphWF_decision_fork_join.xml PRE-CREATION > docs/src/site/twiki/WebServicesAPI.twiki > ef3e60242512decd48beb3d8c9ac747b7d128eda > examples/src/main/apps/java-main/workflow.xml > 98e01ca92187e1c567686f6c2b4f689bb2a5ef6a > pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c > webapp/src/main/webapp/oozie-console.js > 72c8a198a4ffe60f74a9f700831f65efcb3066c4 > > > Diff: https://reviews.apache.org/r/62352/diff/6/ > > > Testing > ------- > > `TestGraphGenerator`, `TestV1JobServlet` > > > Thanks, > > András Piros > >
