-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64029/
-----------------------------------------------------------

(Updated Nov. 23, 2017, 7:19 p.m.)


Review request for oozie.


Changes
-------

Support for `HiveAction` added.


Repository: oozie-git


Description
-------

OOZIE-2339 Provide an API for writing jobs based on the XSD schemas


Diffs (updated)
-----

  .gitignore a4285a0d77ac2e4e8fc4afbfa21bf9fd287b3e4d 
  bin/test-patch 33a6d11758303229b9f62783567398dd9dbfa7d3 
  client/src/main/java/org/apache/oozie/client/OozieClient.java 
7fb1cf32cc034234a23c40556b93ea2e638ca7af 
  core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java 
38fb006980c0acb582b4f91175be1ced8a1afa79 
  core/src/main/java/org/apache/oozie/local/LocalOozie.java 
9ab646cd53223d903e387eb92aa103a7b6577d0f 
  core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java 
7bf8fb3f0ce9253d553c7b1883666811686f6a9f 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 
ef019e736dab90cfdad74210570cd6e571662a2d 
  core/src/main/java/org/apache/oozie/util/Instrumentation.java 
a57b6655da6a6c28eb857691336ab27508ee8092 
  core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 
ee906f45629e38fccf0e9d5cde7e81ad5f534b59 
  core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 
12ede028655f2a30613a9f802e48cd3a27af6ed9 
  docs/src/site/twiki/DG_SLAMonitoring.twiki 
29dd395be84b77ef501b3a52e1bd292aa10f8d90 
  jobs-api/pom.xml PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/Condition.java PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/GraphVisualization.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/ModifyOnce.java PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/ActionAttributes.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/ActionAttributesBuilder.java
 PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Builder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/ChFSBase.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/ChFSBaseBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Chgrp.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/ChgrpBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Chmod.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/ChmodBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Delete.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/DistcpAction.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/DistcpActionBuilder.java
 PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/EmailAction.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/EmailActionBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/ErrorHandler.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/FSAction.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/FSActionBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Hive2Action.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Hive2ActionBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/HiveAction.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/HiveActionBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Launcher.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/LauncherBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/MapReduceAction.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/MapReduceActionBuilder.java
 PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Mkdir.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Move.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Node.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/NodeBuilderBaseImpl.java
 PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Pipes.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/PipesBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Prepare.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/PrepareBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/SparkAction.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/SparkActionBuilder.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Streaming.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/StreamingBuilder.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/SubWorkflowAction.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/action/SubWorkflowActionBuilder.java
 PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/action/Touchz.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/BooleanToFLAGConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/DecisionConverter.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/DistcpConfigurationConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/DistcpPrepareConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/DozerMapperSingletonWrapper.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/ExplicitNodeConverter.java
 PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/ForkConverter.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/GraphNodes.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/GraphNodesToWORKFLOWAPPConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/GraphToWORKFLOWAPPConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/Hive2ConfigurationConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/Hive2LauncherConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/Hive2PrepareConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/HiveConfigurationConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/HiveLauncherConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/HivePrepareConverter.java
 PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/JoinConverter.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/MapToConfigurationPropertyConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/RealChildLocator.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/SparkConfigurationConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/SparkLauncherConverter.java
 PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/SparkPrepareConverter.java
 PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/mapping/StartConverter.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/DagNodeWithCondition.java
 PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/Decision.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/DecisionJoin.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/End.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/ExplicitNode.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/Fork.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/Graph.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/Join.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/JoiningNodeBase.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/NodeBase.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/oozie/dag/Start.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/serialization/Serializer.java 
PRE-CREATION 
  jobs-api/src/main/java/org/apache/oozie/jobs/api/workflow/Workflow.java 
PRE-CREATION 
  
jobs-api/src/main/java/org/apache/oozie/jobs/api/workflow/WorkflowBuilder.java 
PRE-CREATION 
  jobs-api/src/main/resources/action_mappings.xml PRE-CREATION 
  jobs-api/src/main/resources/checkstyle-header.txt PRE-CREATION 
  jobs-api/src/main/resources/checkstyle.xml PRE-CREATION 
  jobs-api/src/main/resources/dozer_config.xml PRE-CREATION 
  jobs-api/src/main/resources/mappingGraphToWORKFLOWAPP.xml PRE-CREATION 
  jobs-api/src/main/xjb/bindings.xml PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/NodesToPng.java PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/TestCondition.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/TestJAXBWorkflow.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/TestModifyOnce.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestActionAttributesBuilder.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestChBaseBuilder.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestChgrpBuilder.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestChmodBuilder.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestDelete.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestDistcpActionBuilder.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestEmailActionBuilder.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestErrorHandler.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestFSActionBuilder.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestHive2ActionBuilder.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestHiveActionBuilder.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestLauncherBuilder.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestMapReduceActionBuilder.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestMove.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestNodeBuilderBaseImpl.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestPipesBuilder.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestPrepareBuilder.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestSparkActionBuilder.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestStreamingBuilder.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestSubWorkflowBuilder.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/action/TestTouchz.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/examples/TestDistcpAction.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/examples/TestEmailAction.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/examples/TestFSAction.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/examples/TestHive2Action.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/examples/TestHiveAction.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/examples/TestMapReduceAction.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/examples/TestSparkAction.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestConfigurationMapping.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestControlNodeMappingBase.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestDecisionMapping.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestDeleteMapping.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestDistcpActionMapping.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestEmailActionMapping.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestEndMapping.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestExplicitNodeMapping.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestFSActionMapping.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestForkMapping.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestGraphMapping.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestHive2ActionMapping.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestHiveActionMapping.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestJoinMapping.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestMapReduceActionMapping.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestMappings.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestMkdirMapping.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestPipesMapping.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestPrepareMapping.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestSparkActionMapping.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestStartMapping.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestStreamingMapping.java
 PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/mapping/TestSubWorkflowActionMapping.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestDecision.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestDecisionJoin.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestEnd.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestExplicitNode.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestFork.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestGraph.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestJoin.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestJoiningNodeBase.java
 PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestNodeBase.java 
PRE-CREATION 
  jobs-api/src/test/java/org/apache/oozie/jobs/api/oozie/dag/TestStart.java 
PRE-CREATION 
  
jobs-api/src/test/java/org/apache/oozie/jobs/api/workflow/TestWorkflowBuilder.java
 PRE-CREATION 
  jobs-api/src/test/resources/workflow-all-actions.xml PRE-CREATION 
  jobs-api/src/test/resources/workflow-mapreduce-action.xml PRE-CREATION 
  minitest/pom.xml 82c27b6ebee55f339627723c688c951462d11a79 
  minitest/src/test/java/org/apache/oozie/test/TestWorkflow.java 
4257b60b132d40a9bbaf24ec75ae1a125ecb6855 
  minitest/src/test/java/org/apache/oozie/test/WorkflowTestCase.java 
PRE-CREATION 
  pom.xml cc36f2d3ed435fe9c748c60e7203d369f87ecd3c 
  release-log.txt 462087598a84d1cf6fa3f9637935204cdd46c96c 
  
sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAMCallbackNotifier.java
 3d86b8791642d2ab99a328d9004b9973f2e58e21 
  sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 
7bf45e35631e23ec4bda49bd865f553e14fa3ac9 
  
sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LocalFsOperations.java
 3784ea3981ba19d68beda1707774cf7f8db325a9 


Diff: https://reviews.apache.org/r/64029/diff/3/

Changes: https://reviews.apache.org/r/64029/diff/2-3/


Testing
-------

More hundred JUnit test cases under `jobs-api` module. Some of these leverage 
`TestWorkflow` from `minitest` that uses `OozieClient`, `MiniDFSCluster`, 
`MiniMRCluster` for integration testing.


Thanks,

András Piros

Reply via email to