> On Dec. 1, 2017, 3:51 p.m., Peter Bacsko wrote: > > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java > > Line 292 (original), 293 (patched) > > <https://reviews.apache.org/r/64245/diff/1/?file=1905758#file1905758line293> > > > > Nit: this isn't too helpful
The function itself is not that helpful :) - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64245/#review192496 ----------------------------------------------------------- On Dec. 1, 2017, 11:45 a.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64245/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 11:45 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2681 > https://issues.apache.org/jira/browse/OOZIE-2681 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2681 > fix javadoc to compile on JDK8 again > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/CLIParser.java > 3930276f6dea23a774fed51421b9151bc158be29 > client/src/main/java/org/apache/oozie/cli/OozieCLI.java > d837c84af4667c94c1a234370457d5c075065628 > client/src/main/java/org/apache/oozie/client/Job.java > 277e112722e6ee838aed3977ce3429d98ae34745 > client/src/main/java/org/apache/oozie/client/OozieClient.java > 7fb1cf32cc034234a23c40556b93ea2e638ca7af > > client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java > d1588e930c9df40ec77f428267c840944a81a81d > > client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > fe31061fe6fbcefa36415cca55e409fcf25ad9ec > > client/src/main/java/org/apache/oozie/client/event/message/CoordinatorActionMessage.java > d6209c529b8be82f40feb74ce4173537b84e68f2 > > client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java > 382bb82bf32469c5836a9b0fc70cf573d6b94560 > client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java > c51b2f94dd98b99b2f1dd74fdc76e6f87c5a517a > client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java > 96f9d675db2cd3d307bfa1c25794bfd50b58e820 > > client/src/main/java/org/apache/oozie/client/event/message/WorkflowJobMessage.java > b204ccd78a4274a2fae9c0d402ecd035a69729e6 > core/src/main/java/org/apache/oozie/BaseEngine.java > 6a8ebfffb2bf83dae86336858fc4da64636564e9 > core/src/main/java/org/apache/oozie/BinaryBlob.java > d1971fc75571cbf7be20175a25b308b1ed122d4c > core/src/main/java/org/apache/oozie/BundleActionBean.java > ccc18d9f15f745b22f67dbd8dd21f8dffd613863 > core/src/main/java/org/apache/oozie/BundleJobBean.java > 5868412514209b7010e6d58fe6341650fea0b92b > core/src/main/java/org/apache/oozie/CoordinatorEngine.java > 89fda05f2dee90f9c654f199532b73beb87d8b02 > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java > b6e0b7e4c39363968a07a5770d23791d0c16264e > core/src/main/java/org/apache/oozie/DagEngine.java > 01cf44922dd81d3cbcc34e3e4f1bb7b2a6be9ad0 > core/src/main/java/org/apache/oozie/LocalOozieClient.java > 123725f5d54e01d930d2c29538f848fcc2f5db7c > core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java > 3c229bea77f86c4241f837d70cb4d1059e7eb24d > core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java > d1e6972ac47cd33fcc7f8b358713cf0ee94ab3ec > core/src/main/java/org/apache/oozie/StringBlob.java > 9e8d3837b89ebe399a253c708946126924180d9a > core/src/main/java/org/apache/oozie/WorkflowActionBean.java > 14f36ed67a893cd94a7dbf7340caecf6af165e78 > core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java > 374c6ef38d78573683bea90332cb737848f8d6c8 > core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java > 12576407285bc4b5d8cfa0ec03a2fe049661c743 > core/src/main/java/org/apache/oozie/compression/CodecFactory.java > 72cf38598f5a9989f6d1c84db287f74c5785edab > core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java > 4230a201cc1d581957162355bb77955055e68d45 > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 76d837c1f16834b58cb2589378de1fd83afe9d05 > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java > 4a2a0b088945ba36cf2530e6382ae33fa51a574e > > core/src/main/java/org/apache/oozie/coord/input/logic/CoordInputLogicEvaluatorPhaseOne.java > 52e03d9839f01e8fcbc9c0fdee179467b9ac5c98 > > core/src/main/java/org/apache/oozie/coord/input/logic/CoordInputLogicEvaluatorUtil.java > 653fb2a32bf01ad297125cc66df6b29bd52607e6 > core/src/main/java/org/apache/oozie/dependency/DependencyChecker.java > bdd854ffb7025c71ee04d433b2dd7d60afcfa07c > core/src/main/java/org/apache/oozie/dependency/URIHandler.java > da68b0005d130bd42cf2f4cc72729115a06901b4 > > core/src/main/java/org/apache/oozie/dependency/hcat/HCatDependencyCache.java > a5a31e4c2abbb469704e6ac2c0a68ec1812e93a7 > core/src/main/java/org/apache/oozie/service/UUIDService.java > faddd6d217252e4d63821416c335783552a21d17 > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > 97c2007fbe3cf51a9fa6cb8ccc48919c251af4fd > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java > b6a896f8201705116e1e13e643a67c9b93860d20 > core/src/main/java/org/apache/oozie/servlet/ErrorServlet.java > 94e93bfcb2f39e8ab31a9ce22246c2cd86cb907d > core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java > 0f2279651b4f1caf073967dedb166c3750c4c853 > core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java > a7b092124675b4372599749df34eb2d5d263897f > core/src/main/java/org/apache/oozie/test/EmbeddedServletContainer.java > 59d20b577ef82f401dfe996fb666f70c298ade14 > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 1c565ef3e3e3895c10587c739268b4d57f2a888c > core/src/main/java/org/apache/oozie/util/DateUtils.java > 64fded5d824fdd5a730405ca66e2a5a303343c3e > core/src/main/java/org/apache/oozie/util/ELEvaluator.java > 84eaa3decc237c3ccb3900a03f83b514ea6fe9a8 > core/src/main/java/org/apache/oozie/util/JobUtils.java > 681b58a850f8b9888e31324e2a5b1e78711222ef > core/src/main/java/org/apache/oozie/util/MappingRule.java > c1f615edc825f3d2248e1c3a6bc37de27985f291 > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java > 9d69f745a8011964abfdc9f8e781efc8b11fc248 > core/src/main/java/org/apache/oozie/util/ParamChecker.java > 8debeeffb2d821ba5d9589baa00e7c24fe0c41c3 > core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java > 72286200ed6a6fabd0652688b0d6cbe6b1adb63c > core/src/main/java/org/apache/oozie/util/PropertiesUtils.java > 3e24e00de3b39eb5b2088bbe51594782bd3ff1d7 > > core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java > 0b96ad4e3fe33655c6b2b00e2fcd29b31a43626f > core/src/main/java/org/apache/oozie/util/StatusUtils.java > 69d726598db92710802ab762c786f40344bc73d9 > core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java > feefb694fe6dd608b3d61b8167a74fbdc6144de5 > core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > 7fa8a602a03f5952861b6dd857f738eccafc7e03 > core/src/main/java/org/apache/oozie/util/WritableUtils.java > 5a4cb24bbfcbe85168c318bfc5b0ecf11b7944a2 > core/src/main/java/org/apache/oozie/util/XCallable.java > 2c034a4dc03861f57c736a810145af912ae63213 > core/src/main/java/org/apache/oozie/util/XLog.java > 9ecac4dace4d66f19a5e08828dc2c00c50b729d0 > core/src/main/java/org/apache/oozie/util/XLogFilter.java > 1fba33b39b24baacd22904e6ec3709d73956d9ea > core/src/main/java/org/apache/oozie/util/XLogStreamer.java > 012fbefc32895e9e8ad1b45ebde1713b3e1103e5 > core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java > 1fe59e3d28c7d890f067a9c6ddc7021c095bd234 > core/src/main/java/org/apache/oozie/util/XmlUtils.java > f8502369accf21f8d15b56c648532323f644e2ad > core/src/main/java/org/apache/oozie/util/ZKUtils.java > 5835fb2bd7460809743d21ac16f2992c353ada71 > core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java > c972ea264fb2b69f4721a86228e0c859330b346b > core/src/main/java/org/apache/oozie/util/db/FailingMySQLDriverWrapper.java > f7af57c9c9c5a0276d35e1b674aedb5530f2cada > > core/src/main/java/org/apache/oozie/util/db/PersistenceExceptionSubclassFilterRetryPredicate.java > ddf38d2ca39ccb8304d4ad9c36d72d06896c6e30 > core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java > 285827dd2b74a3dfce1fa2dcfe9004512ac29a83 > core/src/main/java/org/apache/oozie/util/db/Schema.java > cb0e24dbac1ff12b936196090b2f3f1430cece22 > core/src/main/java/org/apache/oozie/util/db/SqlStatement.java > e2e0613bf1bef2f95222d1ec4d2e6faa3d14bec5 > core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java > 12848d21b833d1671b5457da636d278a27b4a734 > pom.xml cc36f2d3ed435fe9c748c60e7203d369f87ecd3c > server/src/main/java/org/apache/oozie/server/EmbeddedOozieServer.java > 620b62f9ef1db8c4abd4cb887e417fcf5b2d34b6 > server/src/main/java/org/apache/oozie/server/JspHandler.java > 453998a188c521673032f3edcaf4c3072918d87f > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java > 88ad7625d89e497af0c1bb963cd2229142296725 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/HdfsOperations.java > fcb0a9233b4b1259891eac0ae63b454e9e2acb53 > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/JavaMain.java > f98c781b09de3f932999f9715674d4b6e7f0ba6c > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAMCallbackNotifier.java > 3d86b8791642d2ab99a328d9004b9973f2e58e21 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > 7bf45e35631e23ec4bda49bd865f553e14fa3ac9 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandler.java > ec6ee00e4a35f9846e1e841a6271da94f4406300 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java > 82c5f4055ae6e7d3b7a033ace7230e2ab6aa8a9b > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LocalFsOperations.java > 3784ea3981ba19d68beda1707774cf7f8db325a9 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieActionConfigurator.java > c2a100ee838efc0768bba7a2580e7b6dc71d3c24 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java > b5f7a860db3d3003f2f9cc67adb03dbe61af5a01 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsHandler.java > b5377b119fc04323521938279c95a75b2a249b20 > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java > 27607f66dee0402546d09dbaeebcd5e1711c1030 > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > a0b7165e051adc07ad73ee7f40a065889616cb80 > > > Diff: https://reviews.apache.org/r/64245/diff/1/ > > > Testing > ------- > > > Thanks, > > Peter Cseh > >
