----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63739/#review194265 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/ZKLocksService.java Lines 240 (patched) <https://reviews.apache.org/r/63739/#comment272993> You should log the retry number as well core/src/test/java/org/apache/oozie/service/TestZKLocksService.java Lines 584 (patched) <https://reviews.apache.org/r/63739/#comment272994> Try to keep runtime of every test under 30 sec - 1 min. core/src/test/java/org/apache/oozie/service/TestZKLocksService.java Lines 601 (patched) <https://reviews.apache.org/r/63739/#comment272995> You should have a catch block and fail the test if there is any exception - Rohini Palaniswamy On Nov. 27, 2017, 7:22 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63739/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2017, 7:22 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3113 > https://issues.apache.org/jira/browse/OOZIE-3113 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3113 Retry for ZK lock release > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/ZKLocksService.java 2c71c001f > core/src/main/resources/oozie-default.xml 8285df0a7 > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > d04f04e80 > > > Diff: https://reviews.apache.org/r/63739/diff/2/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Satish Saley > >