[ 
https://issues.apache.org/jira/browse/OOZIE-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305175#comment-16305175
 ] 

Julia Kinga Marton edited comment on OOZIE-3145 at 12/28/17 8:45 AM:
---------------------------------------------------------------------

Not only TestDistcpMain produces garbage, I run the tests from core and from 
sharelib and they produced a lot of garbage. See the attached 
[^Oozie_test_garbage.png]. 

In most of the cases the files are created by the tested methods, not by the 
test case itself. I also found an open issue related the creation place of the 
files: [OOZIE-3025].

I think that we should change the place where the files are created in the 
[OOZIE-3025] issue, and then to make a general cleanup (for the other cases as 
well, not only for TestDistcpMain).

What do you think [~asasvari] ?  


was (Author: kmarton):
Not only TestDistcpMain produces garbage, I run the tests from core and from 
sharelib and they produced a lot of garbage. See the attached 
Oozie_test_garbage.png. 

In most of the cases the files are created by the tested methods, not by the 
test case itself. I also found an open issue related the creation place of the 
files: [OOZIE-3025].

I think that we should change the place where the files are created in the 
[OOZIE-3025] issue, and then to make a general cleanup (for the other cases as 
well, not only for TestDistcpMain).

What do you think [~asasvari] ?  

> TestDistcpMain shall remove created files after test execution
> --------------------------------------------------------------
>
>                 Key: OOZIE-3145
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3145
>             Project: Oozie
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 5.0.0b1
>            Reporter: Attila Sasvari
>         Attachments: Oozie_test_garbage.png
>
>
> After running TestDistcpMain, local files created are not removed. Subsequent 
> test runs will reuse those files and fail:
> {code}
> $ ls -lrt /home/asasvari/workspace/oozie/core/distcp*
> -rw-rw-r-- 1 asasvari asasvari 1025 Dec 21 18:25 
> /home/asasvari/workspace/oozie/core/distcp-log4j.properties
> -rw-rw-r-- 1 asasvari asasvari 5756 Dec 21 18:26 
> /home/asasvari/workspace/oozie/core/distcp-oozie-1513876931701.log
> {code}
> Those files should be removed after test execution. It would be better to use 
> the oozie/core/target directory so that mvn could clean it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to