----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65177/#review195561 -----------------------------------------------------------
sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestJarFilter.java Line 47 (original), 49 (patched) <https://reviews.apache.org/r/65177/#comment274814> can we create the jar in a temporary folder or in target/ instead of deleting it after the fact? - Peter Cseh On Jan. 16, 2018, 2:45 p.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65177/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2018, 2:45 p.m.) > > > Review request for oozie, András Piros, Attila Sasvari, and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > After running TestDistcpMain, local files created are not removed. Subsequent > test runs will reuse those files and fail: > `$ ls -lrt /home/asasvari/workspace/oozie/core/distcp*` > `-rw-rw-r-- 1 asasvari asasvari 1025 Dec 21 18:25 > /home/asasvari/workspace/oozie/core/distcp-log4j.properties` > `-rw-rw-r-- 1 asasvari asasvari 5756 Dec 21 18:26 > /home/asasvari/workspace/oozie/core/distcp-oozie-1513876931701.log` > Those files should be removed after test execution. It would be better to use > the oozie/core/target directory so that mvn could clean it. > > > Diffs > ----- > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > a3b3b7b3 > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8c2aa982 > core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > 728916ec > core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 505049d2 > core/src/test/java/org/apache/oozie/test/XTestCase.java 8cecb89b > > sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java > 35c2865e > sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java > 9a185c91 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestJarFilter.java > ff1b3cef > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java > b9f37c84 > tools/src/test/java/org/apache/oozie/tools/TestOozieMySqlDBCLI.java > a7df5c79 > > > Diff: https://reviews.apache.org/r/65177/diff/1/ > > > Testing > ------- > > I`ve run a mvn clean test and the repository remained clean. > > > Thanks, > > Kinga Marton > >
